From dbf84d213d7914558902ea99c5de4e4733113629 Mon Sep 17 00:00:00 2001 From: Jack Zhang <32371937+jackzhxng@users.noreply.github.com> Date: Fri, 9 May 2025 10:16:21 -0700 Subject: [PATCH 1/3] Rename "topic: not user facing" [ghstack-poisoned] --- .github/scripts/label_utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/scripts/label_utils.py b/.github/scripts/label_utils.py index 81668dad0cb..92dfc47516c 100644 --- a/.github/scripts/label_utils.py +++ b/.github/scripts/label_utils.py @@ -24,10 +24,10 @@ LABEL_ERR_MSG = f"""# {LABEL_ERR_MSG_TITLE} If your changes are user facing and intended to be a part of release notes, please use a label starting with `release notes:`. -If not, please add the `topic: not user facing` label. +If not, please add the `release notes: n/a (exclude)` label. To add a label, you can comment to pytorchbot, for example -`@pytorchbot label "topic: not user facing"` +`@pytorchbot label "release notes: n/a (exclude)"` For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work. @@ -115,7 +115,7 @@ def has_required_labels(pr: "GitHubPR") -> bool: pr_labels = pr.get_labels() # Check if PR is not user facing is_not_user_facing_pr = any( - label.strip() == "topic: not user facing" for label in pr_labels + label.strip() == "release notes: n/a (exclude)" for label in pr_labels ) return is_not_user_facing_pr or any( label.strip() in get_release_notes_labels(pr.org, pr.project) From bac7a2de8d9b8be65619cbe5f40724be9db0e532 Mon Sep 17 00:00:00 2001 From: Jack Zhang <32371937+jackzhxng@users.noreply.github.com> Date: Mon, 12 May 2025 11:10:36 -0700 Subject: [PATCH 2/3] Update on "Rename "topic: not user facing"" [ghstack-poisoned] --- .github/scripts/label_utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/scripts/label_utils.py b/.github/scripts/label_utils.py index 92dfc47516c..64c0b6791ce 100644 --- a/.github/scripts/label_utils.py +++ b/.github/scripts/label_utils.py @@ -24,10 +24,10 @@ LABEL_ERR_MSG = f"""# {LABEL_ERR_MSG_TITLE} If your changes are user facing and intended to be a part of release notes, please use a label starting with `release notes:`. -If not, please add the `release notes: n/a (exclude)` label. +If not, please add the `release notes: none` label. To add a label, you can comment to pytorchbot, for example -`@pytorchbot label "release notes: n/a (exclude)"` +`@pytorchbot label "release notes: none"` For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work. @@ -115,7 +115,7 @@ def has_required_labels(pr: "GitHubPR") -> bool: pr_labels = pr.get_labels() # Check if PR is not user facing is_not_user_facing_pr = any( - label.strip() == "release notes: n/a (exclude)" for label in pr_labels + label.strip() == "release notes: none" for label in pr_labels ) return is_not_user_facing_pr or any( label.strip() in get_release_notes_labels(pr.org, pr.project) From 636fd661d3862b5de39596e195d31dad89cf4297 Mon Sep 17 00:00:00 2001 From: Jack Zhang <32371937+jackzhxng@users.noreply.github.com> Date: Mon, 12 May 2025 11:59:29 -0700 Subject: [PATCH 3/3] Update on "Rename "topic: not user facing"" [ghstack-poisoned] --- .github/scripts/label_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/label_utils.py b/.github/scripts/label_utils.py index 64c0b6791ce..5a9c15bf3c1 100644 --- a/.github/scripts/label_utils.py +++ b/.github/scripts/label_utils.py @@ -22,7 +22,7 @@ LABEL_ERR_MSG_TITLE = "This PR needs a `release notes:` label" LABEL_ERR_MSG = f"""# {LABEL_ERR_MSG_TITLE} -If your changes are user facing and intended to be a part of release notes, please use a label starting with `release notes:`. +If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with `release notes:`. If not, please add the `release notes: none` label.