Skip to content

Enable OSS coreml python tests #10975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metascroy merged 3 commits into from
May 30, 2025
Merged

Enable OSS coreml python tests #10975

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cb2662
up
metascroy May 19, 2025
ffa3646
Merge branch 'main' into enable-coreml-tests
metascroy May 19, 2025
362265c
Merge branch 'main' into enable-coreml-tests
metascroy May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ addopts =
--ignore=backends/xnnpack/test/ops/test_sdpa.py
backends/xnnpack/test/passes
backends/xnnpack/test/serialization
# backends/apple/coreml
Copy link
Contributor

@jathu jathu May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: delete

Suggested change
# backends/apple/coreml

backends/apple/coreml/test
Copy link
Contributor

@jathu jathu May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail on non-Apple platforms. We need to see if we can selectively include this only on macOS

Copy link
Contributor Author

@metascroy metascroy May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jathu yeah, I saw this in the CI failures. Is there currently a good way to specify this granularity in ET's testing framework?

Copy link
Contributor

@jathu jathu May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try adding a --ignore option for linux here:

https://github.com/pytorch/executorch/blob/cb3eba0d7f630bc8cec0a9cc1df8ae2f17af3f7a/.ci/scripts/unittest-linux-cmake.sh#L10C1-L10C7

# extension/
extension/llm/modules/test
extension/llm/export
Expand Down
Loading