Skip to content

[ET-VK][Ops] aten.tan.default in unary_ops #11047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 27, 2025
Merged

[ET-VK][Ops] aten.tan.default in unary_ops #11047

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4953d4c
[ET-VK][Ops] aten.tan.default in unary_ops
May 21, 2025
13460f2
Update on "[ET-VK][Ops] aten.tan.default in unary_ops"
May 21, 2025
1be2627
Update on "[ET-VK][Ops] aten.tan.default in unary_ops"
May 21, 2025
546eb60
Update on "[ET-VK][Ops] aten.tan.default in unary_ops"
May 22, 2025
1c1aecd
Update on "[ET-VK][Ops] aten.tan.default in unary_ops"
May 22, 2025
caa9d14
Update on "[ET-VK][Ops] aten.tan.default in unary_ops"
May 23, 2025
5bbeea3
Update on "[ET-VK][Ops] aten.tan.default in unary_ops"
May 23, 2025
5392bdb
Update on "[ET-VK][Ops] aten.tan.default in unary_ops"
May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions backends/vulkan/runtime/graph/ops/glsl/tan.glsl
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions backends/vulkan/runtime/graph/ops/glsl/tan.yaml
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions backends/vulkan/runtime/graph/ops/glsl/unary_op.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,5 @@ unary_op:
OPERATOR: leaky_relu(X, A)
- NAME: round
OPERATOR: round(X)
- NAME: tan
OPERATOR: tan(X)
64 changes: 0 additions & 64 deletions backends/vulkan/runtime/graph/ops/impl/Tan.cpp
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions backends/vulkan/runtime/graph/ops/impl/UnaryOp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ DEFINE_ACTIVATION_FN(hardswish);
DEFINE_ACTIVATION_FN(hardsigmoid);
DEFINE_LEAKY_RELU_FN(leaky_relu);
DEFINE_ACTIVATION_FN(round);
DEFINE_ACTIVATION_FN(tan);

REGISTER_OPERATORS {
VK_REGISTER_OP(aten.abs.default, abs);
Expand All @@ -174,6 +175,7 @@ REGISTER_OPERATORS {
VK_REGISTER_OP(aten.hardsigmoid.default, hardsigmoid);
VK_REGISTER_OP(aten.leaky_relu.default, leaky_relu);
VK_REGISTER_OP(aten.round.default, round);
VK_REGISTER_OP(aten.tan.default, tan);
}

} // namespace vkcompute
17 changes: 1 addition & 16 deletions backends/vulkan/test/op_tests/cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,7 @@ def get_reduce_op_inputs():
"aten.hardsigmoid.default",
"aten.leaky_relu.default",
"aten.round.default",
"aten.tan.default",
]
)
def get_unary_ops_inputs():
Expand All @@ -1164,22 +1165,6 @@ def get_unary_ops_inputs():
return test_suite


# separate test suite from unary_ops for learning purposes
@register_test_suite("aten.tan.default")
def get_tan_inputs():
test_suite = VkTestSuite(
[
(M1,),
(M1, M2),
(S1, M1, M2),
(S1, S2, S2, M2),
]
)
test_suite.storage_types = ["utils::kTexture3D", "utils::kBuffer"]
test_suite.dtypes = ["at::kFloat"]
return test_suite


@register_test_suite("aten._native_batch_norm_legit_no_training.default")
def get_native_batch_norm_inputs():
Test = namedtuple(
Expand Down
Loading