From f00fce9f64e7dcaeba9af2b612ca4b0de0cf16c7 Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Thu, 29 May 2025 12:48:53 -0700 Subject: [PATCH 1/7] Retire kernels_portable framework in favor of kernels_optimized --- scripts/build_apple_frameworks.sh | 9 --------- 1 file changed, 9 deletions(-) diff --git a/scripts/build_apple_frameworks.sh b/scripts/build_apple_frameworks.sh index a43deed9ab7..fd457d9f21c 100755 --- a/scripts/build_apple_frameworks.sh +++ b/scripts/build_apple_frameworks.sh @@ -65,11 +65,6 @@ liboptimized_native_cpu_ops_lib.a,\ libportable_kernels.a,\ :" -FRAMEWORK_KERNELS_PORTABLE="kernels_portable:\ -libportable_kernels.a,\ -libportable_ops_lib.a,\ -:" - FRAMEWORK_KERNELS_QUANTIZED="kernels_quantized:\ libquantized_kernels.a,\ libquantized_ops_lib.a,\ @@ -86,7 +81,6 @@ usage() { echo " --custom Only build the Custom kernels." echo " --mps Only build the Metal Performance Shaders backend." echo " --optimized Only build the Optimized kernels." - echo " --portable Only build the Portable kernels." echo " --quantized Only build the Quantized kernels." echo " --xnnpack Only build the XNNPACK backend." echo @@ -104,7 +98,6 @@ set_cmake_options_override() { "-DEXECUTORCH_BUILD_KERNELS_CUSTOM=OFF" "-DEXECUTORCH_BUILD_MPS=OFF" "-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=OFF" - "-DEXECUTORCH_BUILD_PORTABLE_OPS=OFF" "-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=OFF" "-DEXECUTORCH_BUILD_XNNPACK=OFF" ) @@ -135,7 +128,6 @@ for arg in "$@"; do --custom) set_cmake_options_override "EXECUTORCH_BUILD_KERNELS_CUSTOM" ;; --mps) set_cmake_options_override "EXECUTORCH_BUILD_MPS" ;; --optimized) set_cmake_options_override "EXECUTORCH_BUILD_KERNELS_OPTIMIZED" ;; - --portable) set_cmake_options_override "EXECUTORCH_BUILD_PORTABLE_OPS" ;; --quantized) set_cmake_options_override "EXECUTORCH_BUILD_KERNELS_QUANTIZED" ;; --xnnpack) set_cmake_options_override "EXECUTORCH_BUILD_XNNPACK" ;; *) @@ -240,7 +232,6 @@ for mode in "${MODES[@]}"; do append_framework_flag "EXECUTORCH_BUILD_XNNPACK" "$FRAMEWORK_BACKEND_XNNPACK" "$mode" append_framework_flag "EXECUTORCH_BUILD_KERNELS_CUSTOM" "$FRAMEWORK_KERNELS_CUSTOM" "$mode" append_framework_flag "EXECUTORCH_BUILD_KERNELS_OPTIMIZED" "$FRAMEWORK_KERNELS_OPTIMIZED" "$mode" - append_framework_flag "EXECUTORCH_BUILD_PORTABLE_OPS" "$FRAMEWORK_KERNELS_PORTABLE" "$mode" append_framework_flag "EXECUTORCH_BUILD_KERNELS_QUANTIZED" "$FRAMEWORK_KERNELS_QUANTIZED" "$mode" cd "${OUTPUT_DIR}" From 178d19f4fd67efb572e70a6368a7bb82c8a11193 Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Thu, 29 May 2025 12:49:32 -0700 Subject: [PATCH 2/7] Update apple.yml --- .github/workflows/apple.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/apple.yml b/.github/workflows/apple.yml index 9c164ff5085..dca3a43403c 100644 --- a/.github/workflows/apple.yml +++ b/.github/workflows/apple.yml @@ -154,7 +154,6 @@ jobs: "backend_xnnpack" "kernels_custom" "kernels_optimized" - "kernels_portable" "kernels_quantized" "threadpool" ) From 412ef2d34315f902285751123701aecb30fba332 Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Thu, 29 May 2025 12:50:25 -0700 Subject: [PATCH 3/7] Delete .Package.swift/kernels_portable directory --- .Package.swift/kernels_portable/dummy.swift | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .Package.swift/kernels_portable/dummy.swift diff --git a/.Package.swift/kernels_portable/dummy.swift b/.Package.swift/kernels_portable/dummy.swift deleted file mode 100644 index e69de29bb2d..00000000000 From 41055099dfcdc51774a296356b307b2a196be43d Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Thu, 29 May 2025 12:50:40 -0700 Subject: [PATCH 4/7] Delete .Package.swift/kernels_portable_debug directory --- .Package.swift/kernels_portable_debug/dummy.swift | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .Package.swift/kernels_portable_debug/dummy.swift diff --git a/.Package.swift/kernels_portable_debug/dummy.swift b/.Package.swift/kernels_portable_debug/dummy.swift deleted file mode 100644 index e69de29bb2d..00000000000 From aa4257d4521120d3b241bb3e6f0cbfa9abd12313 Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Thu, 29 May 2025 12:51:14 -0700 Subject: [PATCH 5/7] Update Package.swift --- Package.swift | 1 - 1 file changed, 1 deletion(-) diff --git a/Package.swift b/Package.swift index ff88045e1c3..e9c80cdd396 100644 --- a/Package.swift +++ b/Package.swift @@ -78,7 +78,6 @@ let products = deliverables([ "threadpool", ], ], - "kernels_portable": [:], "kernels_quantized": [:], ]) From 9557edff4573a0ee317a9b5779af325227a322d6 Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Thu, 29 May 2025 12:54:25 -0700 Subject: [PATCH 6/7] Update using-executorch-ios.md --- docs/source/using-executorch-ios.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/source/using-executorch-ios.md b/docs/source/using-executorch-ios.md index 7238a62af79..a978d4bae07 100644 --- a/docs/source/using-executorch-ios.md +++ b/docs/source/using-executorch-ios.md @@ -11,8 +11,7 @@ The ExecuTorch Runtime for iOS and macOS is distributed as a collection of prebu * `backend_mps` - MPS backend * `backend_xnnpack` - XNNPACK backend * `kernels_custom` - Custom kernels for LLMs -* `kernels_optimized` - Optimized kernels -* `kernels_portable` - Portable kernels (naive implementation used as a reference) +* `kernels_optimized` - Accelerated CPU kernels * `kernels_quantized` - Quantized kernels Link your binary with the ExecuTorch runtime and any backends or kernels used by the exported ML model. It is recommended to link the core runtime to the components that use ExecuTorch directly, and link kernels and backends against the main app target. @@ -66,7 +65,7 @@ let package = Package( dependencies: [ .product(name: "executorch", package: "executorch"), .product(name: "backend_xnnpack", package: "executorch"), - .product(name: "kernels_portable", package: "executorch"), + .product(name: "kernels_optimized", package: "executorch"), // Add other backends and kernels as needed. ]), ] From 51aa3e70b4bcd3faa0a37038988bf8b82205759b Mon Sep 17 00:00:00 2001 From: Anthony Shoumikhin Date: Thu, 29 May 2025 12:55:06 -0700 Subject: [PATCH 7/7] Update using-executorch-ios.md --- docs/source/using-executorch-ios.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/using-executorch-ios.md b/docs/source/using-executorch-ios.md index a978d4bae07..467227fc0ad 100644 --- a/docs/source/using-executorch-ios.md +++ b/docs/source/using-executorch-ios.md @@ -11,7 +11,7 @@ The ExecuTorch Runtime for iOS and macOS is distributed as a collection of prebu * `backend_mps` - MPS backend * `backend_xnnpack` - XNNPACK backend * `kernels_custom` - Custom kernels for LLMs -* `kernels_optimized` - Accelerated CPU kernels +* `kernels_optimized` - Accelerated generic CPU kernels * `kernels_quantized` - Quantized kernels Link your binary with the ExecuTorch runtime and any backends or kernels used by the exported ML model. It is recommended to link the core runtime to the components that use ExecuTorch directly, and link kernels and backends against the main app target.