Use safe_numerics util from PyTorch #11537

aaron-ang · 2025-06-10T20:38:21Z

Summary

We import safe_numerics.h from PyTorch and extend mul_overflows for size_t. Then, we apply it in calculate_nbytes to perform faster overflow checks.

Test plan

Use existing tests since we are doing a drop-in replacement for overflow checks.

pytorch-bot · 2025-06-10T20:38:24Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11537

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 17 New Failures

As of commit 73aacee with merge base 18e9149 ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
RuntimeError: Command docker exec -t 78f0333468a146fe48b01f1a81c6ce58ff3ae122077205d7f862e614eca65fff /exec failed with exit code 3
Build Presets / apple (ios-simulator) / build (gh)
/Users/runner/work/executorch/executorch/pytorch/executorch/runtime/executor/method_meta.cpp:70:19: error: no matching function for call to 'mul_overflows'
Build Presets / apple (ios) / build (gh)
/Users/runner/work/executorch/executorch/pytorch/executorch/runtime/executor/method_meta.cpp:70:19: error: no matching function for call to 'mul_overflows'
Build Presets / apple (llm) / build (gh)
/Users/runner/work/executorch/executorch/pytorch/executorch/runtime/executor/method_meta.cpp:70:19: error: no matching function for call to 'mul_overflows'
Build Presets / apple (macos) / build (gh)
/Users/runner/work/executorch/executorch/pytorch/executorch/runtime/executor/method_meta.cpp:70:19: error: no matching function for call to 'mul_overflows'
Build Presets / apple (pybind) / build (gh)
/Users/runner/work/executorch/executorch/pytorch/executorch/runtime/executor/method_meta.cpp:70:19: error: no matching function for call to 'mul_overflows'
check-c10-sync / check-c10-sync (gh)
Process completed with exit code 1.
pull / android / build-llm-demo / linux-job (gh)
RuntimeError: Command docker exec -t 17a36983052a56d2e7fa93695c9f7b3118ac6456b1ea0131b943c812b1ac8037 /exec failed with exit code 3
pull / test-binary-size-linux / linux-job (gh)
/pytorch/executorch/kernels/portable/cpu/util/normalization_ops_util.cpp:18:26: error: pragma diagnostic expected 'error', 'warning', 'ignored', 'fatal', 'push', or 'pop' [-Werror,-Wunknown-pragmas]
pull / test-models-linux-basic (mv3, portable, buck2, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh)
RuntimeError: Command docker exec -t 99db32f12787050e56c78a05d2b1979eb3feb90ef24be1f8b19d86c1fd993d70 /exec failed with exit code 3
pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh)
RuntimeError: Command docker exec -t 85bc09174b3ac378e44622874468058c29244817a353a5740931bf00bfd87c6a /exec failed with exit code 3
pull / test-models-linux-basic (vit, portable, buck2, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh)
RuntimeError: Command docker exec -t 0e5d3f94a67bb258edc63634ddaf674dcdad2b5f76fd90e98b57eb4cb3fc5bed /exec failed with exit code 3
pull / test-models-linux-basic (vit, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh)
RuntimeError: Command docker exec -t ce8568017d87a78cb4595acc00b242e3b5f7193349f73fc04210070dea72a3ce /exec failed with exit code 3
pull / unittest / macos / macos-job (gh)
/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/runtime/executor/method_meta.cpp:70:19: error: no matching function for call to 'mul_overflows'
pull / unittest-buck / linux / linux-job (gh)
RuntimeError: Command docker exec -t 64fdb4789502aad751ce21a4d78c1451852d34ffc7c5eb9d600a9307c8305649 /exec failed with exit code 3
pull / unittest-buck / macos / macos-job (gh)
/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/runtime/executor/method_meta.cpp:70:19: error: no matching function for call to 'mul_overflows'
pull / unittest-editable / macos / macos-job (gh)
/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/runtime/executor/method_meta.cpp:70:19: error: no matching function for call to 'mul_overflows'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

aaron-ang · 2025-06-10T20:41:49Z

@pytorchbot label "release notes: runtime"

runtime/core/portable_type/c10/c10/util/safe_numerics.h

JacobSzwejbka · 2025-06-11T18:39:33Z

kernels/portable/cpu/util/normalization_ops_util.cpp

 namespace executor {

+#ifdef __clang__
+#pragma clang diagnostic ignore "-Wvla-extension"


whys this needed?

I faced this error when compiling (./install_executorch.sh) with Clang on MacOS.

@aaron-ang can you paste the error?

@jathu My bad. I faced this error not when installing Executorch, but when running tests locally using sh test/build_size_test.sh as mentioned in https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#testing.

executorch/kernels/portable/cpu/util/normalization_ops_util.cpp:110:37: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension] 110 | executorch::aten::SizesType shape[ndim]; | ^~~~ executorch/kernels/portable/cpu/util/normalization_ops_util.cpp:110:37: note: read of non-const variable 'ndim' is not allowed in a constant expression executorch/kernels/portable/cpu/util/normalization_ops_util.cpp:88:10: note: declared here 88 | size_t ndim = normalized_shape.size(); | ^ 1 error generated. gmake[2]: *** [kernels/portable/cpu/util/CMakeFiles/kernels_util_all_deps.dir/build.make:219: kernels/portable/cpu/util/CMakeFiles/kernels_util_all_deps.dir/normalization_ops_util.cpp.o] Error 1 gmake[2]: *** Waiting for unfinished jobs.... gmake[1]: *** [CMakeFiles/Makefile2:750: kernels/portable/cpu/util/CMakeFiles/kernels_util_all_deps.dir/all] Error 2 gmake: *** [Makefile:136: all] Error 2

My syntax is also wrong: it should be ignored instead of ignore, but surprisingly compiles fine.

JacobSzwejbka · 2025-06-11T18:42:54Z

Oh on

check-c10-sync / check-c10-sync (pull_request)

We track that anything under c10 mirrors exactly (this is a temporary thing iiuc until we can introduce a hard dep on pytorch/pytorch directly). If you want you could try submitting this to pytorch/pytorch instead and then mirror the file from there, or you can just move this to any other util spot that looks reasonable in ET to dodge this issue, and then we will deal with upstreaming it later.

Moving it will also probably help with the c10 namespace issues you were having.

facebook-github-bot · 2025-07-01T00:58:16Z

This pull request has been merged in 3dda80e.

aaron-ang · 2025-07-01T01:02:02Z

hi @huydhn why is this issue closed? I need to update the code from PyTorch upstream. It is different from this branch.
Edit: I have incorporated the changes. Could you please reopen the PR?

huydhn · 2025-07-01T01:26:19Z

What! This makes no sense. I have no intention of closing this PR, as I didn't even know about this before you pointed it out. Something doesn't feel right

huydhn · 2025-07-01T01:32:25Z

And I couldn't reopen the PR, the option is grayed out :(

huydhn · 2025-07-01T01:32:56Z

While I'm checking, maybe it's easier to recreate this in a different PR

malfet · 2025-07-01T14:26:04Z

What! This makes no sense. I have no intention of closing this PR, as I didn't even know about this before you pointed it out. Something doesn't feel right

huydhn/pytorch@3dda80e claimes to fix this issue, therefore github closed it (issues and pulls are the same entities in GitHub parlance)

### Summary Reopening from #11537 Fixes #11370 ### Test plan Use existing tests since we are doing a drop-in replacement for overflow checks.

import safe_numerics from PyTorch

744792e

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2025

pytorch-bot bot added the release notes: runtime Changes related to the core runtime which loads the program methods, initializes delegates, and runs label Jun 10, 2025

aaron-ang marked this pull request as ready for review June 10, 2025 20:48

aaron-ang requested review from JacobSzwejbka, lucylq and swolchok as code owners June 10, 2025 20:48

JacobSzwejbka reviewed Jun 10, 2025

View reviewed changes

runtime/core/portable_type/c10/c10/util/safe_numerics.h Show resolved Hide resolved

aaron-ang added 2 commits June 10, 2025 20:22

extend overflow check for size_t

8183f9c

use mul_overflows util in calculate_nbytes

02a9c5e

aaron-ang force-pushed the safe-numerics branch from 105b619 to e6b6a03 Compare June 11, 2025 03:22

aaron-ang requested review from jathu, kirklandsign and larryliu0820 as code owners June 11, 2025 03:22

ignore vla clang compile error

73aacee

aaron-ang force-pushed the safe-numerics branch from e6b6a03 to 73aacee Compare June 11, 2025 07:33

aaron-ang requested a review from manuelcandales as a code owner June 11, 2025 07:33

JacobSzwejbka reviewed Jun 11, 2025

View reviewed changes

aaron-ang mentioned this pull request Jun 11, 2025

Overload mul_overflows for size_t pytorch/pytorch#155736

Closed

huydhn closed this in huydhn/pytorch@3dda80e Jul 1, 2025

facebook-github-bot added the Merged label Jul 1, 2025

aaron-ang mentioned this pull request Jul 1, 2025

Use safe_numerics util from PyTorch #12125

Merged

swolchok pushed a commit that referenced this pull request Jul 18, 2025

Use safe_numerics util from PyTorch (#12125)

15442af

### Summary Reopening from #11537 Fixes #11370 ### Test plan Use existing tests since we are doing a drop-in replacement for overflow checks.

Use safe_numerics util from PyTorch #11537

Use safe_numerics util from PyTorch #11537

Uh oh!

Conversation

aaron-ang commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

pytorch-bot bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11537

❌ 17 New Failures

Uh oh!

aaron-ang commented Jun 10, 2025

Uh oh!

Uh oh!

JacobSzwejbka Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

aaron-ang Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

jathu Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

aaron-ang Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jul 1, 2025

Uh oh!

aaron-ang commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huydhn commented Jul 1, 2025

Uh oh!

huydhn commented Jul 1, 2025

Uh oh!

huydhn commented Jul 1, 2025

Uh oh!

malfet commented Jul 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aaron-ang commented Jun 10, 2025 •

edited

Loading

pytorch-bot bot commented Jun 10, 2025 •

edited

Loading

aaron-ang Jun 11, 2025 •

edited

Loading

JacobSzwejbka commented Jun 11, 2025 •

edited

Loading

aaron-ang commented Jul 1, 2025 •

edited

Loading