-
Notifications
You must be signed in to change notification settings - Fork 742
braodcast in op_le #11568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/kimishpatel/190/base
Are you sure you want to change the base?
braodcast in op_le #11568
Conversation
Differential Revision: [D76456398](https://our.internmc.facebook.com/intern/diff/D76456398/) [ghstack-poisoned]
Differential Revision: [D76456398](https://our.internmc.facebook.com/intern/diff/D76456398/) ghstack-source-id: 289769544 Pull Request resolved: #11568
|
This pull request was exported from Phabricator. Differential Revision: D76456398 |
This PR needs a
|
manuelcandales
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add a check at the top of this op that the dim orders must be the same, because I don't think any of this support different dim orders. But this was a preexisting issue, so, won't hold you on that.
| printf("selected_optimized_path: %d\n", static_cast<int>(selected_optimized_path)); | ||
| if (selected_optimized_path == ElementwiseOptimizedPath::kTreatAs1d) { | ||
| // Resize for dynamic shape | ||
| auto error = resize_tensor(out, a.sizes()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is introducing the same bug you are fixing for op_mul in #11590
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
Differential Revision: D76456398