Skip to content

Arm backend: Adjust pooling input when not divisible by stride #11854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zingo merged 2 commits into from
Jun 24, 2025
Merged

Arm backend: Adjust pooling input when not divisible by stride #11854

zingo merged 2 commits into from
Jun 24, 2025

Conversation

@tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Jun 23, 2025 •
edited by pytorch-bot bot
Loading

  • Rename SizeAdjustConv2DPass to SizeAdjustInputPass
  • Add support for adjusting input size for pooling operators

Change-Id: I4e6ddfcc47a2bda31afb4a1c6ed4a2c7c3c0fe45

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@tom-arm
Arm backend: Adjust pooling input when not divisible by stride
e2bc405 
* Rename SizeAdjustConv2DPass to SizeAdjustInputPass
* Add support for adjusting input size for pooling operators

Change-Id: I4e6ddfcc47a2bda31afb4a1c6ed4a2c7c3c0fe45
@tom-arm tom-arm requested a review from digantdesai as a code owner June 23, 2025 15:35
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11854

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Unrelated Failures

As of commit 62bc1da with merge base 7ede6be (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2025
@tom-arm tom-arm added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jun 23, 2025
@github-actions
Copy link

github-actions bot commented Jun 23, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@zingo zingo merged commit 6f44a79 into pytorch:main Jun 24, 2025
188 of 194 checks passed
@tom-arm tom-arm deleted the adjust_pooling_input branch June 24, 2025 11:19
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@tom-arm @hinriksnaer
Arm backend: Adjust pooling input when not divisible by stride (pytor…
6ec7247 
…ch#11854)

* Rename SizeAdjustConv2DPass to SizeAdjustInputPass
* Add support for adjusting input size for pooling operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tom-arm @zingo @facebook-github-bot