Correct debug handle merging logic #12073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12073
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0733d17 with merge base f888bdf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77461675 |
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
GregoryComer
approved these changes
Jun 27, 2025
Summary: This update refines the merge_overlapping_debug_handles function to handle non-continuous debug handle tuples effectively. Previously, the function assumed that debug handle tuples were continuous. The new implementation: 1.Merges overlapping debug handles by taking the union of their elements, allowing for non-continuous tuples. 2.Selects the value for the merged key based on the debug handle with the highest last element. Reviewed By: GregoryComer, Gasoonjia Differential Revision: D77461675
Juntian777
force-pushed
the
export-D77461675
branch
from
e384b24 to
0733d17
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77461675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This update refines the merge_overlapping_debug_handles function to handle non-continuous debug handle tuples effectively. Previously, the function assumed that debug handle tuples were continuous. The new implementation:
1.Merges overlapping debug handles by taking the union of their elements, allowing for non-continuous tuples.
2.Selects the value for the merged key based on the debug handle with the highest last element.
Reviewed By: GregoryComer
Differential Revision: D77461675