Skip exp float16 test in XNNPACk #12097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12097
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 28 Pending, 1 Unrelated FailureAs of commit 2195fd8 with merge base db8ef6b ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mergennachin
added
the
release notes: none
mergennachin
changed the title
cccclai
approved these changes
Jun 28, 2025
Contributor
Author
|
@pytorchbot cherry-pick --onto release/0.7 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Jun 30, 2025
(cherry picked from commit 268806c)
Collaborator
Cherry picking #12097The cherry pick PR is at #12119 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
digantdesai
reviewed
Jul 2, 2025
|
|
||
| # TODO (leafs1): Fix flaky tests. Land fix asap | ||
| # and cherry-pick onto release/0.7 branch | ||
| @unittest.skip(reason="For float16, numerical discepancies are too high") |
Contributor
There was a problem hiding this comment.
@mcr229 should we increase atol/rtol for this, or normalize/range-select inputs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.