Skip to content

Refactor prepare_pt2, prepare_traced_pt2 #12761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ethansfng wants to merge 4 commits into from
Closed

Refactor prepare_pt2, prepare_traced_pt2 #12761

ethansfng wants to merge 4 commits into from

Conversation

@ethansfng
Copy link
Contributor

@ethansfng ethansfng commented Jul 23, 2025

Summary:
Refactor prepare_pt2 to wrap trace and prepare_traced_pt2
prepare_traced_pt2 will wrap prepare_pt2e and log outputs

Reviewed By: mcremon-meta

Differential Revision: D78762534

ethansfng added 2 commits July 23, 2025 13:31
@ethansfng @facebook-github-bot
move trace, prepare, convert into unified_compiler_utils, split prepa…
7692f33 
…re_and_convert into separate functions

Summary: trace, prepare, convert in OSS will wrap the unified utilities and log the outputs

Reviewed By: mcremon-meta

Differential Revision: D78751687
@ethansfng @facebook-github-bot
Refactor prepare_pt2, prepare_traced_pt2
2794831 
Summary:
Refactor prepare_pt2 to wrap trace and prepare_traced_pt2
prepare_traced_pt2 will wrap prepare_pt2e and log outputs

Reviewed By: mcremon-meta

Differential Revision: D78762534
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12761

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ca9780d with merge base 574e109 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 23, 2025

This pull request was exported from Phabricator. Differential Revision: D78762534

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign
Copy link
Contributor

kirklandsign commented Jul 31, 2025

Use #13006 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skrtskrtfb skrtskrtfb skrtskrtfb approved these changes

@kirklandsign kirklandsign kirklandsign approved these changes

@mcremon-meta mcremon-meta mcremon-meta approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ethansfng @facebook-github-bot @kirklandsign @skrtskrtfb @mcremon-meta @zonglinpeng