Arm backend: Decrease scratch buffer for Dedicated_Sram #12891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Dedicated_Sram, both ET_ARM_BAREMETAL_METHOD_ALLOCATOR_POOL and ET_ARM_BAREMETAL_SCRATCH_TEMP_ALLOCATOR_POOL shares the DDR memory area with the parameters of the network. The DDR is 256MiB, so if we allocate 60MiB + 128MiB for buffers, that only leaves 68Mib for the parameters, severely limiting the size of network we are able to run. Signed-off-by: Adrian Lundell <[email protected]> Change-Id: I616484273379337c5b9f41967bf0275f453907df
AdrianLundell
requested review from
kirklandsign and
larryliu0820
as code owners
AdrianLundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12891
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ad67d89 with merge base 1c72e0e ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Sebastian-Larsson
approved these changes
Jul 29, 2025
Collaborator
Sebastian-Larsson
left a comment
Sebastian-Larsson
left a comment
There was a problem hiding this comment.
Unrelated CI failure. Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Dedicated_Sram, both ET_ARM_BAREMETAL_METHOD_ALLOCATOR_POOL and ET_ARM_BAREMETAL_SCRATCH_TEMP_ALLOCATOR_POOL shares the DDR memory area with the parameters of the network.
The DDR is 256MiB, so if we allocate 60MiB + 128MiB for buffers, that only leaves 68Mib for the parameters, severely limiting the size of network we are able to run.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218