Fixed bug with ConstantPad2d accepting negative padding dimensions #12935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12935
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 57f4364 with merge base 0305ddc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
mcr229
reviewed
Jul 28, 2025
Comment on lines
594
to
595
| XNNPACK does not support negative padding values because the flatbuffer | ||
| schema expects unsigned integers for padding values. |
Contributor
There was a problem hiding this comment.
Suggested change
| XNNPACK does not support negative padding values because the flatbuffer | |
| schema expects unsigned integers for padding values. | |
| XNNPACK does not support cropping with negative padding sizes. |
mcr229
approved these changes
Jul 28, 2025
digantdesai
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a negative dimension is used with ConstantPad2d(), the export fails. This functionality isn't supported by XNNPACK, so this pr changes the node partitioner config such that negative dimension ConstantPadConfig nodes aren't partitioned. The issue is further detailed below #12456.
Test plan
Added a new test class replicating the error in the github issue with negative padding dimension.