Skip to content

Conversation

@metascroy
Copy link
Contributor

Add support for dim_order op in CoreML.

Currently, the dim_order op is skipped. This occasionally leads to lowering / runtime errors, so often you have a better experience by setting _skip_dim_order=True.

This will fix the CI failure in trunk / test-models-macos-coreml (emformer_transcribe) / macos-job

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12985

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f56fcd7 with merge base 574e109 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@metascroy metascroy requested a review from YifanShenSZ July 29, 2025 23:08
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy metascroy merged commit 23e1692 into main Jul 30, 2025
222 of 223 checks passed
@metascroy metascroy deleted the support-dim-order-in-coreml branch July 30, 2025 16:28
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Add support for dim_order op in CoreML.

Currently, the dim_order op is skipped. This occasionally leads to
lowering / runtime errors, so often you have a better experience by
setting _skip_dim_order=True.

This will fix the CI failure in trunk / test-models-macos-coreml
(emformer_transcribe) / macos-job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants