enable qat for custom annotation in qnn #13147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13147
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 3382809 with merge base afdbb85 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79705374 |
cccclai
requested review from
DannyYuyang-quic,
haowhsu-quic,
shewu-quic and
winskuo-quic
shewu-quic
approved these changes
Aug 7, 2025
Collaborator
shewu-quic
left a comment
shewu-quic
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the efforts.
Contributor
|
@navsud can you fix the lint? |
Summary: This diff enables QAT for `annotate_matmul_16a8w` custom annotation. After this change, verified that the prepared graph shows FakeQuants (QAT) instead of Observers (PTQ). Differential Revision: D79705374
navsud
force-pushed
the
export-D79705374
branch
from
2ed6d28 to
3382809
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79705374 |
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Differential Revision: D79705374 Pull Request resolved: pytorch#13147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff enables QAT for
annotate_matmul_16a8wcustom annotation. After this change, verified that the prepared graph shows FakeQuants (QAT) instead of Observers (PTQ).Differential Revision: D79705374