Skip to content

Conversation

@shewu-quic
Copy link
Collaborator

Summary:

  • Update calibration flow to enhance the speed of wikitext calibration

cc: @haowhsu-quic , @winskuo-quic

@shewu-quic shewu-quic requested a review from cccclai as a code owner August 6, 2025 07:07
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13150

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit c7700e6 with merge base c8a0706 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 6, 2025
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shewu-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR is to enhance the speed of calibration with wikitext, AR-N chunk by AR-N chunk instead of original token by token.
Could you please help take a look?
Thanks

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D79958818.

@cccclai
Copy link
Contributor

cccclai commented Aug 10, 2025

There seem to be merge conflict. Also, does the flow break evaluate_qnn_llama?

Summary:
- Update calibration flow to enhance the speed of wikitext calibration
@shewu-quic shewu-quic force-pushed the dev1/hutton/refactor_calibration branch from 829bcbc to c7700e6 Compare August 11, 2025 05:56
@shewu-quic
Copy link
Collaborator Author

There seem to be merge conflict. Also, does the flow break evaluate_qnn_llama?

Done, thanks. No, it should be speed up the evaluation for AR-N model. But for AR-1 (kv mode) should be the same.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D79958818.

@cccclai cccclai merged commit 18030f9 into pytorch:main Aug 11, 2025
101 of 103 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Summary:
- Update calibration flow to enhance the speed of wikitext calibration

cc: @haowhsu-quic , @winskuo-quic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants