Fix error handling macros to work well with MSVC. #13214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoumikhin
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13214
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 87 PendingAs of commit 8d97a16 with merge base c8c6628 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79865456 |
This PR needs a
|
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
force-pushed
the
export-D79865456
branch
from
4c0a5c8 to
bcaaab2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79865456 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
force-pushed
the
export-D79865456
branch
from
bcaaab2 to
44d9f8a
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
force-pushed
the
export-D79865456
branch
from
44d9f8a to
d0c0600
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79865456 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79865456 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
force-pushed
the
export-D79865456
branch
from
d0c0600 to
e70c27c
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13214 Differential Revision: D79865456
shoumikhin
force-pushed
the
export-D79865456
branch
from
e70c27c to
58c50bb
Compare
JacobSzwejbka
approved these changes
Aug 8, 2025
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
force-pushed
the
export-D79865456
branch
from
58c50bb to
8041b55
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79865456 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
force-pushed
the
export-D79865456
branch
from
8041b55 to
8d97a16
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79865456 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Differential Revision: D79865456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D79865456