Set inputs directly in Module. #13228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoumikhin
requested review from
JacobSzwejbka,
digantdesai,
lucylq,
mcr229 and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13228
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79900450 |
shoumikhin
added
ciflow/trunk
release notes: none
shoumikhin
force-pushed
the
export-D79900450
branch
from
94734a6 to
3eaf3a5
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: . Differential Revision: D79900450
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79900450 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13228 . Differential Revision: D79900450
shoumikhin
force-pushed
the
export-D79900450
branch
from
3eaf3a5 to
676fddb
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: . Reviewed By: bsoyluoglu Differential Revision: D79900450
shoumikhin
force-pushed
the
export-D79900450
branch
from
676fddb to
e8bc0a6
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: . Reviewed By: bsoyluoglu Differential Revision: D79900450
shoumikhin
force-pushed
the
export-D79900450
branch
from
e8bc0a6 to
dc60bc8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79900450 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79900450 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13228 . Reviewed By: bsoyluoglu Differential Revision: D79900450
shoumikhin
force-pushed
the
export-D79900450
branch
from
dc60bc8 to
28778ea
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: . Reviewed By: bsoyluoglu Differential Revision: D79900450
shoumikhin
force-pushed
the
export-D79900450
branch
2 times, most recently
from
d1d6a7e to
198579f
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: . Reviewed By: bsoyluoglu Differential Revision: D79900450
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79900450 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79900450 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Pull Request resolved: pytorch#13228 . Reviewed By: bsoyluoglu Differential Revision: D79900450
shoumikhin
force-pushed
the
export-D79900450
branch
from
198579f to
3261bc6
Compare
larryliu0820
approved these changes
Aug 10, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79900450 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 10, 2025
Summary: Pull Request resolved: pytorch#13228 . Reviewed By: bsoyluoglu Differential Revision: D79900450
shoumikhin
force-pushed
the
export-D79900450
branch
from
434a975 to
3480372
Compare
Summary: . Reviewed By: bsoyluoglu Differential Revision: D79900450
shoumikhin
force-pushed
the
export-D79900450
branch
from
3480372 to
1917f4e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79900450 |
digantdesai
reviewed
Aug 12, 2025
| return nil; | ||
| } | ||
| const auto result = _module->execute(methodName.UTF8String, inputs); | ||
| const auto result = _module->execute(methodNameString); |
Contributor
There was a problem hiding this comment.
For my understanding, I can still call execute again right after this without set_input again right? I.e. the input_set state doesn't get reset after each execute, right?
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Summary: . Differential Revision: D79900450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: .
Differential Revision: D79900450