-
Notifications
You must be signed in to change notification settings - Fork 646
[Backend Tester] Add subtest index field #13311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/GregoryComer/120/head
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13311
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New Failures, 2 Unrelated FailuresAs of commit 88d1dd3 with merge base d7ecd87 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -119,6 +119,7 @@ def run_model_test( | |||
flow, | |||
context.test_name, | |||
context.test_base_name, | |||
0, # subtest_index - currently unused for model tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the hierarchy is
Test ID -> test -> subtest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming is a bit confusing. I'm open to suggestions. The test_base_name is the test name (test_add_dtype, for example). Test name adds flow and parameterization (test_add_dtype_float32_xnnpack). The subtest index corresponds to a single python unittest function that runs multiple test cases.
Some test functions run multiple test cases. Add a subtest index field to disambiguate these in the report.