Skip to content

Conversation

@roman-janik-nxp
Copy link
Collaborator

Summary

Remove unnecessary optimization in keep_one_empty_buffer.py in IR optimizer.

Test plan

All tests where a subgraph is delegated to Neutron.

cc @digantdesai @JakeStevens @robert-kalmar @Pop-Korn

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13376

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Unrelated Failures

As of commit bbd31f6 with merge base ea4a7fa (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2025
@roman-janik-nxp
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Aug 13, 2025
@MartinPavella
Copy link
Collaborator

LGTM

@robert-kalmar
Copy link
Collaborator

Please fix the failures.

@robert-kalmar robert-kalmar marked this pull request as draft August 29, 2025 11:35
@robert-kalmar
Copy link
Collaborator

Moving to draft stage, as this is not really an optimization, but a postprocessing phase to generate a valid tflite model representation. This pass must stay, but perhaps to be moved outside of the backends/nxp/backend/ir/tflite_optimizer/optimizations package

@roman-janik-nxp
Copy link
Collaborator Author

Closing now as this code needs to be moved instead of removed. New PR will be created.

@robert-kalmar robert-kalmar deleted the feature/nxg11066/EIEX-477-remove-optimization-in-keep_one_empty_buffer.py branch August 29, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants