Remove outdated NCHW to NHWC pass and rename the current one to ReplaceConvWithChannelLastConvPass #13420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13420
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 791a4e2 with merge base 5ff0208 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80185231 |
This PR needs a
|
ethansfng
approved these changes
Aug 14, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
…ceConvWithChannelLastConvPass (#13420) Summary: The existing `ReplaceConvWithChannelLastConvPass` is a PT1 pass from years past, and currently does not do anything. The correct version of it is `ForceChannelLastForConvPass`, so we rename that one to `ReplaceConvWithChannelLastConvPass`. This should be a non-functional change. Reviewed By: ethansfng, hsharma35 Differential Revision: D80185231
facebook-github-bot
force-pushed
the
export-D80185231
branch
from
6ff2e29 to
91302fc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80185231 |
mcremon-meta
force-pushed
the
export-D80185231
branch
from
91302fc to
560b7a5
Compare
mcremon-meta
added a commit
that referenced
this pull request
Aug 14, 2025
…ceConvWithChannelLastConvPass (#13420) Summary: The existing `ReplaceConvWithChannelLastConvPass` is a PT1 pass from years past, and currently does not do anything. The correct version of it is `ForceChannelLastForConvPass`, so we rename that one to `ReplaceConvWithChannelLastConvPass`. This should be a non-functional change. Reviewed By: ethansfng, hsharma35 Differential Revision: D80185231
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80185231 |
mcremon-meta
added a commit
that referenced
this pull request
Aug 14, 2025
…ceConvWithChannelLastConvPass (#13420) Summary: Pull Request resolved: #13420 The existing `ReplaceConvWithChannelLastConvPass` is a PT1 pass from years past, and currently does not do anything. The correct version of it is `ForceChannelLastForConvPass`, so we rename that one to `ReplaceConvWithChannelLastConvPass`. This should be a non-functional change. Reviewed By: ethansfng, hsharma35 Differential Revision: D80185231
mcremon-meta
force-pushed
the
export-D80185231
branch
from
560b7a5 to
4672e46
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 16, 2025
…ceConvWithChannelLastConvPass (#13420) Summary: The existing `ReplaceConvWithChannelLastConvPass` is a PT1 pass from years past, and currently does not do anything. The correct version of it is `ForceChannelLastForConvPass`, so we rename that one to `ReplaceConvWithChannelLastConvPass`. This should be a non-functional change. Reviewed By: ethansfng, hsharma35 Differential Revision: D80185231
facebook-github-bot
force-pushed
the
export-D80185231
branch
from
4672e46 to
a027188
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80185231 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 16, 2025
…ceConvWithChannelLastConvPass (#13420) Summary: The existing `ReplaceConvWithChannelLastConvPass` is a PT1 pass from years past, and currently does not do anything. The correct version of it is `ForceChannelLastForConvPass`, so we rename that one to `ReplaceConvWithChannelLastConvPass`. This should be a non-functional change. Reviewed By: ethansfng, hsharma35 Differential Revision: D80185231
facebook-github-bot
force-pushed
the
export-D80185231
branch
from
a027188 to
1c999e6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80185231 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 17, 2025
…ceConvWithChannelLastConvPass (#13420) Summary: The existing `ReplaceConvWithChannelLastConvPass` is a PT1 pass from years past, and currently does not do anything. The correct version of it is `ForceChannelLastForConvPass`, so we rename that one to `ReplaceConvWithChannelLastConvPass`. This should be a non-functional change. Reviewed By: ethansfng, hsharma35 Differential Revision: D80185231
facebook-github-bot
force-pushed
the
export-D80185231
branch
from
1c999e6 to
79e9731
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80185231 |
…ceConvWithChannelLastConvPass (#13420) Summary: The existing `ReplaceConvWithChannelLastConvPass` is a PT1 pass from years past, and currently does not do anything. The correct version of it is `ForceChannelLastForConvPass`, so we rename that one to `ReplaceConvWithChannelLastConvPass`. This should be a non-functional change. Reviewed By: ethansfng, hsharma35 Differential Revision: D80185231
facebook-github-bot
force-pushed
the
export-D80185231
branch
from
79e9731 to
791a4e2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80185231 |
zonglinpeng
approved these changes
Aug 18, 2025
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…ceConvWithChannelLastConvPass Differential Revision: D80185231 Pull Request resolved: pytorch#13420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The existing
ReplaceConvWithChannelLastConvPassis a PT1 pass from years past, and currently does not do anything. The correct version of it isForceChannelLastForConvPass, so we rename that one toReplaceConvWithChannelLastConvPass.This should be a non-functional change.
Differential Revision: D80185231