Make IOManager use Module instead of Method. #13542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoumikhin
requested review from
jackzhxng,
larryliu0820,
mergennachin and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13542
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 5 PendingAs of commit 2663ae3 with merge base 3db27cd ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80595261 |
This PR needs a
|
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 20, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 20, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
shoumikhin
force-pushed
the
export-D80595261
branch
from
d1fb951 to
2598bf1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80595261 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 20, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
mergennachin
requested changes
Aug 20, 2025
Contributor
|
Also fix the unit test in executorch/extension/llm/runner/test:test_text_decoder_runner |
shoumikhin
force-pushed
the
export-D80595261
branch
from
9d877cb to
bd1bb97
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 21, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80595261 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 21, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
shoumikhin
force-pushed
the
export-D80595261
branch
from
bd1bb97 to
c3ada55
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 21, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
shoumikhin
force-pushed
the
export-D80595261
branch
from
c3ada55 to
7c90136
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80595261 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80595261 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 21, 2025
Summary: Pull Request resolved: pytorch#13542 Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
shoumikhin
force-pushed
the
export-D80595261
branch
from
7c90136 to
d240049
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 22, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
shoumikhin
force-pushed
the
export-D80595261
branch
from
d240049 to
bebda13
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80595261 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 22, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 22, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
mergennachin
approved these changes
Aug 22, 2025
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 22, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Reviewed By: mergennachin Differential Revision: D80595261
shoumikhin
force-pushed
the
export-D80595261
branch
from
bebda13 to
ea84efd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80595261 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 22, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Reviewed By: mergennachin Differential Revision: D80595261
shoumikhin
force-pushed
the
export-D80595261
branch
from
ea84efd to
963458a
Compare
Summary: Pull Request resolved: pytorch#13542 Let's not expose Method from Module so that it's not getting misused beyond its owner. Reviewed By: mergennachin Differential Revision: D80595261
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80595261 |
shoumikhin
force-pushed
the
export-D80595261
branch
from
963458a to
2663ae3
Compare
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
kimishpatel
pushed a commit
that referenced
this pull request
Sep 2, 2025
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner. Differential Revision: D80595261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Let's not expose Method from Module so that it's not getting misused beyond its owner.
Differential Revision: D80595261