Allow zero-element inputs for method. #13623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 3 commits into pytorch:main from hsharma35:export-D80881025

Aug 26, 2025

Contributor

hsharma35 commented Aug 23, 2025

Summary: Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 requested review from JacobSzwejbka, lucylq and swolchok as code owners

August 23, 2025 17:07

pytorch-bot bot commented Aug 23, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13623

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit ab14a9b with merge base d5fb6aa ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 5
pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (gh)
RuntimeError: Command docker exec -t ea31a0c35bc57fe1dbb50b9c7a0124195d199fc5951fdf3bbffdfdf1b9bf8b35 /exec failed with exit code 1

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest-editable / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Aug 23, 2025

This pull request was exported from Phabricator. Differential Revision: D80881025

facebook-github-bot added the fb-exported label

hsharma35 added the release notes: none label

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

0a8a46a

Summary:

Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from 6714f83 to 0a8a46a Compare

August 23, 2025 17:51

Contributor

facebook-github-bot commented Aug 23, 2025

This pull request was exported from Phabricator. Differential Revision: D80881025

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

e68bff4

Summary:

Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from 0a8a46a to e68bff4 Compare

August 23, 2025 20:44

Contributor

facebook-github-bot commented Aug 23, 2025

This pull request was exported from Phabricator. Differential Revision: D80881025

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

72b7687

Summary:
Pull Request resolved: pytorch#13623

Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from e68bff4 to 72b7687 Compare

August 23, 2025 20:47

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

8abbf21

Summary:

Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from 72b7687 to 8abbf21 Compare

August 24, 2025 05:43

Contributor

facebook-github-bot commented Aug 24, 2025

This pull request was exported from Phabricator. Differential Revision: D80881025

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

177fac8

Summary:
Pull Request resolved: pytorch#13623

Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from 8abbf21 to 177fac8 Compare

August 24, 2025 05:47

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

66b1549

Summary:

Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from 177fac8 to 66b1549 Compare

August 24, 2025 05:52

Contributor

facebook-github-bot commented Aug 24, 2025

This pull request was exported from Phabricator. Differential Revision: D80881025

JacobSzwejbka approved these changes

View reviewed changes

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

2a2be15

Summary:

Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from 66b1549 to 2a2be15 Compare

August 25, 2025 02:56

hsharma35 requested a review from manuelcandales as a code owner

August 25, 2025 02:56

Contributor

facebook-github-bot commented Aug 25, 2025

This pull request was exported from Phabricator. Differential Revision: D80881025

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

7508eb8

Summary:
Pull Request resolved: pytorch#13623

Adds support for the case where method inputs are zero-element.

Differential Revision: D80881025

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

4319a90

Summary:

Adds support for the case where method inputs are zero-element.

Reviewed By: zonglinpeng

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from 481fae6 to 4319a90 Compare

August 26, 2025 01:57

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80881025

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element inputs for method. (pytorch#13623)

d055491

Summary:
Pull Request resolved: pytorch#13623

Adds support for the case where method inputs are zero-element.

Reviewed By: zonglinpeng

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from 4319a90 to d055491 Compare

August 26, 2025 02:01

hsharma35 added 3 commits

August 25, 2025 21:19


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

3ea9de6

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791


          Fix bad optimized kernel for add. (pytorch#13633)

e5be2c8

Summary:

Fixes ths case where optimized 1D version would throw an error when rank b > rank a.

Reviewed By: manuelcandales

Differential Revision: D80914321


          Allow zero-element inputs for method. (pytorch#13623)

ab14a9b

Summary:

Adds support for the case where method inputs are zero-element.

Reviewed By: zonglinpeng

Differential Revision: D80881025

hsharma35 force-pushed the export-D80881025 branch from d055491 to ab14a9b Compare

August 26, 2025 04:20

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80881025

facebook-github-bot merged commit 62f8a8e into pytorch:main

105 of 111 checks passed

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          Allow zero-element inputs for method.

e1cd63e

Differential Revision: D80881025

Pull Request resolved: pytorch#13623

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs.

0b9769c

Summary: Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Differential Revision: D81653487

hsharma35 mentioned this pull request

Allow zero-element tensors for shared inputs. #13935

Merged

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

7755d5f

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

8bf98b1

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

65dc648

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

9277f47

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

5b4e763

Summary:
Pull Request resolved: pytorch#13935

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

c4c30f2

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

e63dc24

Summary:
Pull Request resolved: pytorch#13935

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

727da86

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

c576518

Summary:
Pull Request resolved: pytorch#13935

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

7d4ee4b

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

9c00336

Summary:
Pull Request resolved: pytorch#13935

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

9a88d56

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

e8a0ada

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

204f89e

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

0db3b22

Summary:
Pull Request resolved: pytorch#13935

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow zero-element tensors for shared inputs. (pytorch#13935)

878bcba

Summary:

Adds support for the case where method inputs are zero-element. Similar to pytorch#13623, but adds support for shared input instead.

Reviewed By: JacobSzwejbka, DrJessop

Differential Revision: D81653487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JacobSzwejbka JacobSzwejbka approved these changes

zonglinpeng zonglinpeng approved these changes

lucylq Awaiting requested review from lucylq lucylq is a code owner

swolchok Awaiting requested review from swolchok

manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

Labels

CLA Signed fb-exported release notes: none