Make token and stat callback optional in multimodal runner #13664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
jackzhxng
requested review from
larryliu0820,
mergennachin and
swolchok
as code owners
This was referenced Aug 25, 2025
Merged
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13664
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e087e29 with merge base 99e6349 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
[ghstack-poisoned]
mergennachin
approved these changes
Aug 26, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
jackzhxng
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
jackzhxng
added a commit
that referenced
this pull request
Sep 3, 2025
…ultimodal runner" (Messed up the merge for the original stack, this is reland. Original PR with comments here - #13664) Differential Revision: [D81498751](https://our.internmc.facebook.com/intern/diff/D81498751) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Sep 3, 2025
(Messed up the merge for the original stack, this is reland. Original PR with comments here - #13664) Differential Revision: [D81498751](https://our.internmc.facebook.com/intern/diff/D81498751) [ghstack-poisoned]
|
We still want this one first? |
jackzhxng
added a commit
that referenced
this pull request
Sep 4, 2025
…ultimodal runner" (Messed up the merge for the original stack, this is reland. Original PR with comments here - #13664) Differential Revision: [D81498751](https://our.internmc.facebook.com/intern/diff/D81498751) [ghstack-poisoned]
jackzhxng
added a commit
that referenced
this pull request
Sep 4, 2025
(Messed up the merge for the original stack, this is reland. Original PR with comments here - #13664) Differential Revision: [D81498751](https://our.internmc.facebook.com/intern/diff/D81498751) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):