Skip to content

Qualcomm AI Engine Direct - Fixed build error for llama runner on Mac #13838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

Qualcomm AI Engine Direct - Fixed build error for llama runner on Mac #13838

merged 1 commit into from
Sep 2, 2025
+3 −1

Conversation

@shewu-quic
Copy link
Collaborator

As title. It appears that $ORIGIN doesn't exist as an environment variable on Mac.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13838

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Cancelled Job, 4 Unrelated Failures

As of commit f4f22ff with merge base 1520f9f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 1, 2025
@shewu-quic shewu-quic mentioned this pull request Sep 1, 2025
Merged
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shewu-quic
Copy link
Collaborator Author

Hi @cccclai,

This PR is to resolve the bug that occurred when building on Mac after the enable qwen PR.
Could you please help to take a look?

@shoumikhin
Copy link
Contributor

@shewu-quic thanks for the fix!
Pleach check if any of the failures here could be related to this change:
https://hud.pytorch.org/pr/pytorch/executorch/13838#49352417880

@shewu-quic
Copy link
Collaborator Author

@shewu-quic thanks for the fix! Pleach check if any of the failures here could be related to this change: https://hud.pytorch.org/pr/pytorch/executorch/13838#49352417880

I have checked, and I don't think any of the failures are related to my change.

@shoumikhin shoumikhin merged commit 27a08fe into pytorch:main Sep 2, 2025
255 of 264 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shewu-quic @shoumikhin @cccclai