NXP backend: Fix shared quantization bugs. #13844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13844
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Cancelled JobAs of commit 30316cd with merge base 2a06efb ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "module: nxp" "release notes: nxp" |
pytorch-bot
bot
added
module: nxp
MartinPavella
force-pushed
the
upstream/main-nxp/EIEX-518-upstream-fixed-shared-quantization-bugs
branch
from
ed65598 to
17a6004
Compare
roman-janik-nxp
approved these changes
Sep 8, 2025
robert-kalmar
force-pushed
the
upstream/main-nxp/EIEX-518-upstream-fixed-shared-quantization-bugs
branch
from
17a6004 to
30316cd
Compare
robert-kalmar
approved these changes
Sep 10, 2025
Collaborator
robert-kalmar
left a comment
robert-kalmar
left a comment
There was a problem hiding this comment.
The failures are unrelated to this PR.
robert-kalmar
deleted the
upstream/main-nxp/EIEX-518-upstream-fixed-shared-quantization-bugs
branch
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
### Summary Fix 2 bugs related to quantization parameters that are shared between multiple tensors/nodes: - Turn off bias tensor reuse in Convolution converter - Fix _has_shared_q_params_if_quantized in Node converter ### Test plan No direct unit tests are provided. Correct functionality is tested by all tests with quantized nodes. --- Co-authored-by: Roman Janik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix 2 bugs related to quantization parameters that are shared between multiple tensors/nodes:
Test plan
No direct unit tests are provided. Correct functionality is tested by all tests with quantized nodes.
cc @robert-kalmar @roman-janik-nxp @StrycekSimon @jirioc