Skip to content

Conversation

@metascroy
Copy link
Contributor

Summary:
This deletes the SDPA/matmul kernels in torchao/experimental.

These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands.

Differential Revision: D81640227

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13924

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit b87901a with merge base 79744f0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81640227

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D81640227.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D81640227.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D81640227.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D81640227.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D81640227.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D81640227.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D81640227.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D81640227.

metascroy added a commit to metascroy/ao that referenced this pull request Sep 6, 2025
Summary:
This deletes the SDPA/matmul kernels in torchao/experimental.

These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands.

X-link: pytorch/executorch#13924

Reviewed By: kimishpatel

Differential Revision: D81640227

Pulled By: metascroy
metascroy added a commit to metascroy/executorch that referenced this pull request Sep 6, 2025
Summary:
X-link: pytorch/ao#2952


This deletes the SDPA/matmul kernels in torchao/experimental.

These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands.


Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Rollback Plan:

Reviewed By: kimishpatel

Differential Revision: D81640227

Pulled By: metascroy
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81640227

metascroy added a commit to metascroy/ao that referenced this pull request Sep 6, 2025
Summary:


This deletes the SDPA/matmul kernels in torchao/experimental.

These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands.

X-link: pytorch/executorch#13924

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Rollback Plan:

Reviewed By: kimishpatel

Differential Revision: D81640227

Pulled By: metascroy
metascroy added a commit to metascroy/ao that referenced this pull request Sep 6, 2025
Summary:
Pull Request resolved: pytorch#2952

This deletes the SDPA/matmul kernels in torchao/experimental.

These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands.

X-link: pytorch/executorch#13924

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Rollback Plan:

Reviewed By: kimishpatel

Differential Revision: D81640227

Pulled By: metascroy
Summary:
X-link: pytorch/ao#2952

This deletes the SDPA/matmul kernels in torchao/experimental.

These kernels were already migrated to torchao/csrc/cpu/torch_free_kernels in the first diff, but we needed to keep them around in torchao/experimental to do a pin bump in ExecuTorch OSS after the first diff lands.

Pull Request resolved: pytorch#13924

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

Rollback Plan:

Reviewed By: kimishpatel

Differential Revision: D81640227

Pulled By: metascroy
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81640227

@facebook-github-bot facebook-github-bot merged commit 1a7441f into pytorch:main Sep 6, 2025
115 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants