Skip to content

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Sep 6, 2025

This adds 35-40 new tests (because we weren't running before).

No additional net new ignores

Allow based on top level directories that way new tests are enabled automatically.

Explicitly ignore individual failing tests.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14037

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit bb2bfed with merge base 2845fd3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2025
@github-actions
Copy link

github-actions bot commented Sep 6, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin force-pushed the enable_tests branch 2 times, most recently from 11319df to e756835 Compare September 6, 2025 16:58
@mergennachin mergennachin force-pushed the enable_tests branch 3 times, most recently from afcd60e to a1f617d Compare September 7, 2025 23:36
@mergennachin mergennachin marked this pull request as ready for review September 7, 2025 23:54
@mergennachin mergennachin force-pushed the enable_tests branch 2 times, most recently from c79db9b to 187b501 Compare September 8, 2025 01:36
@mergennachin mergennachin merged commit 0eb4361 into main Sep 8, 2025
197 of 199 checks passed
@mergennachin mergennachin deleted the enable_tests branch September 8, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants