Skip to content

Conversation

@YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Sep 9, 2025

  • Add InsertInt32CastsAfterInt64PlaceholdersPass to insert an int64->int32 cast node after each int64 placeholder.
  • Deprecate the use of InsertCastForOpsWithInt64InputPass and in favor of InsertInt32CastsAfterInt64PlaceholdersPass; replace its usage

Change-Id: Ic092f57b56d1bab0e82205e5dd129c49e50862c0

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Add InsertInt32CastsAfterInt64PlaceholdersPass to insert an
  int64->int32 cast node after each int64 placeholder.
- Deprecate the use of InsertCastForOpsWithInt64InputPass and in favor
  of InsertInt32CastsAfterInt64PlaceholdersPass; replace its usage

Change-Id: Ic092f57b56d1bab0e82205e5dd129c49e50862c0
Signed-off-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu requested a review from zingo September 9, 2025 16:33
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Sep 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14118

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit eeeb6fd with merge base 8973eeb (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@zingo
Copy link
Collaborator

zingo commented Sep 10, 2025

MacOs fails are unrelated

@zingo zingo merged commit fbdee8f into pytorch:main Sep 10, 2025
447 of 451 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants