Skip to content

Extend data file support for other pybindings #14131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LeeOHzzZ wants to merge 1 commit into from
Closed

Extend data file support for other pybindings #14131

LeeOHzzZ wants to merge 1 commit into from

Conversation

@LeeOHzzZ
Copy link
Contributor

@LeeOHzzZ LeeOHzzZ commented Sep 9, 2025 •
edited
Loading

Summary:
This diff extends the support for external data_file to other executorch runtime pybindings.

Differential Revision: D82046648

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14131

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 62af5c0 with merge base cb42db2 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 9, 2025

This pull request was exported from Phabricator. Differential Revision: D82046648

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin requested a review from lucylq September 10, 2025 13:11
LeeOHzzZ pushed a commit to LeeOHzzZ/executorch that referenced this pull request Sep 10, 2025
@facebook-github-bot
Extend data file support for other pybindings (pytorch#14131)
ecba78e 
Summary:

This diff extends the support for external data_file to other executorch runtime pybindings.

Differential Revision: D82046648
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 10, 2025

This pull request was exported from Phabricator. Differential Revision: D82046648

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 17, 2025

@LeeOHzzZ has exported this pull request. If you are a Meta employee, you can view the originating diff in D82046648.

LeeOHzzZ pushed a commit to LeeOHzzZ/executorch that referenced this pull request Sep 17, 2025
@lucylq @facebook-github-bot
Extend data file support for other pybindings (pytorch#14131)
f687285 
Summary:

This diff extends the support for external data_file to other executorch runtime pybindings.

Differential Revision: D82046648
@lucylq @facebook-github-bot
Extend data file support for other pybindings (pytorch#14131)
62af5c0 
Summary:

This diff extends the support for external data_file to other executorch runtime pybindings.

Differential Revision: D82046648
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 17, 2025

@LeeOHzzZ has exported this pull request. If you are a Meta employee, you can view the originating diff in D82046648.

@lucylq
Copy link
Contributor

lucylq commented Sep 18, 2025

Creating new PR after commandeering diff.

@lucylq lucylq closed this Sep 18, 2025
@lucylq lucylq reopened this Sep 18, 2025
@lucylq lucylq closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@lucylq lucylq Awaiting requested review from lucylq

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeeOHzzZ @facebook-github-bot @lucylq