From f68d4ffed9ab15401823c18ed5e005e50f43cccb Mon Sep 17 00:00:00 2001
From: lucylq <lfq@meta.com>
Date: Wed, 10 Sep 2025 10:06:00 -0700
Subject: [PATCH 1/2] Deprecate debug buffer in Module

It's in release 0.7 so can't remove it, following deprecation schedule.

debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty.

Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case.

Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/)

[ghstack-poisoned]
---
 extension/module/module.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/extension/module/module.h b/extension/module/module.h
index 963d82d9d89..970c3f9f1ea 100644
--- a/extension/module/module.h
+++ b/extension/module/module.h
@@ -598,8 +598,7 @@ class Module {
     return event_tracer_.get();
   }
 
-  ET_NODISCARD
-  runtime::Span<uint8_t> debug_buffer() {
+  ET_DEPRECATED ET_NODISCARD runtime::Span<uint8_t> debug_buffer() {
     return runtime::Span<uint8_t>(debug_buffer_.data(), debug_buffer_.size());
   }
 
@@ -622,7 +621,7 @@ class Module {
   std::unique_ptr<runtime::EventTracer> event_tracer_;
   std::unique_ptr<runtime::DataLoader> data_map_loader_;
   std::unique_ptr<NamedDataMap> data_map_;
-  std::vector<uint8_t> debug_buffer_;
+  ET_DEPRECATED std::vector<uint8_t> debug_buffer_;
 
  protected:
   std::unordered_map<std::string, MethodHolder> methods_;

From 942306a6c4843dee91810b95b7322bdeb4092eab Mon Sep 17 00:00:00 2001
From: lucylq <lfq@meta.com>
Date: Wed, 10 Sep 2025 11:21:49 -0700
Subject: [PATCH 2/2] Update on "Deprecate debug buffer in Module"

It's in release 0.7 so can't remove it, following deprecation schedule.

debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty.

Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case.

Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/)

[ghstack-poisoned]
---
 extension/module/module.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/extension/module/module.h b/extension/module/module.h
index 970c3f9f1ea..b529455478d 100644
--- a/extension/module/module.h
+++ b/extension/module/module.h
@@ -598,6 +598,8 @@ class Module {
     return event_tracer_.get();
   }
 
+  // Note: thie debug_buffer will always be empty. The one being used is in
+  // the event_tracer attached to module. Please use that one.
   ET_DEPRECATED ET_NODISCARD runtime::Span<uint8_t> debug_buffer() {
     return runtime::Span<uint8_t>(debug_buffer_.data(), debug_buffer_.size());
   }