Skip to content

[Windows] Reduce Windows unit test CI usage #14350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
GregoryComer wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[Windows] Reduce Windows unit test CI usage #14350

GregoryComer wants to merge 4 commits into from

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Sep 16, 2025 •
edited
Loading

Trim down the Windows unit test CI. We can skip the native tests in the editable job, since they don't change at all with the python install. We can also skip the python tests in the release mode job, since it currently only builds the native tests in release mode (we always build the python extension in release mode).

@GregoryComer
Update
d903300 
[ghstack-poisoned]
@GregoryComer
Update
d039bee 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Sep 16, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14350

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit 1f50fbe with merge base 108d29d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Sep 16, 2025
@GregoryComer
[Windows] Reduce Windows unit test CI usage
9f7ed44 
ghstack-source-id: 5186408
ghstack-comment-id: 3300262560
Pull-Request: #14350
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2025
@GregoryComer GregoryComer mentioned this pull request Sep 16, 2025
Merged
@GregoryComer
Update
ffc3851 
[ghstack-poisoned]
@GregoryComer
Update
1f50fbe 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Sep 16, 2025
@GregoryComer
[Windows] Reduce Windows unit test CI usage
92683a3 
ghstack-source-id: c3f80af
ghstack-comment-id: 3300262560
Pull-Request: #14350
Base automatically changed from gh/GregoryComer/162/head to main September 17, 2025 17:48
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin Awaiting requested review from mergennachin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale PRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer