-
Notifications
You must be signed in to change notification settings - Fork 751
Arm backend: Support channels-last input and output #14400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Support channels-last input and output #14400
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14400
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit cb348ae with merge base e0dda90 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Re-running jobs with infra failures. If it looks good, I'll merge shortly. |
|
Samsung failure is unrelated infra. Discussed offline and it's being investigated. Merging. |
| "Input %d expected contiguous dim_order, but got non-contiguous dim_order", | ||
| i); | ||
| return Error::InvalidProgram; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we (somehow) check if the assumptions in the blob about the input tensor dim_order are satisfied? It can silently do wrong compute is my concern.
| def test_mv2_tosa_FP_channels_last(): | ||
| input_tensor = model_inputs[0].to(memory_format=torch.channels_last) | ||
| pipeline = TosaPipelineFP[input_t]( | ||
| mv2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is it working correctly with NHWC input without mv2.to(channels_last) - it could be because you are assuming every weight is lowered to TOSA and during lowering you might be formatting. But if you can't lower some weight then it may fail, no?
in channels first format.
from correct data format since numpy doesn't have the concept of
dim_order.
pass since the behaviour of channel last tensors is non-predictable.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218