-
Notifications
You must be signed in to change notification settings - Fork 712
Re-introduce some logging after backout #14526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14526
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Cancelled Job, 1 Pending, 1 Unrelated FailureAs of commit 16d27a4 with merge base 87c44c7 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
This PR needs a
|
ca8a22e to
944df24
Compare
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581441
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
|
@metascroy did you figure out the root cause of the original revert? |
944df24 to
c278f0c
Compare
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Reviewed By: mergennachin Differential Revision: D82581441
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Reviewed By: mergennachin Differential Revision: D82581441
c278f0c to
95dc2f1
Compare
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Reviewed By: mergennachin Differential Revision: D82581441
95dc2f1 to
48dd5a5
Compare
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Reviewed By: mergennachin Differential Revision: D82581441
48dd5a5 to
0975ebd
Compare
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Reviewed By: mergennachin Differential Revision: D82581441
0975ebd to
63537c6
Compare
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
63537c6 to
9971d35
Compare
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Reviewed By: mergennachin Differential Revision: D82581441
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Reviewed By: mergennachin Differential Revision: D82581441
9971d35 to
1337887
Compare
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
Summary: Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Reviewed By: mergennachin Differential Revision: D82581441
1337887 to
16d27a4
Compare
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441. |
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
Still investigating with internal teams. I do not think there was an issue with the OSS builds, though. |
Cherry picking #14526The cherry pick PR is at #14612 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Summary:
Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps:
Differential Revision: D82581441