Skip to content

Conversation

DrJessop
Copy link
Contributor

@DrJessop DrJessop commented Oct 3, 2025

Summary: Not supporting quantized relu default, so removing it from ref_implementations

Differential Revision: D83874866

Copy link

pytorch-bot bot commented Oct 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14788

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit b59a820 with merge base a39866c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83874866.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2025
@facebook-github-bot
Copy link
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83874866.

DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Oct 3, 2025
Summary:

Not supporting quantized relu default, so removing it from ref_implementations

Differential Revision: D83874866
Copy link

github-actions bot commented Oct 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Andrew Grebenisan added 4 commits October 6, 2025 13:46
Summary:

out shift should be int32

Reviewed By: hsharma35

Differential Revision: D83875670
…ariants

Summary: Fix to just call the per tensor variants for quantized conv and quantized relu, since those are the only ones we are supporting.

Differential Revision: D83873738
Summary: The original pass didn't fetch the user-provided zero point if it existed, it just assumed a hard-coded zero point. Fixed now.

Reviewed By: ethansfng

Differential Revision: D83873937
Summary:

Not supporting quantized relu default, so removing it from ref_implementations

Differential Revision: D83874866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants