Skip to content

Conversation

@roman-janik-nxp
Copy link
Collaborator

@roman-janik-nxp roman-janik-nxp commented Oct 6, 2025

Summary

This PR replaces optimizations 'fuse_activation_functions.py' by quantization of Conv 2D and Linear ops together with fusable activations - selected activations supported by Neutron (Relu, Relu6, Sigmoid, Tanh). Logic is determined by target specs, now supporting Neutron-C. Tests updated. Relu has now non-shared, standalone quantization.

Test plan

Unit tests provided (test_edge_passes.py, test_quantizer.py).

cc @robert-kalmar @JakeStevens @digantdesai

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14816

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 6f74f12 with merge base 1076686 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025
@roman-janik-nxp
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Oct 6, 2025
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-469-EIEX-470-Replace-pass-to-fuse-activations-functions_github branch 2 times, most recently from 33f153a to 8d9107b Compare October 9, 2025 11:45
Copy link
Collaborator

@StrycekSimon StrycekSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comments about shared quantization if it is not relevant.

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-469-EIEX-470-Replace-pass-to-fuse-activations-functions_github branch 2 times, most recently from 796789f to ce107df Compare October 15, 2025 22:39
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-469-EIEX-470-Replace-pass-to-fuse-activations-functions_github branch from ce107df to 6f74f12 Compare October 16, 2025 10:07
@MartinPavella MartinPavella self-requested a review October 16, 2025 11:42
@roman-janik-nxp roman-janik-nxp merged commit 9413da0 into pytorch:main Oct 16, 2025
136 of 138 checks passed
@roman-janik-nxp roman-janik-nxp deleted the feature/nxg11066/EIEX-469-EIEX-470-Replace-pass-to-fuse-activations-functions_github branch October 16, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants