From ef93d924a3e8772f2dc8db74cdcacea9f742e938 Mon Sep 17 00:00:00 2001 From: Saoirse Stewart Date: Mon, 13 Oct 2025 10:00:30 +0100 Subject: [PATCH 1/3] Arm backend: Update failures to slice operator for int16x8 --- backends/arm/test/ops/test_slice.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/backends/arm/test/ops/test_slice.py b/backends/arm/test/ops/test_slice.py index bdf5ccda770..7552124591f 100644 --- a/backends/arm/test/ops/test_slice.py +++ b/backends/arm/test/ops/test_slice.py @@ -78,8 +78,8 @@ def test_slice_tensor_tosa_INT_nhwc(test_data: torch.Tensor): x_fails = { - "ones_slice_3": "MLETORCH-1402: Slice operator has incorrect number of inputs", - "ones_slice_4": "MLETORCH-1402: Slice operator has incorrect number of inputs", + "ones_slice_3": "MLETORCH-1402: Compiler limitation when passing more than 255 char as argument to FVP.", + "ones_slice_4": "MLETORCH-1402: Compiler limitation when passing more than 255 char as argument to FVP.", } @@ -179,7 +179,7 @@ def test_slice_tensor_16a8w_tosa_INT(test_data: torch.Tensor): pipeline.run() -@common.parametrize("test_data", test_data_suite) +@common.parametrize("test_data", test_data_suite, x_fails) @common.XfailIfNoCorstone300 @pytest.mark.xfail( reason="Vela compilation fails with 'Invalid arguments' for int16 slice operations" @@ -206,7 +206,7 @@ def test_slice_tensor_16a8w_u55_INT16(test_data: torch.Tensor): pipeline.run() -@common.parametrize("test_data", test_data_suite) +@common.parametrize("test_data", test_data_suite, x_fails) @common.XfailIfNoCorstone320 @pytest.mark.xfail( reason="Vela compilation fails with 'Invalid arguments' for int16 slice operations" From 71fbef44dfe041d2fcf51348c43842b31c755af8 Mon Sep 17 00:00:00 2001 From: Saoirse Stewart Date: Mon, 13 Oct 2025 10:00:30 +0100 Subject: [PATCH 2/3] Arm backend: Remove pytest.mark.fails fomr testcases Change-Id: I1bcd5e1188b2562195f7b81d51a2ab3da3d114ca --- backends/arm/test/ops/test_slice.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/backends/arm/test/ops/test_slice.py b/backends/arm/test/ops/test_slice.py index 7552124591f..460cd81bd01 100644 --- a/backends/arm/test/ops/test_slice.py +++ b/backends/arm/test/ops/test_slice.py @@ -153,9 +153,6 @@ def get_symmetric_a16w8_slice_quantizer(per_channel_quantization=False): @common.parametrize("test_data", test_data_suite) -@pytest.mark.xfail( - reason="missing int16 slice ops support; fails at TOSA reference model with Unsupported operation type or rank. See: https://github.com/pytorch/executorch/issues/13976" -) def test_slice_tensor_16a8w_tosa_INT(test_data: torch.Tensor): """Test slice operation with 16A8W quantization (16-bit activations, 8-bit weights)""" per_channel_quantization = False @@ -181,9 +178,6 @@ def test_slice_tensor_16a8w_tosa_INT(test_data: torch.Tensor): @common.parametrize("test_data", test_data_suite, x_fails) @common.XfailIfNoCorstone300 -@pytest.mark.xfail( - reason="Vela compilation fails with 'Invalid arguments' for int16 slice operations" -) def test_slice_tensor_16a8w_u55_INT16(test_data: torch.Tensor): """Test slice operation with 16A8W quantization on U55 (16-bit activations, 8-bit weights)""" per_channel_quantization = False @@ -208,9 +202,6 @@ def test_slice_tensor_16a8w_u55_INT16(test_data: torch.Tensor): @common.parametrize("test_data", test_data_suite, x_fails) @common.XfailIfNoCorstone320 -@pytest.mark.xfail( - reason="Vela compilation fails with 'Invalid arguments' for int16 slice operations" -) def test_slice_tensor_16a8w_u85_INT16(test_data: torch.Tensor): """Test slice operation with 16A8W quantization on U85 (16-bit activations, 8-bit weights)""" per_channel_quantization = False From a627e26d7a5fc288c8444f059758d09151e29178 Mon Sep 17 00:00:00 2001 From: Saoirse Stewart Date: Thu, 16 Oct 2025 13:15:13 +0100 Subject: [PATCH 3/3] Fix linter issue --- backends/arm/test/ops/test_slice.py | 1 - 1 file changed, 1 deletion(-) diff --git a/backends/arm/test/ops/test_slice.py b/backends/arm/test/ops/test_slice.py index 460cd81bd01..43214ab42ac 100644 --- a/backends/arm/test/ops/test_slice.py +++ b/backends/arm/test/ops/test_slice.py @@ -7,7 +7,6 @@ from typing import Tuple -import pytest import torch from executorch.backends.arm.quantizer.arm_quantizer import ( get_symmetric_a16w8_quantization_config,