Skip to content

Use xt macros to capture errors returned by nnlib calls #15259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use xt macros to capture errors returned by nnlib calls #15259

wants to merge 1 commit into from
+332 −101

Conversation

hsharma35
Copy link
Contributor

Summary: This diff implements the use of xt macros to capture errors returned by nnlib calls in the Cadence backend operators.

Differential Revision: D83355891

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15259

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 108 Pending

As of commit 59a7e99 with merge base 788ef2f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2025
@meta-codesync Meta CodeSync
Copy link

meta-codesync bot commented Oct 19, 2025

@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83355891.

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@hsharma35 hsharma35 requested a review from zonglinpeng October 19, 2025 14:57
hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 21, 2025
@hsharma35 @meta-codesync
Use xt macros to capture errors returned by nnlib calls (pytorch#15259)
097ec64 
Summary:
Pull Request resolved: pytorch#15259

This diff implements the use of xt macros to capture errors returned by nnlib calls in the Cadence backend operators.

Differential Revision: D83355891
hsharma35 added a commit to hsharma35/executorch that referenced this pull request Oct 22, 2025
@hsharma35 @meta-codesync
Use xt macros to capture errors returned by nnlib calls (pytorch#15259)
b656803 
Summary:
Pull Request resolved: pytorch#15259

This diff implements the use of xt macros to capture errors returned by nnlib calls in the Cadence backend operators.

Reviewed By: zonglinpeng

Differential Revision: D83355891
@hsharma35 @meta-codesync
Use xt macros to capture errors returned by nnlib calls (pytorch#15259)
59a7e99 
Summary:
Pull Request resolved: pytorch#15259

This diff implements the use of xt macros to capture errors returned by nnlib calls in the Cadence backend operators.

Reviewed By: zonglinpeng

Differential Revision: D83355891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zonglinpeng zonglinpeng zonglinpeng approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hsharma35 @zonglinpeng