- 
                Notifications
    You must be signed in to change notification settings 
- Fork 706
Metal backend: Add MPSGraph caching #15346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Stack from ghstack (oldest at bottom): | 
| 🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15346
 Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 116 PendingAs of commit f66ac9c with merge base 526eb18 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. | 
  This was referenced Oct 22, 2025 
      
              
                    larryliu0820
  
              
              approved these changes
              
                  
                    Oct 22, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    CLA Signed
  This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. 
  
    release notes: none
  Do not include this in the release notes 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This pull request introduces a new caching infrastructure for compiled MPSGraph objects in the Metal backend, significantly improving performance for repeated matrix multiplication and convolution operations by reusing previously compiled graphs and their associated tensors. The changes also include cache statistics tracking and refactoring of the relevant code paths to leverage the cache. Note that caching for the attention operation is not yet implemented.
MPSGraph Caching Infrastructure
graph_cache) for compiledMPSGraphobjects and their input/output tensors, keyed by operation type and parameters, enabling reuse and reducing graph compilation overhead.GraphCacheKeyandCachedGraphstructures, along with a custom hash function, to uniquely identify and store cached graphs for matrix multiplication and convolution operations.Matrix Multiplication and Convolution Refactoring
aoti_torch_mps_mm_out) and convolution (aoti_torch_mps_convolution) functions to check the cache for an existing compiled graph before creating a new one, and to store newly compiled graphs in the cache for future reuse. [1] [2]MPSGraphobjects after execution, as cached graphs are now retained for reuse, preventing unnecessary recompilation and memory leaks. [1] [2]Cache Statistics and Monitoring
CacheStatsstructure to track cache hits and misses.