-
Notifications
You must be signed in to change notification settings - Fork 751
Android: Add Tensor.ones() and Tensor.zeros() factory methods #15388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Add Tensor.ones() and Tensor.zeros() factory methods #15388
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15388
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 6 PendingAs of commit fac5d2e with merge base 964515c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: misc" |
18e207f to
4c6d19d
Compare
|
@shubham0204 Thanks for the contribution. Can you fix the java android lint and rebase the PR? If everything looks good, we can merge it shortly. |
4c6d19d to
def5753
Compare
|
@GregoryComer I have fixed the Java formatting issues in the modified files. The formatting used is |
def5753 to
56ec76c
Compare
|
@GregoryComer @kirklandsign @psiddh Any updates on this PR? |
|
@shubham0204 Apologies for the slow response. Can you take a look at the errors in this CI job: https://github.com/pytorch/executorch/actions/runs/19102814458/job/54604914604?pr=15388? We should be good to merge once that's green. Thanks! |
…e tensors initialized with ones and zeros resp. (#15125)
56ec76c to
fac5d2e
Compare
|
@GregoryComer I have fixed the formatting issue that was causing the job to fail. Could you re-run those workflows? |
|
CI looks green, so I'll go ahead and merge. Thanks for the contribution! |
Fixes #15125
Release notes:
miscSummary
Tensor.ones()in theandroidextensionTest plan
The following new JUnit tests were added to verify the behavior of
Tensor.ones()inextension/android/executorch_android/src/test/java/org/pytorch/executorch/TensorTest.kttestOnes_DTypeIsFloatcc @kirklandsign @cbilgin