[slimtensor] Add CUDA DeviceType and extend Device class #16437
+144
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff adds CUDA device type support to SlimTensor's device infrastructure, preparing for CUDA tensor support in subsequent diffs. **Key changes:** 1. **`c10/core/DeviceType.h`** - Extended DeviceType enum: - Added `DeviceType::CUDA = 1` (matching PyTorch's enum value) - Added `kCUDA` constant for convenience - Updated `DeviceTypeName()` to support CUDA - Updated `isValidDeviceType()` to recognize CUDA - Updated `COMPILE_TIME_MAX_DEVICE_TYPES` to 2 2. **`c10/core/Device.h`** - Extended Device class: - Added `is_cuda()` method - Extended string constructor to parse "cuda", "CUDA", "cuda:N" formats - Updated `str()` to output CUDA device strings correctly Differential Revision: [D89825595](https://our.internmc.facebook.com/intern/diff/D89825595/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16437
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Cancelled Job, 2 Unrelated FailuresAs of commit 1045410 with merge base 35eb01a ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
This was referenced Jan 5, 2026
This was referenced Jan 6, 2026
This diff adds CUDA device type support to SlimTensor's device infrastructure, preparing for CUDA tensor support in subsequent diffs. **Key changes:** 1. **`c10/core/DeviceType.h`** - Extended DeviceType enum: - Added `DeviceType::CUDA = 1` (matching PyTorch's enum value) - Added `kCUDA` constant for convenience - Updated `DeviceTypeName()` to support CUDA - Updated `isValidDeviceType()` to recognize CUDA - Updated `COMPILE_TIME_MAX_DEVICE_TYPES` to 2 2. **`c10/core/Device.h`** - Extended Device class: - Added `is_cuda()` method - Extended string constructor to parse "cuda", "CUDA", "cuda:N" formats - Updated `str()` to output CUDA device strings correctly Differential Revision: [D89825595](https://our.internmc.facebook.com/intern/diff/D89825595/) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff adds CUDA device type support to SlimTensor's device infrastructure, preparing for CUDA tensor support in subsequent diffs.
Key changes:
c10/core/DeviceType.h- Extended DeviceType enum:DeviceType::CUDA = 1(matching PyTorch's enum value)kCUDAconstant for convenienceDeviceTypeName()to support CUDAisValidDeviceType()to recognize CUDACOMPILE_TIME_MAX_DEVICE_TYPESto 2c10/core/Device.h- Extended Device class:is_cuda()methodstr()to output CUDA device strings correctlyDifferential Revision: D89825595