diff --git a/backends/aoti/targets.bzl b/backends/aoti/targets.bzl index 327bef8cc53..6da54b884f0 100644 --- a/backends/aoti/targets.bzl +++ b/backends/aoti/targets.bzl @@ -49,7 +49,7 @@ def define_common_targets(): supports_python_dlopen = True, # Constructor needed for backend registration. compiler_flags = ["-Wno-global-constructors"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core:core", "//executorch/runtime/core/exec_aten:lib", @@ -67,7 +67,7 @@ def define_common_targets(): supports_python_dlopen = True, # Constructor needed for backend registration. compiler_flags = ["-Wno-global-constructors"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/backend:interface", "//executorch/runtime/core:core", @@ -80,7 +80,7 @@ def define_common_targets(): # @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole) link_whole = True, supports_python_dlopen = True, - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], exported_deps = [ ":common_shims", ":delegate_handle", diff --git a/backends/apple/coreml/TARGETS b/backends/apple/coreml/TARGETS index 2f3494b6004..5d50c344a83 100644 --- a/backends/apple/coreml/TARGETS +++ b/backends/apple/coreml/TARGETS @@ -8,9 +8,7 @@ oncall("executorch") # TODO: this is a placeholder to support internal fbcode build. We should add the coreml backend target properly. runtime.python_library( name = "coreml", - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -19,9 +17,7 @@ runtime.python_library( "compiler/*.py", "logging.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/coremltools:coremltools", ":executorchcoreml", @@ -36,9 +32,7 @@ runtime.python_library( "partition/*.py", "logging.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/coremltools:coremltools", ":backend", @@ -55,9 +49,7 @@ runtime.python_library( srcs = glob([ "quantizer/*.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -66,10 +58,7 @@ runtime.python_library( "recipes/__init__.py", "recipes/coreml_recipe_provider.py" ], - visibility = [ - "@EXECUTORCH_CLIENTS", - "//executorch/export/...", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/coremltools:coremltools", ":coreml_recipe_types", @@ -91,10 +80,7 @@ runtime.python_library( srcs = [ "recipes/coreml_recipe_types.py", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - "//executorch/export/...", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/export:recipe", ], @@ -124,10 +110,7 @@ runtime.cxx_python_extension( types = [ "executorchcoreml.pyi", ], - visibility = [ - "//executorch/examples/apple/coreml/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/nlohmann-json:nlohmann-json", "fbsource//third-party/pybind11:pybind11", diff --git a/backends/apple/mps/TARGETS b/backends/apple/mps/TARGETS index 1ab92b3fca0..d138b02e991 100644 --- a/backends/apple/mps/TARGETS +++ b/backends/apple/mps/TARGETS @@ -19,9 +19,7 @@ runtime.python_library( "__init__.py", "mps_preprocess.py", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":operators", ":serialization", @@ -49,9 +47,7 @@ runtime.python_library( srcs = glob([ "partition/*.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":backend", "//caffe2:torch", diff --git a/backends/apple/mps/targets.bzl b/backends/apple/mps/targets.bzl index 99c97d2b318..d2ab3a0755b 100644 --- a/backends/apple/mps/targets.bzl +++ b/backends/apple/mps/targets.bzl @@ -39,16 +39,7 @@ def define_common_targets(is_xplat = False, platforms = []): "runtime/operations/*.h", ]), "srcs": MPS_BACKEND_BUCK_SRCS, - "visibility": [ - "//executorch/backends/apple/...", - "//executorch/examples/...", - "//executorch/exir/backend:backend_lib", - "//executorch/extension/pybindings/...", - "//executorch/runtime/backend/...", - "//executorch/devtools/runners/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + "visibility": ["PUBLIC"], "link_whole": True, } diff --git a/backends/arm/runtime/targets.bzl b/backends/arm/runtime/targets.bzl index b4c17acda34..7dd0d74ec7d 100644 --- a/backends/arm/runtime/targets.bzl +++ b/backends/arm/runtime/targets.bzl @@ -5,7 +5,7 @@ def define_common_targets(): name = "vela_bin_stream", srcs = ["VelaBinStream.cpp"], exported_headers = ["VelaBinStream.h"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core:core", ], @@ -21,7 +21,7 @@ def define_common_targets(): supports_python_dlopen = True, # Constructor needed for backend registration. compiler_flags = ["-Wno-global-constructors"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/backend:interface", ":vela_bin_stream", diff --git a/backends/cadence/fusion_g3/operators/targets.bzl b/backends/cadence/fusion_g3/operators/targets.bzl index dd04bd1223b..d09a9e65326 100644 --- a/backends/cadence/fusion_g3/operators/targets.bzl +++ b/backends/cadence/fusion_g3/operators/targets.bzl @@ -23,10 +23,7 @@ def define_operator(name: str, deps: list[str] | None = None) -> None: name = op_name, srcs = [op_name + ".cpp"], platforms = CXX, - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], compatible_with = ["ovr_config//cpu:xtensa"], deps = deps + common_deps, ) diff --git a/backends/cadence/generic/kernels/targets.bzl b/backends/cadence/generic/kernels/targets.bzl index d50cfe8f130..71f6b156ed1 100644 --- a/backends/cadence/generic/kernels/targets.bzl +++ b/backends/cadence/generic/kernels/targets.bzl @@ -8,9 +8,6 @@ def define_common_targets(): exported_headers = [ "kernels.h", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], platforms = CXX, ) diff --git a/backends/cadence/generic/operators/targets.bzl b/backends/cadence/generic/operators/targets.bzl index af271ace5ac..ece81f2ec54 100644 --- a/backends/cadence/generic/operators/targets.bzl +++ b/backends/cadence/generic/operators/targets.bzl @@ -38,10 +38,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", "//executorch/backends/cadence/generic/kernels:cadence_kernels", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -53,10 +50,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", "//executorch/backends/cadence/generic/kernels:cadence_kernels", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -69,10 +63,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/kernel:kernel_runtime_context", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -85,10 +76,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/kernel:kernel_runtime_context", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -102,10 +90,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten/util:tensor_util", "//executorch/runtime/kernel:kernel_runtime_context", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -118,10 +103,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/kernel:kernel_runtime_context", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -135,10 +117,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -151,10 +130,7 @@ def define_common_targets(): "//executorch/backends/cadence/generic/kernels:cadence_kernels", "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -167,10 +143,7 @@ def define_common_targets(): "//executorch/backends/cadence/generic/kernels:cadence_kernels", "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -184,10 +157,7 @@ def define_common_targets(): ":quantized_linear", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -200,10 +170,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -217,10 +184,7 @@ def define_common_targets(): ":quantized_op_macros", ":quantized_linear", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -233,10 +197,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -249,10 +210,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -266,10 +224,7 @@ def define_common_targets(): "//executorch/kernels/portable/cpu:scalar_utils", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -284,10 +239,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -299,10 +251,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -315,10 +264,7 @@ def define_common_targets(): "//executorch/runtime/kernel:kernel_includes", ":quantized_op_macros", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) @@ -334,10 +280,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/kernel:kernel_runtime_context", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -348,10 +291,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -362,10 +302,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -376,10 +313,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -392,10 +326,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/kernel:kernel_runtime_context", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -406,10 +337,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -422,10 +350,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/kernel:kernel_runtime_context", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -438,10 +363,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/kernel:kernel_runtime_context", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -457,10 +379,7 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -476,10 +395,7 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -493,8 +409,5 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/backends/cadence/hifi/kernels/targets.bzl b/backends/cadence/hifi/kernels/targets.bzl index fe5feed69b5..be04d4c0b35 100644 --- a/backends/cadence/hifi/kernels/targets.bzl +++ b/backends/cadence/hifi/kernels/targets.bzl @@ -14,10 +14,7 @@ def define_common_targets(): ], deps = common_deps, compatible_with = ["ovr_config//cpu:xtensa"], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "fbsource//third-party/nnlib-hifi4/xa_nnlib:libxa_nnlib_common", ], diff --git a/backends/cadence/hifi/operators/targets.bzl b/backends/cadence/hifi/operators/targets.bzl index 5a92a37237f..7937bea0682 100644 --- a/backends/cadence/hifi/operators/targets.bzl +++ b/backends/cadence/hifi/operators/targets.bzl @@ -28,10 +28,7 @@ def define_operator(name: str, deps: list[str] | None = None, exported_headers: name = op_name, srcs = [op_name + ".cpp"], platforms = CXX, - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], compatible_with = ["ovr_config//cpu:xtensa"], deps = deps + common_deps, exported_headers = exported_headers, diff --git a/backends/cadence/hifi/third-party/nnlib/targets.bzl b/backends/cadence/hifi/third-party/nnlib/targets.bzl index 2ad9d6568ac..807d98b04c7 100644 --- a/backends/cadence/hifi/third-party/nnlib/targets.bzl +++ b/backends/cadence/hifi/third-party/nnlib/targets.bzl @@ -8,10 +8,7 @@ def define_common_targets(): name = "nnlib-extensions", srcs = native.glob(["*.c", "*.cpp"]), exported_headers = glob(["*.h"]), - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], compatible_with = ["ovr_config//cpu:xtensa"], compiler_flags = [ "-Wno-pointer-sign", diff --git a/backends/cadence/runtime/targets.bzl b/backends/cadence/runtime/targets.bzl index 09a116764c2..25eddae42f3 100644 --- a/backends/cadence/runtime/targets.bzl +++ b/backends/cadence/runtime/targets.bzl @@ -5,10 +5,7 @@ def define_common_targets(): name = "et_pal", srcs = ["et_pal.cpp"], link_whole = True, - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS" - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/platform:platform", ], @@ -17,10 +14,7 @@ def define_common_targets(): runtime.python_library( name = "etdump", srcs = ["etdump.py"], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS" - ], + visibility = ["PUBLIC"], deps = [ "fbcode//executorch/devtools:lib", "fbcode//executorch/devtools/inspector:inspector_utils", diff --git a/backends/cadence/vision/kernels/targets.bzl b/backends/cadence/vision/kernels/targets.bzl index 02136c872b3..77cebcd05ea 100644 --- a/backends/cadence/vision/kernels/targets.bzl +++ b/backends/cadence/vision/kernels/targets.bzl @@ -8,10 +8,7 @@ def define_common_targets(): exported_headers = [ "kernels.h", ], - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], platforms = CXX, compatible_with = select({ "DEFAULT": [], diff --git a/backends/cadence/vision/operators/targets.bzl b/backends/cadence/vision/operators/targets.bzl index 2dd47e12bd2..399e2096c28 100644 --- a/backends/cadence/vision/operators/targets.bzl +++ b/backends/cadence/vision/operators/targets.bzl @@ -44,10 +44,7 @@ def define_operator(name: str, deps: list[str] | None = None) -> None: name = op_name, srcs = [op_name + ".cpp"], platforms = CXX, - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], compatible_with = ["ovr_config//cpu:xtensa"], deps = deps + common_deps, exported_headers = exported_headers, diff --git a/backends/cadence/vision/third-party/targets.bzl b/backends/cadence/vision/third-party/targets.bzl index 26a097010d5..be3ead43162 100644 --- a/backends/cadence/vision/third-party/targets.bzl +++ b/backends/cadence/vision/third-party/targets.bzl @@ -17,10 +17,7 @@ def define_common_targets(): "include_private/*.h" ]), header_namespace = "", - visibility = [ - "//executorch/backends/cadence/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], platforms = CXX, compatible_with = select({ "DEFAULT": [], diff --git a/backends/cortex_m/ops/targets.bzl b/backends/cortex_m/ops/targets.bzl index 304f02ca7a4..250fcf9e330 100644 --- a/backends/cortex_m/ops/targets.bzl +++ b/backends/cortex_m/ops/targets.bzl @@ -41,10 +41,7 @@ def define_common_targets(): runtime.cxx_library( name = "cortex_m_operators", srcs = [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], platforms = CXX, exported_deps = all_op_targets, ) diff --git a/backends/cuda/runtime/TARGETS b/backends/cuda/runtime/TARGETS index a85f3a7e6a3..532ab5544ab 100644 --- a/backends/cuda/runtime/TARGETS +++ b/backends/cuda/runtime/TARGETS @@ -14,7 +14,7 @@ runtime.cxx_library( # @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole) link_whole = True, supports_python_dlopen = True, - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core:core", ], @@ -38,7 +38,7 @@ runtime.cxx_library( # @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole) link_whole = True, supports_python_dlopen = True, - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core:core", "//executorch/runtime/core/exec_aten:lib", @@ -69,7 +69,7 @@ runtime.cxx_library( supports_python_dlopen = True, # Constructor needed for backend registration. compiler_flags = ["-Wno-global-constructors"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ ":tensor_maker", "//executorch/backends/aoti:common_shims", @@ -97,7 +97,7 @@ runtime.cxx_library( supports_python_dlopen = True, # Constructor needed for backend registration. compiler_flags = ["-Wno-global-constructors"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ ":runtime_shims", "//executorch/backends/aoti:aoti_common", diff --git a/backends/nxp/runtime/targets.bzl b/backends/nxp/runtime/targets.bzl index 3214761a9cb..f15495efdb7 100644 --- a/backends/nxp/runtime/targets.bzl +++ b/backends/nxp/runtime/targets.bzl @@ -13,11 +13,7 @@ def define_common_targets(): # Constructor needed for backend registration. compiler_flags = ["-Wno-global-constructors", "-fno-rtti", "-DNO_HEAP_USAGE"], labels = [ci.skip_target()], - visibility = [ - "//executorch/backends/nxp/runtime/fb:nxp_fb_backend", - "//executorch/backends/nxp/runtime/fb:nxp_hifi_fb_backend", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/backend:interface", "//executorch/runtime/core:core", diff --git a/backends/qualcomm/TARGETS b/backends/qualcomm/TARGETS index 895a5e8aae4..747930e8e84 100644 --- a/backends/qualcomm/TARGETS +++ b/backends/qualcomm/TARGETS @@ -8,10 +8,7 @@ define_common_targets() runtime.python_library( name = "preprocess", srcs = ["qnn_preprocess.py"], - visibility = [ - "//executorch/backends/qualcomm/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/backends/qualcomm/_passes:passes", ], diff --git a/backends/qualcomm/_passes/TARGETS b/backends/qualcomm/_passes/TARGETS index 876b51d3863..eaea7236c93 100644 --- a/backends/qualcomm/_passes/TARGETS +++ b/backends/qualcomm/_passes/TARGETS @@ -7,9 +7,7 @@ runtime.python_library( srcs = glob([ "*.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/backends/transforms:addmm_mm_to_linear", "//executorch/backends/transforms:decompose_sdpa", diff --git a/backends/qualcomm/aot/python/targets.bzl b/backends/qualcomm/aot/python/targets.bzl index 0133aa73b93..f9dffafed9f 100644 --- a/backends/qualcomm/aot/python/targets.bzl +++ b/backends/qualcomm/aot/python/targets.bzl @@ -55,7 +55,7 @@ def define_common_targets(): "*.h", ]), platforms = (CXX), - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "//executorch/backends/qualcomm/aot/wrappers:wrappers", "//executorch/backends/qualcomm/runtime:logging", diff --git a/backends/qualcomm/aot/wrappers/targets.bzl b/backends/qualcomm/aot/wrappers/targets.bzl index 9c77a637b5e..cbd7ce32427 100644 --- a/backends/qualcomm/aot/wrappers/targets.bzl +++ b/backends/qualcomm/aot/wrappers/targets.bzl @@ -21,7 +21,7 @@ def define_common_targets(): ]), define_static_target = True, platforms = [ANDROID], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/qualcomm/qnn/qnn-{0}:api".format(get_qnn_library_version()), "fbsource//third-party/qualcomm/qnn/qnn-{0}:app_sources".format(get_qnn_library_version()), diff --git a/backends/qualcomm/builders/targets.bzl b/backends/qualcomm/builders/targets.bzl index fc7d88781cc..046e2f478dd 100644 --- a/backends/qualcomm/builders/targets.bzl +++ b/backends/qualcomm/builders/targets.bzl @@ -11,9 +11,7 @@ def define_common_targets(): srcs = glob([ "*.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir/backend:backend_details", "//executorch/exir/backend:compile_spec_schema", diff --git a/backends/qualcomm/partition/targets.bzl b/backends/qualcomm/partition/targets.bzl index 72248a6cebb..67c3cd5fdf4 100644 --- a/backends/qualcomm/partition/targets.bzl +++ b/backends/qualcomm/partition/targets.bzl @@ -11,9 +11,7 @@ def define_common_targets(): srcs = glob([ "*.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir/backend:backend_details", "//executorch/exir/backend:compile_spec_schema", diff --git a/backends/qualcomm/quantizer/targets.bzl b/backends/qualcomm/quantizer/targets.bzl index e7a94faa652..4247da7b969 100644 --- a/backends/qualcomm/quantizer/targets.bzl +++ b/backends/qualcomm/quantizer/targets.bzl @@ -12,9 +12,7 @@ def define_common_targets(): "*.py", "*/*.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/backends/transforms:decompose_sdpa", ], diff --git a/backends/qualcomm/recipes/TARGETS b/backends/qualcomm/recipes/TARGETS index 6a7abfd61c6..dca1e6fd232 100644 --- a/backends/qualcomm/recipes/TARGETS +++ b/backends/qualcomm/recipes/TARGETS @@ -7,10 +7,7 @@ runtime.python_library( srcs = [ "__init__.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/export:recipe_registry", ":qnn_recipe_provider", @@ -23,10 +20,7 @@ runtime.python_library( srcs = [ "qnn_recipe_provider.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/export:lib", @@ -44,10 +38,7 @@ runtime.python_library( srcs = [ "qnn_recipe_types.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/export:lib", ], diff --git a/backends/qualcomm/runtime/targets.bzl b/backends/qualcomm/runtime/targets.bzl index 85cece2bae7..978ce339fc2 100644 --- a/backends/qualcomm/runtime/targets.bzl +++ b/backends/qualcomm/runtime/targets.bzl @@ -22,7 +22,7 @@ def define_common_targets(): ], define_static_target = True, platforms = [ANDROID], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/qualcomm/qnn/qnn-{0}:api".format(get_qnn_library_version()), "fbsource//third-party/qualcomm/qnn/qnn-{0}:app_sources".format(get_qnn_library_version()), @@ -66,7 +66,7 @@ def define_common_targets(): define_static_target = True, link_whole = True, # needed for executorch/examples/models/llama:main to register QnnBackend platforms = [ANDROID], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], resources = ({ "qnn_lib": "fbsource//third-party/qualcomm/qnn/qnn-{0}:qnn_offline_compile_libs".format(get_qnn_library_version()), } if include_aot_qnn_lib else { diff --git a/backends/qualcomm/serialization/targets.bzl b/backends/qualcomm/serialization/targets.bzl index c4a40ba0130..01ca7ab0843 100644 --- a/backends/qualcomm/serialization/targets.bzl +++ b/backends/qualcomm/serialization/targets.bzl @@ -21,9 +21,7 @@ def define_common_targets(): resources = { ":qc_compiler_spec_schema": "qc_compiler_spec.fbs", }, - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir/backend:backend_details", "//executorch/exir/backend:compile_spec_schema", diff --git a/backends/qualcomm/targets.bzl b/backends/qualcomm/targets.bzl index 2301e6184db..5c604f9837b 100644 --- a/backends/qualcomm/targets.bzl +++ b/backends/qualcomm/targets.bzl @@ -82,7 +82,7 @@ def define_common_targets(): srcs = [], headers = [], define_static_target = True, - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/qualcomm/qnn/qnn-{0}:api".format(get_qnn_library_version()), "//executorch/runtime/backend:interface", diff --git a/backends/qualcomm/utils/targets.bzl b/backends/qualcomm/utils/targets.bzl index c76ef7f1906..4ec50f0268b 100644 --- a/backends/qualcomm/utils/targets.bzl +++ b/backends/qualcomm/utils/targets.bzl @@ -11,9 +11,7 @@ def define_common_targets(): srcs = glob([ "*.py", ]), - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir/backend:backend_details", "//executorch/exir/backend:compile_spec_schema", diff --git a/backends/test/harness/TARGETS b/backends/test/harness/TARGETS index d4edf9fb248..2799aedb7b5 100644 --- a/backends/test/harness/TARGETS +++ b/backends/test/harness/TARGETS @@ -5,10 +5,7 @@ oncall("executorch") runtime.python_library( name = "tester", srcs = native.glob(["*.py", "stages/*.py"]), - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir:graph_module", ], diff --git a/backends/transforms/targets.bzl b/backends/transforms/targets.bzl index 11a5b26e095..3cda58f6426 100644 --- a/backends/transforms/targets.bzl +++ b/backends/transforms/targets.bzl @@ -36,10 +36,7 @@ def define_common_targets(): runtime.python_library( name = "decompose_sdpa", srcs = ["decompose_sdpa.py"], - visibility = [ - "//executorch/backends/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir:pass_base", @@ -107,10 +104,7 @@ def define_common_targets(): runtime.python_library( name = "remove_clone_ops", srcs = ["remove_clone_ops.py"], - visibility = [ - "//executorch/backends/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir:pass_base", @@ -164,12 +158,7 @@ def define_common_targets(): runtime.python_library( name = "duplicate_dynamic_quant_chain", srcs = ["duplicate_dynamic_quant_chain.py"], - visibility = [ - "//executorch/backends/...", - "//executorch/examples/...", - "//executorch/extension/llm/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", ], @@ -180,10 +169,7 @@ def define_common_targets(): srcs = [ "convert_dtype_pass.py", ], - visibility = [ - "//executorch/backends/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir:pass_base", diff --git a/backends/vulkan/partitioner/TARGETS b/backends/vulkan/partitioner/TARGETS index 986d872f730..3177ed2807e 100644 --- a/backends/vulkan/partitioner/TARGETS +++ b/backends/vulkan/partitioner/TARGETS @@ -7,10 +7,7 @@ runtime.python_library( srcs = [ "vulkan_partitioner.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/backends/vulkan:op_registry", "//executorch/backends/vulkan:utils_lib", diff --git a/backends/vulkan/serialization/targets.bzl b/backends/vulkan/serialization/targets.bzl index 15ec61e70b0..caf18b255bc 100644 --- a/backends/vulkan/serialization/targets.bzl +++ b/backends/vulkan/serialization/targets.bzl @@ -47,11 +47,7 @@ def define_common_targets(is_fbcode = False): resources = [ "schema.fbs", ], - visibility = [ - "//executorch/...", - "//executorch/vulkan/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir:graph_module", "//executorch/exir/_serialize:_bindings", diff --git a/backends/vulkan/targets.bzl b/backends/vulkan/targets.bzl index 64d6c672007..ad8f9131fe9 100644 --- a/backends/vulkan/targets.bzl +++ b/backends/vulkan/targets.bzl @@ -158,10 +158,7 @@ def define_common_targets(is_fbcode = False): runtime.python_binary( name = "gen_vulkan_spv_bin", main_module = "runtime.gen_vulkan_spv", - visibility = [ - "//executorch/backends/vulkan/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":gen_vulkan_spv_lib", ], @@ -241,10 +238,7 @@ def define_common_targets(is_fbcode = False): ]), labels = get_labels(no_volk), platforms = get_platforms(), - visibility = [ - "//executorch/backends/vulkan/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], fbobjc_frameworks = select({ "DEFAULT": [], "ovr_config//os:macos": [ @@ -270,12 +264,7 @@ def define_common_targets(is_fbcode = False): ]), labels = get_labels(no_volk), platforms = get_platforms(), - visibility = [ - "//executorch/backends/...", - "//executorch/extension/pybindings/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":vulkan_graph_runtime_shaderlib{}".format(suffix), "//executorch/runtime/backend:interface", @@ -309,12 +298,7 @@ def define_common_targets(is_fbcode = False): ]), labels = get_labels(no_volk), platforms = get_platforms(), - visibility = [ - "//executorch/backends/...", - "//executorch/extension/pybindings/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":vulkan_graph_runtime{}".format(suffix), "//executorch/backends/vulkan/serialization:vk_delegate_schema", @@ -353,11 +337,7 @@ def define_common_targets(is_fbcode = False): srcs = [ "custom_ops_lib.py" ], - visibility = [ - "//executorch/...", - "//executorch/vulkan/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/backends/vulkan/patterns:vulkan_patterns", @@ -369,11 +349,7 @@ def define_common_targets(is_fbcode = False): srcs = [ "op_registry.py", ], - visibility = [ - "//executorch/...", - "//executorch/vulkan/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":custom_ops_lib", ":utils_lib", @@ -388,11 +364,7 @@ def define_common_targets(is_fbcode = False): srcs = [ "vulkan_preprocess.py", ], - visibility = [ - "//executorch/...", - "//executorch/vulkan/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/backends/transforms:addmm_mm_to_linear", "//executorch/backends/transforms:fuse_batch_norm_with_conv", diff --git a/backends/vulkan/test/custom_ops/targets.bzl b/backends/vulkan/test/custom_ops/targets.bzl index ace56a7cf25..6f35444570b 100644 --- a/backends/vulkan/test/custom_ops/targets.bzl +++ b/backends/vulkan/test/custom_ops/targets.bzl @@ -38,10 +38,7 @@ def define_common_targets(is_fbcode = False): "glsl/*.glsl", "glsl/*.yaml", ]), - visibility = [ - "//executorch/backends/vulkan/test/custom_ops/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) vulkan_spv_shader_lib( @@ -71,10 +68,7 @@ def define_common_targets(is_fbcode = False): deps = [ "//executorch/backends/vulkan:vulkan_graph_runtime", ], - visibility = [ - "//executorch/backends/vulkan/test/custom_ops/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # Operator implementations library @@ -88,10 +82,7 @@ def define_common_targets(is_fbcode = False): "//executorch/backends/vulkan:vulkan_graph_runtime", ":custom_ops_shaderlib", ], - visibility = [ - "//executorch/backends/vulkan/test/custom_ops/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], link_whole = True, ) diff --git a/backends/vulkan/test/op_tests/targets.bzl b/backends/vulkan/test/op_tests/targets.bzl index dae2eddf8b2..4d11886f590 100644 --- a/backends/vulkan/test/op_tests/targets.bzl +++ b/backends/vulkan/test/op_tests/targets.bzl @@ -158,10 +158,7 @@ def define_common_targets(is_fbcode = False): "//executorch/runtime/core/exec_aten:lib", runtime.external_dep_location("libtorch"), ], - visibility = [ - "//executorch/backends/vulkan/test/op_tests/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) define_test_targets( diff --git a/backends/xnnpack/TARGETS b/backends/xnnpack/TARGETS index d5c6d6303d2..4a9fc70cc97 100644 --- a/backends/xnnpack/TARGETS +++ b/backends/xnnpack/TARGETS @@ -10,10 +10,7 @@ runtime.python_library( srcs = [ "xnnpack_preprocess.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/backends/transforms:lib", "//executorch/backends/transforms:remove_getitem_op", @@ -30,10 +27,7 @@ runtime.python_library( srcs = [ "__init__.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":xnnpack_preprocess", "//executorch/backends/xnnpack/partition:xnnpack_partitioner", diff --git a/backends/xnnpack/operators/TARGETS b/backends/xnnpack/operators/TARGETS index 1fd4b5c4757..f6d48a8a45f 100644 --- a/backends/xnnpack/operators/TARGETS +++ b/backends/xnnpack/operators/TARGETS @@ -5,10 +5,7 @@ oncall("executorch") runtime.python_library( name = "operators", srcs = glob(["*.py"]), - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/backends/xnnpack/utils:xnnpack_utils", "//executorch/exir:graph_module", diff --git a/backends/xnnpack/partition/TARGETS b/backends/xnnpack/partition/TARGETS index 6b81558e3be..bb052902fed 100644 --- a/backends/xnnpack/partition/TARGETS +++ b/backends/xnnpack/partition/TARGETS @@ -7,10 +7,7 @@ runtime.python_library( srcs = [ "xnnpack_partitioner.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":partitioner_graphs", "//executorch/backends/xnnpack:xnnpack_preprocess", @@ -28,10 +25,7 @@ runtime.python_library( srcs = glob([ "graphs/*.py", ]), - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir:lib", ], diff --git a/backends/xnnpack/partition/config/TARGETS b/backends/xnnpack/partition/config/TARGETS index adfbf95a721..af6472634b5 100644 --- a/backends/xnnpack/partition/config/TARGETS +++ b/backends/xnnpack/partition/config/TARGETS @@ -7,10 +7,7 @@ runtime.python_library( srcs = glob([ "*.py", ]), - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir:lib", "//executorch/exir/backend:partitioner", diff --git a/backends/xnnpack/recipes/TARGETS b/backends/xnnpack/recipes/TARGETS index 5d452b4a4b7..03bdd7230c4 100644 --- a/backends/xnnpack/recipes/TARGETS +++ b/backends/xnnpack/recipes/TARGETS @@ -7,10 +7,7 @@ runtime.python_library( srcs = [ "__init__.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/export:recipe_registry", ":xnnpack_recipe_provider", @@ -23,10 +20,7 @@ runtime.python_library( srcs = [ "xnnpack_recipe_provider.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/export:lib", @@ -42,10 +36,7 @@ runtime.python_library( srcs = [ "xnnpack_recipe_types.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/export:recipe", ], diff --git a/backends/xnnpack/serialization/TARGETS b/backends/xnnpack/serialization/TARGETS index eeada820639..a644520ac64 100644 --- a/backends/xnnpack/serialization/TARGETS +++ b/backends/xnnpack/serialization/TARGETS @@ -10,10 +10,7 @@ runtime.python_library( srcs = [ "xnnpack_graph_schema.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -24,10 +21,7 @@ runtime.python_library( resources = [ "schema.fbs", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":xnnpack_schema", "//executorch/exir/_serialize:lib", diff --git a/backends/xnnpack/targets.bzl b/backends/xnnpack/targets.bzl index 796fd887e33..868e68e5b8c 100644 --- a/backends/xnnpack/targets.bzl +++ b/backends/xnnpack/targets.bzl @@ -28,10 +28,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/backend:interface", ], - visibility = [ - "//executorch/backends/xnnpack/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) for aten_mode in get_aten_mode_options(): @@ -43,13 +40,7 @@ def define_common_targets(): "runtime/*.h", "runtime/profiling/*.h", ]), - visibility = [ - "//executorch/exir/backend:backend_lib", - "//executorch/exir/backend/test/...", - "//executorch/backends/xnnpack/test/...", - "//executorch/extension/pybindings/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], preprocessor_flags = [ # Uncomment to enable per operator timings # "-DENABLE_XNNPACK_PROFILING", @@ -76,9 +67,7 @@ def define_common_targets(): runtime.cxx_library( name = "xnnpack_interface", - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_headers = [ "runtime/XNNPACKBackend.h", ], diff --git a/backends/xnnpack/test/tester/TARGETS b/backends/xnnpack/test/tester/TARGETS index 44925141cca..00662e4a934 100644 --- a/backends/xnnpack/test/tester/TARGETS +++ b/backends/xnnpack/test/tester/TARGETS @@ -9,10 +9,7 @@ runtime.python_library( "tester.py", ], base_module = "executorch.backends.xnnpack.test.tester", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/backends/test/harness:tester", diff --git a/codegen/targets.bzl b/codegen/targets.bzl index 6dc63c5b9ca..8c60cdcddf1 100644 --- a/codegen/targets.bzl +++ b/codegen/targets.bzl @@ -15,10 +15,7 @@ def define_common_targets(): "templates/**/*.ini", "templates/**/*.h", ]), - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -26,11 +23,7 @@ def define_common_targets(): exported_headers = [ "macros.h", ], - visibility = [ - "//executorch/runtime/kernel/...", - "//executorch/kernels/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -61,10 +54,7 @@ def define_common_targets(): deps = [ ":api", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - "//executorch/codegen/...", - ], + visibility = ["PUBLIC"], ) runtime.python_binary( diff --git a/codegen/tools/targets.bzl b/codegen/tools/targets.bzl index c11982409f0..b9d0100d8a2 100644 --- a/codegen/tools/targets.bzl +++ b/codegen/tools/targets.bzl @@ -29,10 +29,7 @@ def define_common_targets(is_fbcode = False): ], preload_deps = ["//executorch/codegen/tools:selective_build"], package_style = "inplace", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -72,10 +69,7 @@ def define_common_targets(is_fbcode = False): ":gen_oplist_lib", ], package_style = "inplace", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -224,10 +218,7 @@ def define_common_targets(is_fbcode = False): srcs = ["gen_ops_def.py"], main_module = "executorch.codegen.tools.gen_ops_def", package_style = "inplace", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/pyyaml:pyyaml", ":yaml_util", diff --git a/configurations/targets.bzl b/configurations/targets.bzl index 5a39f7301ec..487a8603d65 100644 --- a/configurations/targets.bzl +++ b/configurations/targets.bzl @@ -22,10 +22,7 @@ def define_common_targets(): exported_deps = [ "//executorch/extension/threadpool:threadpool", ] + get_all_cpu_backend_targets(), - visibility = [ - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # Add a common configuration of cpu optimized operators. This adds a bit of confusion @@ -45,8 +42,5 @@ def define_common_targets(): functions_yaml_target = "//executorch/kernels/optimized:optimized.yaml", fallback_yaml_target = "//executorch/kernels/portable:functions.yaml", define_static_targets = True, - visibility = [ - "//executorch/examples/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/devtools/backend_debug/TARGETS b/devtools/backend_debug/TARGETS index 95529192a39..00fde3ee3b4 100644 --- a/devtools/backend_debug/TARGETS +++ b/devtools/backend_debug/TARGETS @@ -8,12 +8,7 @@ runtime.python_library( "__init__.py", "delegation_info.py", ], - visibility = [ - "//executorch/...", - "//executorch/exir/backend/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/pandas:pandas", "//caffe2:torch", diff --git a/devtools/bundled_program/TARGETS b/devtools/bundled_program/TARGETS index 74e813cbf80..10d4d0b9154 100644 --- a/devtools/bundled_program/TARGETS +++ b/devtools/bundled_program/TARGETS @@ -10,10 +10,7 @@ runtime.python_library( srcs = [ "core.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":config", ":version", @@ -29,10 +26,7 @@ runtime.python_library( srcs = [ "config.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/typing-extensions:typing-extensions", "//caffe2:torch", diff --git a/devtools/bundled_program/serialize/TARGETS b/devtools/bundled_program/serialize/TARGETS index 11c58399778..1cacc04dc18 100644 --- a/devtools/bundled_program/serialize/TARGETS +++ b/devtools/bundled_program/serialize/TARGETS @@ -16,19 +16,7 @@ runtime.python_library( # Currently serialization API should only be used in some dedicated targets, # to avoid ODR violation when linking with another Flatbuffers library. # Please ask before changing this. - visibility = [ - "//executorch/bacends/...", - "//executorch/backends/xnnpack/test/...", - "//executorch/codegen/...", - "//executorch/devtools/bundled_program/tests/...", - "//executorch/examples/async_exec:emit_program_lib", - "//executorch/exir:lib", - "//executorch/extension/pybindings/test:test", - "//executorch/extension/pybindings/test:test-library", - "//executorch/profiler/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/setuptools:setuptools", "//executorch/devtools/bundled_program/schema:bundled_program_schema_py", diff --git a/devtools/bundled_program/targets.bzl b/devtools/bundled_program/targets.bzl index 09e9aae11b1..29b0fe5f94a 100644 --- a/devtools/bundled_program/targets.bzl +++ b/devtools/bundled_program/targets.bzl @@ -13,10 +13,7 @@ def define_common_targets(): name = "runtime" + aten_suffix, srcs = ["bundled_program.cpp"], exported_headers = ["bundled_program.h"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core/exec_aten/util:dim_order_util" + aten_suffix, "//executorch/devtools/bundled_program/schema:bundled_program_schema_fbs", diff --git a/devtools/etdump/data_sinks/targets.bzl b/devtools/etdump/data_sinks/targets.bzl index 6cf86a17fb2..8b0f162c59f 100644 --- a/devtools/etdump/data_sinks/targets.bzl +++ b/devtools/etdump/data_sinks/targets.bzl @@ -17,10 +17,7 @@ def define_data_sink_target(data_sink_name, aten_suffix): "//executorch/runtime/core/exec_aten:lib" + aten_suffix, ":data_sink_base" + aten_suffix, ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) def define_common_targets(): @@ -40,10 +37,7 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/core/exec_aten/util:scalar_type_util" + aten_suffix, ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) define_data_sink_target("buffer_data_sink", aten_suffix) diff --git a/devtools/etdump/targets.bzl b/devtools/etdump/targets.bzl index 04a449f3920..44c8c42c1b9 100644 --- a/devtools/etdump/targets.bzl +++ b/devtools/etdump/targets.bzl @@ -47,7 +47,7 @@ def define_common_targets(): """ runtime.export_file( name = ETDUMP_SCHEMA_FLATCC, - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) generate_schema_header_flatcc( @@ -73,7 +73,7 @@ def define_common_targets(): runtime.cxx_library( name = ETDUMP_STEM_FLATCC, srcs = [], - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], exported_headers = { ETDUMP_SCHEMA_FLATCC_BUILDER: ":{}[{}]".format(ETDUMP_GEN_RULE_NAME_FLATCC, ETDUMP_SCHEMA_FLATCC_BUILDER), ETDUMP_SCHEMA_FLATCC_READER: ":{}[{}]".format(ETDUMP_GEN_RULE_NAME_FLATCC, ETDUMP_SCHEMA_FLATCC_READER), @@ -116,10 +116,7 @@ def define_common_targets(): "fbsource//third-party/re2:re2", "//executorch/runtime/core:event_tracer" + aten_suffix, ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -145,8 +142,5 @@ def define_common_targets(): "//executorch/runtime/core:event_tracer" + aten_suffix, "//executorch/runtime/core/exec_aten/util:scalar_type_util" + aten_suffix, ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/devtools/visualization/TARGETS b/devtools/visualization/TARGETS index cb4e8b3cdc1..88a5ba77107 100644 --- a/devtools/visualization/TARGETS +++ b/devtools/visualization/TARGETS @@ -10,10 +10,7 @@ runtime.python_library( "__init__.py", "visualization_utils.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir:lib", diff --git a/examples/apple/coreml/llama/TARGETS b/examples/apple/coreml/llama/TARGETS index 87ad47fbf6d..eedb88774e0 100644 --- a/examples/apple/coreml/llama/TARGETS +++ b/examples/apple/coreml/llama/TARGETS @@ -10,10 +10,7 @@ runtime.python_library( ], _is_external_target = True, base_module = "executorch.examples.apple.coreml.llama", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/examples/models/llama:llama_transformer", @@ -27,10 +24,7 @@ runtime.python_library( ], _is_external_target = True, base_module = "executorch.examples.apple.coreml.llama", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", ], @@ -42,10 +36,7 @@ runtime.python_binary( "export.py", ], main_function = "executorch.examples.apple.coreml.llama.export.main", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/coremltools:coremltools", ":llama_transformer", diff --git a/examples/models/llama/TARGETS b/examples/models/llama/TARGETS index fe26b2f08e0..57179d8a160 100644 --- a/examples/models/llama/TARGETS +++ b/examples/models/llama/TARGETS @@ -16,10 +16,7 @@ runtime.python_library( ], _is_external_target = True, base_module = "executorch.examples.models.llama", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":transformer_modules", "//caffe2:torch", @@ -39,10 +36,7 @@ runtime.python_library( ], _is_external_target = True, base_module = "executorch.examples.models.llama", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -52,10 +46,7 @@ runtime.python_library( ], _is_external_target = True, base_module = "executorch.examples.models.llama", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":llama_transformer", "//caffe2:torch", @@ -116,10 +107,7 @@ runtime.command_alias( runtime.python_library( name = "source_transformation", - visibility = [ - "//executorch/examples/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], srcs = [ "source_transformation/apply_spin_quant_r1_r2.py", "source_transformation/attention.py", @@ -155,12 +143,7 @@ runtime.python_library( ], _is_external_target = True, base_module = "executorch.examples.models.llama", - visibility = [ - "//bento/...", - "//bento_kernels/...", - "//executorch/examples/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":hf_download", ":source_transformation", @@ -207,12 +190,7 @@ runtime.python_library( ], _is_external_target = True, base_module = "executorch.examples.models.llama", - visibility = [ - "//bento/...", - "//bento_kernels/...", - "//executorch/examples/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/tqdm:tqdm", "fbsource//third-party/pypi/datasets:datasets", diff --git a/examples/models/llama/runner/TARGETS b/examples/models/llama/runner/TARGETS index 34cdd62be70..4f532c162cc 100644 --- a/examples/models/llama/runner/TARGETS +++ b/examples/models/llama/runner/TARGETS @@ -16,12 +16,7 @@ runtime.python_library( ], _is_external_target = True, base_module = "executorch.examples.models.llama.runner", - visibility = [ - "//bento/...", - "//bento_kernels/...", - "//executorch/examples/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/examples/models/llama:export_library", ], diff --git a/examples/models/llama/runner/targets.bzl b/examples/models/llama/runner/targets.bzl index 9c0b7265159..f2020126acc 100644 --- a/examples/models/llama/runner/targets.bzl +++ b/examples/models/llama/runner/targets.bzl @@ -34,9 +34,7 @@ def define_common_targets(): preprocessor_flags = [ "-DUSE_ATEN_LIB", ] if aten else [], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], compiler_flags = [ "-Wno-missing-prototypes", ], @@ -64,9 +62,7 @@ def define_common_targets(): exported_headers = [ "static_attention_io_manager.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/executor:program", ] diff --git a/examples/models/llama/tokenizer/targets.bzl b/examples/models/llama/tokenizer/targets.bzl index 1354a44d1b9..3aa31443fd4 100644 --- a/examples/models/llama/tokenizer/targets.bzl +++ b/examples/models/llama/tokenizer/targets.bzl @@ -17,9 +17,7 @@ def define_common_targets(): exported_deps = [ "//pytorch/tokenizers:tiktoken", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( diff --git a/examples/portable/custom_ops/targets.bzl b/examples/portable/custom_ops/targets.bzl index 1935889db4c..4c49ee15d49 100644 --- a/examples/portable/custom_ops/targets.bzl +++ b/examples/portable/custom_ops/targets.bzl @@ -9,10 +9,7 @@ def define_common_targets(): """ runtime.export_file( name = "custom_ops.yaml", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # ~~~ START of custom ops 1 `my_ops::mul3` library definitions ~~~ @@ -22,10 +19,7 @@ def define_common_targets(): "my_ops::mul3.out", ], define_static_targets = True, - visibility = [ - "//executorch/codegen/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -34,10 +28,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) executorch_generated_lib( @@ -47,10 +38,7 @@ def define_common_targets(): ":custom_ops_1", ], custom_ops_yaml_target = ":custom_ops.yaml", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # ~~~ END of custom ops 1 `my_ops::mul3` library definitions ~~~ @@ -62,10 +50,7 @@ def define_common_targets(): "my_ops::mul4.out", ], define_static_targets = True, - visibility = [ - "//executorch/codegen/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -74,10 +59,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -89,10 +71,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes_aten", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], external_deps = ["libtorch"], # @lint-ignore BUCKLINT link_whole link_whole = True, @@ -120,9 +99,6 @@ def define_common_targets(): ":custom_ops_2", ], custom_ops_yaml_target = ":custom_ops.yaml", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # ~~~ END of custom ops 2 `my_ops::mul4` library definitions ~~~ diff --git a/examples/xnnpack/targets.bzl b/examples/xnnpack/targets.bzl index e710c478250..66db20b790b 100644 --- a/examples/xnnpack/targets.bzl +++ b/examples/xnnpack/targets.bzl @@ -46,9 +46,7 @@ def define_common_targets(): deps = [ ":xnnpack_aot_lib", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # executor_runner for XNNPACK Backend and portable kernels. diff --git a/exir/_serialize/TARGETS b/exir/_serialize/TARGETS index 51bad73ab5c..7208befb51e 100644 --- a/exir/_serialize/TARGETS +++ b/exir/_serialize/TARGETS @@ -44,23 +44,7 @@ runtime.python_library( # Currently serialization API should only be used in some dedicated targets, # to avoid ODR violation when linking with another Flatbuffers library. # Please ask before changing this. - visibility = [ - "//executorch/backends/...", - "//executorch/codegen/...", - "//executorch/devtools:lib", - "//executorch/devtools/bundled_program/serialize:lib", - "//executorch/devtools/bundled_program/tests/...", - "//executorch/devtools/experimental/...", - "//executorch/examples/async_exec:emit_program_lib", - "//executorch/exir/...", - "//executorch/exir/tests/...", - "//executorch/extension/...", - "//executorch/extension/pybindings/test:test", - "//executorch/extension/pybindings/test:test-library", - "//executorch/profiler/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/exir:schema", "//executorch/exir:tensor", diff --git a/exir/backend/TARGETS b/exir/backend/TARGETS index d656e44fbf1..fa33fa96428 100644 --- a/exir/backend/TARGETS +++ b/exir/backend/TARGETS @@ -16,11 +16,7 @@ runtime.python_library( srcs = [ "backend_api.py", ], - visibility = [ - "//executorch/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":backend_details", ":compile_spec_schema", @@ -35,11 +31,7 @@ runtime.python_library( srcs = [ "compile_spec_schema.py", ], - visibility = [ - "//executorch/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -47,11 +39,7 @@ runtime.python_library( srcs = [ "operator_support.py", ], - visibility = [ - "//executorch/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -59,11 +47,7 @@ runtime.python_library( srcs = [ "partitioner.py", ], - visibility = [ - "//executorch/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":compile_spec_schema", "//caffe2:torch", @@ -75,11 +59,7 @@ runtime.python_library( srcs = [ "backend_details.py", ], - visibility = [ - "//executorch/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":compile_spec_schema", ":partitioner", @@ -93,11 +73,7 @@ runtime.python_library( # it's supposed to be only used on server side and not for production on device. runtime.python_library( name = "backend_lib", - visibility = [ - "//executorch/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":backend_api", ":backend_details", @@ -111,12 +87,7 @@ runtime.python_library( srcs = [ "utils.py", ], - visibility = [ - "//executorch/...", - "//executorch/exir/backend/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "fbsource//third-party/pypi/pandas:pandas", "//caffe2:torch", diff --git a/exir/backend/canonical_partitioners/TARGETS b/exir/backend/canonical_partitioners/TARGETS index b8def26bbda..27b850dc9e1 100644 --- a/exir/backend/canonical_partitioners/TARGETS +++ b/exir/backend/canonical_partitioners/TARGETS @@ -9,12 +9,7 @@ runtime.python_library( "pattern_op_partitioner.py", "all_node_partitioner.py", ], - visibility = [ - "//executorch/...", - "//executorch/exir/backend/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir/backend:partitioner", @@ -27,12 +22,7 @@ runtime.python_library( srcs = [ "duplicate_constant_node_pass.py", ], - visibility = [ - "//executorch/...", - "//executorch/exir/backend/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir/backend:partitioner", @@ -44,12 +34,7 @@ runtime.python_library( srcs = [ "config_partitioner.py", ], - visibility = [ - "//executorch/...", - "//executorch/exir/backend/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir/backend:partitioner", @@ -61,12 +46,7 @@ runtime.python_library( srcs = [ "group_partitioner.py", ], - visibility = [ - "//executorch/...", - "//executorch/exir/backend/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir/backend:partitioner", diff --git a/export/TARGETS b/export/TARGETS index 9f6cb37950c..71be2259584 100644 --- a/export/TARGETS +++ b/export/TARGETS @@ -7,10 +7,7 @@ runtime.python_library( srcs = [ "recipe.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir/backend:backend_api", @@ -24,10 +21,7 @@ runtime.python_library( srcs = [ "export.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":recipe", ":stages", @@ -42,10 +36,7 @@ runtime.python_library( srcs = [ "stages.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":recipe", ":types", @@ -63,10 +54,7 @@ runtime.python_library( srcs = [ "__init__.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":export", ":recipe", @@ -82,10 +70,7 @@ runtime.python_library( srcs = [ "recipe_registry.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":recipe", ":recipe_provider" diff --git a/extension/android/jni/BUCK b/extension/android/jni/BUCK index 44e9856b1ad..1b3e63002f8 100644 --- a/extension/android/jni/BUCK +++ b/extension/android/jni/BUCK @@ -131,7 +131,7 @@ non_fbcode_target(_kind = runtime.cxx_library, deps = [ "//executorch/runtime/core:core", ], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.export_file( diff --git a/extension/aten_util/targets.bzl b/extension/aten_util/targets.bzl index f219d6253f2..027b258b7de 100644 --- a/extension/aten_util/targets.bzl +++ b/extension/aten_util/targets.bzl @@ -21,10 +21,7 @@ def define_common_targets(): "-Wno-global-constructors", "-Wno-unused-function", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/extension/kernel_util:kernel_util", "//executorch/extension/tensor:tensor", diff --git a/extension/data_loader/targets.bzl b/extension/data_loader/targets.bzl index 50e779b4bd8..442bc39f78a 100644 --- a/extension/data_loader/targets.bzl +++ b/extension/data_loader/targets.bzl @@ -11,14 +11,7 @@ def define_common_targets(): name = "buffer_data_loader", srcs = [], exported_headers = ["buffer_data_loader.h"], - visibility = [ - "//executorch/exir/backend/test/...", - "//executorch/runtime/executor/test/...", - "//executorch/extension/pybindings/...", - "//executorch/test/...", - "//executorch/extension/data_loader/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", ], @@ -28,10 +21,7 @@ def define_common_targets(): name = "shared_ptr_data_loader", srcs = [], exported_headers = ["shared_ptr_data_loader.h"], - visibility = [ - "@EXECUTORCH_CLIENTS", - "//executorch/extension/data_loader/test/...", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", ], @@ -41,12 +31,7 @@ def define_common_targets(): name = "file_data_loader", srcs = ["file_data_loader.cpp"], exported_headers = ["file_data_loader.h"], - visibility = [ - "//executorch/test/...", - "//executorch/runtime/executor/test/...", - "//executorch/extension/data_loader/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", ], @@ -56,12 +41,7 @@ def define_common_targets(): name = "file_descriptor_data_loader", srcs = ["file_descriptor_data_loader.cpp"], exported_headers = ["file_descriptor_data_loader.h"], - visibility = [ - "//executorch/test/...", - "//executorch/runtime/executor/test/...", - "//executorch/extension/data_loader/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", ], @@ -83,13 +63,7 @@ def define_common_targets(): "mman.h", "mmap_data_loader.h" ], - visibility = [ - "//executorch/test/...", - "//executorch/extension/pybindings/...", - "//executorch/runtime/executor/test/...", - "//executorch/extension/data_loader/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", ], diff --git a/extension/evalue_util/targets.bzl b/extension/evalue_util/targets.bzl index 47934eb78af..faee0fd62a7 100644 --- a/extension/evalue_util/targets.bzl +++ b/extension/evalue_util/targets.bzl @@ -14,7 +14,7 @@ def define_common_targets(): name = "print_evalue" + aten_suffix, srcs = ["print_evalue.cpp"], exported_headers = ["print_evalue.h"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:evalue" + aten_suffix, ], diff --git a/extension/export_util/TARGETS b/extension/export_util/TARGETS index 0ec85fda632..84670129bba 100644 --- a/extension/export_util/TARGETS +++ b/extension/export_util/TARGETS @@ -8,12 +8,7 @@ runtime.python_library( "utils.py", ], _is_external_target = True, - visibility = [ - "//bento/...", - "//bento_kernels/...", - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir:lib", diff --git a/extension/flat_tensor/serialize/TARGETS b/extension/flat_tensor/serialize/TARGETS index d02da3b785d..c33004d59aa 100644 --- a/extension/flat_tensor/serialize/TARGETS +++ b/extension/flat_tensor/serialize/TARGETS @@ -27,10 +27,7 @@ runtime.python_library( "flat_tensor.fbs", "scalar_type.fbs", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":schema", "//executorch/exir/_serialize:lib", diff --git a/extension/flat_tensor/serialize/targets.bzl b/extension/flat_tensor/serialize/targets.bzl index 717418ec7e6..a6cbd1d9def 100644 --- a/extension/flat_tensor/serialize/targets.bzl +++ b/extension/flat_tensor/serialize/targets.bzl @@ -54,9 +54,6 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", ], exported_headers = ["serialize.h"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_external_deps = ["flatbuffers-api"], ) diff --git a/extension/flat_tensor/targets.bzl b/extension/flat_tensor/targets.bzl index f91e28a2268..2e41529993b 100644 --- a/extension/flat_tensor/targets.bzl +++ b/extension/flat_tensor/targets.bzl @@ -20,7 +20,5 @@ def define_common_targets(): "//executorch/extension/flat_tensor/serialize:flat_tensor_header", "//executorch/extension/flat_tensor/serialize:generated_headers", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/extension/kernel_util/targets.bzl b/extension/kernel_util/targets.bzl index 81d4da10d15..cd78fc93179 100644 --- a/extension/kernel_util/targets.bzl +++ b/extension/kernel_util/targets.bzl @@ -15,10 +15,7 @@ def define_common_targets(): "meta_programming.h", "type_list.h", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", "//executorch/runtime/core:evalue", diff --git a/extension/llm/custom_ops/spinquant/targets.bzl b/extension/llm/custom_ops/spinquant/targets.bzl index e87af3b80d8..e2a301c5a5a 100644 --- a/extension/llm/custom_ops/spinquant/targets.bzl +++ b/extension/llm/custom_ops/spinquant/targets.bzl @@ -18,5 +18,5 @@ def define_common_targets(): exported_deps = [ "//executorch/extension/llm/custom_ops/spinquant/third-party/FFHT:fht", ], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) diff --git a/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl b/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl index 9ba0ae32fb4..48f14940079 100644 --- a/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl +++ b/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl @@ -10,7 +10,7 @@ def define_common_targets(): name = "dumb_fht", srcs = ["dumb_fht.c"], exported_headers = ["dumb_fht.h"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -21,7 +21,7 @@ def define_common_targets(): "ovr_config//cpu:x86_64": ["fht_avx.c"], }), exported_headers = ["fht.h"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_binary( diff --git a/extension/llm/custom_ops/targets.bzl b/extension/llm/custom_ops/targets.bzl index 6c31b24171c..6746d7ab877 100644 --- a/extension/llm/custom_ops/targets.bzl +++ b/extension/llm/custom_ops/targets.bzl @@ -60,11 +60,7 @@ def define_common_targets(): "DEFAULT": [], "ovr_config//cpu:arm64": ["-march=armv8.2-a+dotprod"], }), - visibility = [ - "//executorch/...", - "//executorch/extension/llm/custom_ops/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], # @lint-ignore BUCKLINT link_whole link_whole = True, force_static = True, @@ -80,10 +76,7 @@ def define_common_targets(): ], headers = ["op_tile_crop.h"], compiler_flags = ["-Wno-global-constructors"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], external_deps = [ "libtorch", ], @@ -98,10 +91,7 @@ def define_common_targets(): srcs = [ "custom_ops.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", ], @@ -141,10 +131,7 @@ def define_common_targets(): srcs = [ "preprocess_custom_ops.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", ], @@ -155,10 +142,7 @@ def define_common_targets(): srcs = [ "model_sharding.py", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", ], @@ -173,10 +157,7 @@ def define_common_targets(): "//executorch/extension/kernel_util:kernel_util", ], compiler_flags = ["-Wno-missing-prototypes", "-Wno-global-constructors"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], # @lint-ignore BUCKLINT link_whole link_whole = True, force_static = True, diff --git a/extension/llm/export/config/targets.bzl b/extension/llm/export/config/targets.bzl index 4135b336fbd..e8318eadaaa 100644 --- a/extension/llm/export/config/targets.bzl +++ b/extension/llm/export/config/targets.bzl @@ -8,8 +8,5 @@ def define_common_targets(): ], _is_external_target = True, base_module = "executorch.extension.llm.export.config", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) \ No newline at end of file diff --git a/extension/llm/runner/io_manager/targets.bzl b/extension/llm/runner/io_manager/targets.bzl index 5b891b24376..fe7fe9d56ae 100644 --- a/extension/llm/runner/io_manager/targets.bzl +++ b/extension/llm/runner/io_manager/targets.bzl @@ -15,7 +15,5 @@ def define_common_targets(): "//executorch/extension/tensor:tensor" + aten_suffix, "//executorch/extension/module:module" + aten_suffix, ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/extension/llm/runner/targets.bzl b/extension/llm/runner/targets.bzl index e001e8fc154..2c9000d0137 100644 --- a/extension/llm/runner/targets.bzl +++ b/extension/llm/runner/targets.bzl @@ -6,9 +6,7 @@ def define_common_targets(): exported_headers = [ "irunner.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -16,9 +14,7 @@ def define_common_targets(): exported_headers = [ "constants.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) for aten in get_aten_mode_options(): @@ -30,9 +26,7 @@ def define_common_targets(): "stats.h", "util.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":constants", "//executorch/extension/module:module" + aten_suffix, @@ -44,9 +38,7 @@ def define_common_targets(): name = "text_decoder_runner" + aten_suffix, exported_headers = ["text_decoder_runner.h"], srcs = ["text_decoder_runner.cpp"], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":stats" + aten_suffix, "//executorch/kernels/portable/cpu/util:arange_util" + aten_suffix, @@ -61,9 +53,7 @@ def define_common_targets(): name = "text_prefiller" + aten_suffix, exported_headers = ["text_prefiller.h"], srcs = ["text_prefiller.cpp"], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":text_decoder_runner" + aten_suffix, "//pytorch/tokenizers:headers", @@ -75,9 +65,7 @@ def define_common_targets(): runtime.cxx_library( name = "text_token_generator" + aten_suffix, exported_headers = ["text_token_generator.h"], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":text_decoder_runner" + aten_suffix, "//pytorch/tokenizers:headers", @@ -89,9 +77,7 @@ def define_common_targets(): runtime.cxx_library( name = "image_prefiller" + aten_suffix, exported_headers = ["image_prefiller.h", "image.h"], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":constants", "//executorch/extension/module:module" + aten_suffix, @@ -134,9 +120,7 @@ def define_common_targets(): "llm_runner_helper.cpp", "multimodal_runner.cpp", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], compiler_flags = [ "-Wno-missing-prototypes", ], diff --git a/extension/llm/sampler/targets.bzl b/extension/llm/sampler/targets.bzl index b76bfcd6133..42551e248e5 100644 --- a/extension/llm/sampler/targets.bzl +++ b/extension/llm/sampler/targets.bzl @@ -16,9 +16,7 @@ def define_common_targets(): srcs = [ "sampler.cpp", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], external_deps = [ "libtorch", ] if aten else [], diff --git a/extension/memory_allocator/targets.bzl b/extension/memory_allocator/targets.bzl index 82976dfefe8..4453d75f600 100644 --- a/extension/memory_allocator/targets.bzl +++ b/extension/memory_allocator/targets.bzl @@ -16,10 +16,7 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/core:memory_allocator", ], - visibility = [ - "//executorch/extension/memory_allocator/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -34,8 +31,5 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/core:memory_allocator", ], - visibility = [ - "//executorch/extension/memory_allocator/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/extension/module/targets.bzl b/extension/module/targets.bzl index 0db909ce053..6d60429bc51 100644 --- a/extension/module/targets.bzl +++ b/extension/module/targets.bzl @@ -18,9 +18,7 @@ def define_common_targets(): exported_headers = [ "module.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/extension/memory_allocator:malloc_memory_allocator", "//executorch/extension/data_loader:file_data_loader", @@ -41,9 +39,7 @@ def define_common_targets(): exported_headers = [ "bundled_module.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/extension/data_loader:buffer_data_loader", "//executorch/extension/data_loader:file_data_loader", diff --git a/extension/named_data_map/targets.bzl b/extension/named_data_map/targets.bzl index 0c2b2fa6d5c..3fe3bc592e6 100644 --- a/extension/named_data_map/targets.bzl +++ b/extension/named_data_map/targets.bzl @@ -11,9 +11,7 @@ def define_common_targets(): exported_headers = [ "merged_data_map.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core:named_data_map" + aten_suffix, "//executorch/runtime/core:core", diff --git a/extension/parallel/targets.bzl b/extension/parallel/targets.bzl index 3a2d6f354ef..ada6b55096e 100644 --- a/extension/parallel/targets.bzl +++ b/extension/parallel/targets.bzl @@ -12,10 +12,7 @@ def define_common_targets(): exported_headers = [ "thread_parallel.h", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/extension/threadpool:threadpool", ], diff --git a/extension/pybindings/TARGETS b/extension/pybindings/TARGETS index 2e77127bf56..18323a07bff 100644 --- a/extension/pybindings/TARGETS +++ b/extension/pybindings/TARGETS @@ -65,11 +65,7 @@ executorch_pybindings( runtime.python_library( name = "portable_lib", srcs = ["portable_lib.py"], - visibility = [ - "//executorch/exir/...", - "//executorch/runtime/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ ":_portable_lib", "//executorch/exir:_warnings", diff --git a/extension/pytree/aten_util/targets.bzl b/extension/pytree/aten_util/targets.bzl index 5ba7e90596b..64462d339e8 100644 --- a/extension/pytree/aten_util/targets.bzl +++ b/extension/pytree/aten_util/targets.bzl @@ -11,10 +11,7 @@ def define_common_targets(): name = "ivalue_util", srcs = ["ivalue_util.cpp"], exported_headers = ["ivalue_util.h"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/extension/pytree:pytree", "//executorch/runtime/platform:platform", diff --git a/extension/pytree/targets.bzl b/extension/pytree/targets.bzl index 00d1e66717d..6ef3b1b37c2 100644 --- a/extension/pytree/targets.bzl +++ b/extension/pytree/targets.bzl @@ -14,8 +14,5 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/core:core", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/extension/runner_util/targets.bzl b/extension/runner_util/targets.bzl index 75b9e1ef905..a9c48fb4ca0 100644 --- a/extension/runner_util/targets.bzl +++ b/extension/runner_util/targets.bzl @@ -17,10 +17,7 @@ def define_common_targets(): "inputs{}.cpp".format("_aten" if aten_mode else "_portable"), ], exported_headers = ["inputs.h"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core/exec_aten:lib" + aten_suffix, "//executorch/runtime/executor:program_no_prim_ops" + aten_suffix, diff --git a/extension/tensor/targets.bzl b/extension/tensor/targets.bzl index bf1485aaba5..c8bf2847dcf 100644 --- a/extension/tensor/targets.bzl +++ b/extension/tensor/targets.bzl @@ -22,9 +22,7 @@ def define_common_targets(): "tensor_ptr.h", "tensor_ptr_maker.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core/exec_aten/util:dim_order_util" + aten_suffix, "//executorch/runtime/core/exec_aten/util:tensor_util" + aten_suffix, diff --git a/extension/threadpool/targets.bzl b/extension/threadpool/targets.bzl index 1889cb650ad..7bbdf1169c7 100644 --- a/extension/threadpool/targets.bzl +++ b/extension/threadpool/targets.bzl @@ -36,13 +36,7 @@ def define_common_targets(): exported_preprocessor_flags = [ "-DET_USE_THREADPOOL", ], - visibility = [ - "//executorch/...", - "//executorch/backends/...", - "//executorch/runtime/backend/...", - "//executorch/extension/threadpool/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -71,10 +65,7 @@ def define_common_targets(): # If we don't know what it is, disable threadpool out of caution. "DEFAULT": ["//executorch/runtime/kernel:thread_parallel_interface"], })), - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -92,11 +83,5 @@ def define_common_targets(): third_party_dep("pthreadpool"), third_party_dep("cpuinfo"), ], - visibility = [ - "//executorch/...", - "//executorch/backends/...", - "//executorch/runtime/backend/...", - "//executorch/extension/threadpool/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/extension/training/module/targets.bzl b/extension/training/module/targets.bzl index 0ae00aa447d..9214259390d 100644 --- a/extension/training/module/targets.bzl +++ b/extension/training/module/targets.bzl @@ -15,9 +15,7 @@ def define_common_targets(): exported_headers = [ "state_dict_util.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:named_data_map", "//executorch/extension/tensor:tensor", @@ -36,9 +34,7 @@ def define_common_targets(): exported_headers = [ "training_module.h", ], - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/extension/module:module" + aten_suffix, "//executorch/runtime/core:evalue" + aten_suffix, diff --git a/extension/training/optimizer/targets.bzl b/extension/training/optimizer/targets.bzl index fb33f41f1ca..c99ae2a360d 100644 --- a/extension/training/optimizer/targets.bzl +++ b/extension/training/optimizer/targets.bzl @@ -36,7 +36,5 @@ def define_common_targets(): "//executorch/runtime/core:core", "//executorch/runtime/core/exec_aten:lib" + aten_suffix, ], # + kernel_deps, - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/kernels/aten/targets.bzl b/kernels/aten/targets.bzl index 2e007a16d7e..7d6d098793c 100644 --- a/kernels/aten/targets.bzl +++ b/kernels/aten/targets.bzl @@ -10,18 +10,12 @@ def define_common_targets(): runtime.export_file( name = "functions.yaml", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.export_file( name = "edge_dialect_aten_op.yaml", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) et_operator_library( @@ -33,10 +27,7 @@ def define_common_targets(): runtime.cxx_library( name = "operators_edge_dialect_aten", srcs = [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/kernels/aten/cpu:cpu", ], @@ -61,8 +52,5 @@ def define_common_targets(): custom_ops_yaml_target = "//executorch/kernels/aten:edge_dialect_aten_op.yaml", define_static_targets = True, custom_ops_requires_aot_registration = False, - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/kernels/optimized/cpu/targets.bzl b/kernels/optimized/cpu/targets.bzl index b5fbff3021e..78bbecd9e2c 100644 --- a/kernels/optimized/cpu/targets.bzl +++ b/kernels/optimized/cpu/targets.bzl @@ -25,7 +25,7 @@ def define_common_targets(): name = "add_sub_impl", srcs = [], exported_headers = ["op_add_sub_impl.h"], - visibility = ["//executorch/kernels/optimized/cpu/...", "@EXECUTORCH_CLIENTS",], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", "//executorch/kernels/portable/cpu/util:broadcast_indexes_range", @@ -39,7 +39,7 @@ def define_common_targets(): name = "fft_utils", srcs = [], exported_headers = ["fft_utils.h"], - visibility = ["//executorch/kernels/optimized/cpu/...", "@EXECUTORCH_CLIENTS",], + visibility = ["PUBLIC"], exported_deps = [] if runtime.is_oss else ["fbsource//third-party/pocket_fft:pocketfft"], ) @@ -47,7 +47,7 @@ def define_common_targets(): name = "binary_ops", srcs = ["binary_ops.cpp"], exported_headers = ["binary_ops.h"], - visibility = ["//executorch/kernels/optimized/cpu/...", "@EXECUTORCH_CLIENTS",], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/kernel:kernel_includes", @@ -68,7 +68,7 @@ def define_common_targets(): name = "moments_utils", srcs = [], exported_headers = ["moments_utils.h"], - visibility = ["//executorch/kernels/optimized/...", "@EXECUTORCH_CLIENTS",], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core/portable_type/c10/c10:aten_headers_for_executorch", "//executorch/kernels/optimized:libvec", @@ -80,11 +80,11 @@ def define_common_targets(): runtime.filegroup( name = "optimized_source_files", srcs = native.glob(["*.cpp"]), - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.filegroup( name = "optimized_header_files", srcs = native.glob(["*.h"]), - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) diff --git a/kernels/optimized/lib_defs.bzl b/kernels/optimized/lib_defs.bzl index 7cb18009687..928fc44635d 100644 --- a/kernels/optimized/lib_defs.bzl +++ b/kernels/optimized/lib_defs.bzl @@ -127,10 +127,7 @@ def define_libs(is_fbcode=False): "vec/**/*.h", ]), header_namespace = "executorch/kernels/optimized", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core/portable_type/c10/c10:aten_headers_for_executorch", ], @@ -157,10 +154,7 @@ def define_libs(is_fbcode=False): "utils/**/*.h", ]), header_namespace = "executorch/kernels/optimized", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ # Needed to access the ET_INLINE macro "//executorch/runtime/platform:compiler", @@ -222,10 +216,7 @@ def define_libs(is_fbcode=False): "DEFAULT": ["-Os"], }), header_namespace = "executorch/kernels/optimized", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], preprocessor_flags = get_preprocessor_flags(), fbobjc_exported_preprocessor_flags = [ "-DET_BUILD_WITH_BLAS", diff --git a/kernels/optimized/targets.bzl b/kernels/optimized/targets.bzl index c655cb149a3..7c4d6a5246a 100644 --- a/kernels/optimized/targets.bzl +++ b/kernels/optimized/targets.bzl @@ -13,19 +13,13 @@ def define_common_targets(is_fbcode=False): runtime.export_file( name = "optimized.yaml", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( name = "optimized_operators", srcs = [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/kernels/optimized/cpu:cpu_optimized", ], @@ -34,9 +28,7 @@ def define_common_targets(is_fbcode=False): et_operator_library( name = "optimized_oplist", ops_schema_yaml_target = ":optimized.yaml", - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # Used mainly for operator testing. In practice, a generated lib specific @@ -50,8 +42,5 @@ def define_common_targets(is_fbcode=False): ], functions_yaml_target = ":optimized.yaml", define_static_targets = True, - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/kernels/portable/cpu/pattern/targets.bzl b/kernels/portable/cpu/pattern/targets.bzl index 636c5d2127b..5df8fde3738 100644 --- a/kernels/portable/cpu/pattern/targets.bzl +++ b/kernels/portable/cpu/pattern/targets.bzl @@ -18,7 +18,7 @@ def define_common_targets(): "//executorch/kernels/portable/cpu/pattern:comparison_op", "//executorch/kernels/portable/cpu/pattern:logical_op" ], - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( diff --git a/kernels/portable/cpu/targets.bzl b/kernels/portable/cpu/targets.bzl index 83e8219402f..7df77570450 100644 --- a/kernels/portable/cpu/targets.bzl +++ b/kernels/portable/cpu/targets.bzl @@ -47,11 +47,7 @@ def define_common_targets(): ], srcs = [], exported_headers = ["vec_ops.h"], - visibility = [ - "//executorch/kernels/portable/...", - "//executorch/kernels/quantized/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # Only for use by targets in this directory. Defines constants like M_PI @@ -62,9 +58,7 @@ def define_common_targets(): exported_headers = [ "math_constants.h", ], - visibility = [ - "//executorch/kernels/portable/...", "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # Only for use by targets in this directory. @@ -72,13 +66,7 @@ def define_common_targets(): name = "scalar_utils", srcs = [], exported_headers = ["scalar_utils.h", "selective_build.h"], - visibility = [ - "//executorch/kernels/fb/...", - "//executorch/kernels/optimized/cpu/...", - "//executorch/kernels/portable/cpu/...", - "//executorch/kernels/portable/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core/exec_aten/util:scalar_type_util", ], @@ -91,11 +79,11 @@ def define_common_targets(): runtime.filegroup( name = "portable_source_files", srcs = native.glob(["*.cpp"]), - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.filegroup( name = "portable_header_files", srcs = native.glob(["*.h"]), - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) diff --git a/kernels/portable/cpu/util/targets.bzl b/kernels/portable/cpu/util/targets.bzl index 9c7f8d27111..1fd1e61ee8d 100644 --- a/kernels/portable/cpu/util/targets.bzl +++ b/kernels/portable/cpu/util/targets.bzl @@ -38,7 +38,7 @@ def define_common_targets(): "//executorch/kernels/portable/cpu/util:vectorized_math", "//executorch/kernels/portable/cpu/util:grid_sampler_2d_util", ], - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -88,7 +88,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten/util:tensor_shape_to_c_string", "//executorch/runtime/core/exec_aten/util:tensor_util", ], - visibility = ["//executorch/kernels/portable/cpu/...", "//executorch/kernels/optimized/cpu/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -101,7 +101,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = ["//executorch/kernels/portable/cpu/...", "//executorch/kernels/optimized/cpu/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -124,7 +124,7 @@ def define_common_targets(): deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = ["//executorch/kernels/portable/cpu/...", "//executorch/kernels/optimized/cpu/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -139,7 +139,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten/util:tensor_shape_to_c_string", "//executorch/runtime/kernel:kernel_includes", ], - visibility = ["//executorch/kernels/portable/cpu/...", "//executorch/kernels/optimized/cpu/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -262,7 +262,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten/util:tensor_util", ":broadcast_util", ], - visibility = ["//executorch/kernels/portable/cpu/...", "//executorch/kernels/quantized/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -308,7 +308,7 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/kernel:kernel_includes", ], - visibility = ["//executorch/kernels/portable/cpu/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -328,10 +328,7 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten:lib", "//executorch/runtime/core/exec_aten/util:tensor_dimension_limit", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -369,12 +366,7 @@ def define_common_targets(): "//executorch/extension/threadpool:threadpool", ], exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [], - visibility = [ - "//executorch/extension/llm/custom_ops/...", - "//executorch/kernels/portable/cpu/...", - "//executorch/kernels/quantized/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( diff --git a/kernels/portable/targets.bzl b/kernels/portable/targets.bzl index 759e5c96ae8..2c6e0b5c35f 100644 --- a/kernels/portable/targets.bzl +++ b/kernels/portable/targets.bzl @@ -11,10 +11,7 @@ def define_common_targets(): runtime.cxx_library( name = "operators", srcs = [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/kernels/portable/cpu:cpu", ], @@ -24,10 +21,7 @@ def define_common_targets(): runtime.cxx_library( name = "operators_aten", srcs = [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/kernels/portable/cpu:cpu_aten", ], @@ -35,48 +29,33 @@ def define_common_targets(): runtime.export_file( name = "functions.yaml", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.export_file( name = "custom_ops.yaml", - visibility = [ - "//executorch/codegen/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) et_operator_library( name = "executorch_all_ops", include_all_operators = True, define_static_targets = True, - visibility = [ - "//executorch/codegen/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) et_operator_library( name = "executorch_aten_ops", ops_schema_yaml_target = "//executorch/kernels/portable:functions.yaml", define_static_targets = True, - visibility = [ - "//executorch/codegen/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) et_operator_library( name = "executorch_custom_ops", ops_schema_yaml_target = "//executorch/kernels/portable:custom_ops.yaml", define_static_targets = True, - visibility = [ - "//executorch/codegen/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) generated_lib_common_args = { @@ -84,10 +63,7 @@ def define_common_targets(): # size_test expects _static targets to be available for these libraries. "define_static_targets": True, "functions_yaml_target": "//executorch/kernels/portable:functions.yaml", - "visibility": [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + "visibility": ["PUBLIC"], } executorch_generated_lib( @@ -113,9 +89,6 @@ def define_common_targets(): ], custom_ops_yaml_target = "//executorch/kernels/portable:custom_ops.yaml", aten_mode = True, - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], define_static_targets = True, ) diff --git a/kernels/portable/test/TARGETS b/kernels/portable/test/TARGETS index b659d6c093b..44c5697729e 100644 --- a/kernels/portable/test/TARGETS +++ b/kernels/portable/test/TARGETS @@ -13,10 +13,7 @@ runtime.cxx_library( srcs = [ "register_ops_aot_for_test.cpp", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/extension/aten_util:aten_bridge", "//executorch/kernels/portable/cpu:op_grid_sampler_2d", diff --git a/kernels/prim_ops/targets.bzl b/kernels/prim_ops/targets.bzl index eea66c1afa7..1750eb5c34c 100644 --- a/kernels/prim_ops/targets.bzl +++ b/kernels/prim_ops/targets.bzl @@ -11,13 +11,13 @@ def define_common_targets(): runtime.filegroup( name = "prim_ops_sources", srcs = ["register_prim_ops.cpp"], - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.filegroup( name = "selective_build_prim_ops.h", srcs = ["selective_build_prim_ops.h"], - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) for aten_mode in get_aten_mode_options(): @@ -28,10 +28,7 @@ def define_common_targets(): srcs = ["et_copy_index.cpp"], # To allow for selective prim ops to depend on this library. # Used by selective_build.bzl - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_headers = ["et_copy_index.h"], deps = [ "//executorch/runtime/kernel:kernel_includes" + aten_suffix, @@ -48,10 +45,7 @@ def define_common_targets(): srcs = ["et_view.cpp"], # To allow for selective prim ops to depend on this library. # Used by selective_build.bzl - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_headers = ["et_view.h"], deps = [ "//executorch/runtime/kernel:kernel_includes" + aten_suffix, @@ -66,10 +60,7 @@ def define_common_targets(): runtime.cxx_library( name = "prim_ops_registry" + aten_suffix, srcs = ["register_prim_ops.cpp"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], # @lint-ignore BUCKLINT link_whole, need this to register prim ops. link_whole = True, # prim ops are registered through a global table so the ctor needs to be allowed diff --git a/kernels/quantized/targets.bzl b/kernels/quantized/targets.bzl index 3448fd9c603..86fe81e2d58 100644 --- a/kernels/quantized/targets.bzl +++ b/kernels/quantized/targets.bzl @@ -4,9 +4,7 @@ load("@fbsource//xplat/executorch/codegen:codegen.bzl", "et_operator_library", " def define_common_targets(): runtime.export_file( name = "quantized.yaml", - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # Excluding embedding_byte ops because we choose to define them @@ -35,7 +33,7 @@ def define_common_targets(): exir_custom_ops_aot_lib( name = "custom_ops_generated_lib", yaml_target = ":quantized.yaml", - visibility = ["//executorch/...", "@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], kernels = [":quantized_operators_aten"], deps = [ ":quantized_ops_need_aot_registration", @@ -47,10 +45,7 @@ def define_common_targets(): exir_custom_ops_aot_lib( name = "aot_lib", yaml_target = ":quantized.yaml", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], kernels = [":quantized_operators_aten"], deps = [ ":quantized_ops_need_aot_registration", @@ -61,10 +56,7 @@ def define_common_targets(): name = "all_quantized_ops", ops_schema_yaml_target = ":quantized.yaml", define_static_targets = True, - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # On Windows we can only compile these two ops currently, so adding a @@ -87,10 +79,7 @@ def define_common_targets(): runtime.cxx_library( name = "quantized_operators" + aten_suffix, srcs = [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/kernels/quantized/cpu:quantized_cpu" + aten_suffix, ], @@ -110,10 +99,7 @@ def define_common_targets(): custom_ops_requires_aot_registration = False, aten_mode = aten_mode, support_exceptions = support_exceptions, - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], define_static_targets = True, ) @@ -131,10 +117,7 @@ def define_common_targets(): ":q_dq_ops", ], support_exceptions = support_exceptions, - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.python_library( @@ -143,8 +126,5 @@ def define_common_targets(): deps = [ "//caffe2:torch", ], - visibility = [ - "//executorch/kernels/quantized/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/kernels/quantized/test/TARGETS b/kernels/quantized/test/TARGETS index a820e3da3fa..16cf19a6bdd 100644 --- a/kernels/quantized/test/TARGETS +++ b/kernels/quantized/test/TARGETS @@ -25,10 +25,7 @@ runtime.cxx_library( srcs = [ "quantized_ops_aot_register.cpp", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/extension/aten_util:aten_bridge", "//executorch/kernels/quantized/cpu:op_dequantize", diff --git a/kernels/test/custom_kernel_example/targets.bzl b/kernels/test/custom_kernel_example/targets.bzl index 767fabcbac8..8f038b5cda3 100644 --- a/kernels/test/custom_kernel_example/targets.bzl +++ b/kernels/test/custom_kernel_example/targets.bzl @@ -26,10 +26,7 @@ def define_common_targets(): runtime.cxx_library( name = "my_operators", srcs = [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = all_op_targets, ) diff --git a/kernels/test/targets.bzl b/kernels/test/targets.bzl index bc949e0dfdb..ad36c81c63e 100644 --- a/kernels/test/targets.bzl +++ b/kernels/test/targets.bzl @@ -24,10 +24,7 @@ def define_common_targets(): exported_headers=[ "TestUtil.h", ], - visibility = [ - "//executorch/kernels/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_kernel else [], exported_deps = [ "//executorch/runtime/core:core", @@ -53,10 +50,7 @@ def define_common_targets(): "ScalarOverflowTestMacros.h", "UnaryUfuncRealHBBF16ToFloatHBF16Test.h", ], - visibility = [ - "//executorch/kernels/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_kernel else [], exported_deps = [ ":supported_features_header", @@ -151,10 +145,7 @@ def define_common_targets(): runtime.filegroup( name = "test_srcs", srcs = TEST_SRCS, - visibility = [ - "//executorch/kernels/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.genrule( @@ -163,10 +154,7 @@ def define_common_targets(): cmd = "cp $(location :test_srcs)/* $OUT", outs = {f: [f] for f in TEST_SRCS}, default_outs = ["."], - visibility = [ - "//executorch/kernels/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) codegen_function_header_wrapper("executorch/kernels/aten", "aten") diff --git a/profiler/TARGETS b/profiler/TARGETS index 10291c1536c..28d736df511 100644 --- a/profiler/TARGETS +++ b/profiler/TARGETS @@ -12,7 +12,7 @@ runtime.python_library( "profiler_results_cli.py", ], base_module = "executorch.profiler", - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], external_deps = ["prettytable"], ) diff --git a/runtime/TARGETS b/runtime/TARGETS index 7448523f5ff..9f8f1b9783a 100644 --- a/runtime/TARGETS +++ b/runtime/TARGETS @@ -8,8 +8,5 @@ runtime.python_library( deps = [ "//executorch/extension/pybindings:portable_lib", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/runtime/backend/targets.bzl b/runtime/backend/targets.bzl index 1d1f95c6c97..606ae324e37 100644 --- a/runtime/backend/targets.bzl +++ b/runtime/backend/targets.bzl @@ -22,10 +22,7 @@ def define_common_targets(): "interface.h", ], preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", "//executorch/runtime/core:evalue" + aten_suffix, diff --git a/runtime/core/exec_aten/targets.bzl b/runtime/core/exec_aten/targets.bzl index 9114be639c0..df4a87ef033 100644 --- a/runtime/core/exec_aten/targets.bzl +++ b/runtime/core/exec_aten/targets.bzl @@ -15,10 +15,7 @@ def define_common_targets(): name = "lib" + aten_suffix, exported_headers = ["exec_aten.h"], exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = ["//executorch/runtime/core:tensor_shape_dynamism"] + ([] if aten_mode else ["//executorch/runtime/core/portable_type:portable_type"]), exported_external_deps = ["libtorch"] if aten_mode else [], ) diff --git a/runtime/core/exec_aten/testing_util/targets.bzl b/runtime/core/exec_aten/testing_util/targets.bzl index e5ebdc8788a..fa259b41f84 100644 --- a/runtime/core/exec_aten/testing_util/targets.bzl +++ b/runtime/core/exec_aten/testing_util/targets.bzl @@ -16,26 +16,7 @@ def define_common_targets(): "tensor_util.h", "tensor_factory.h", ], - visibility = [ - # Be strict with the visibility so that operator implementations - # under //executorch/kernels/... can't depend on this test-only - # target. It's ok to add any //executorch/*/test/... path to this - # list. - "//executorch/runtime/core/exec_aten/util/test/...", - "//executorch/runtime/core/exec_aten/testing_util/test/...", - "//executorch/runtime/core/portable_type/test/...", - "//executorch/kernels/prim_ops/test/...", - "//executorch/kernels/portable/test/...", - "//executorch/kernels/portable/cpu/util/test/...", - "//executorch/kernels/quantized/test/...", - "//executorch/kernels/optimized/test/...", - "//executorch/kernels/test/...", - "//executorch/kernels/fb/custom_ops/...", - "//executorch/runtime/core/test/...", - "//executorch/test/...", - "//executorch/extension/kernel_util/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], compiler_flags = ["-Wno-unneeded-internal-declaration"], exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [], exported_deps = [ diff --git a/runtime/core/exec_aten/util/targets.bzl b/runtime/core/exec_aten/util/targets.bzl index 9ec2310250c..ffdfa4f1040 100644 --- a/runtime/core/exec_aten/util/targets.bzl +++ b/runtime/core/exec_aten/util/targets.bzl @@ -23,10 +23,7 @@ def define_common_targets(): exported_headers = [ "scalar_type_util.h", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_preprocessor_flags = exported_preprocessor_flags_, exported_deps = exported_deps_, exported_external_deps = ["libtorch"] if aten_mode else [], @@ -42,10 +39,7 @@ def define_common_targets(): "//executorch/runtime/core:core", "//executorch/runtime/core/portable_type/c10/c10:c10", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [], ) @@ -55,10 +49,7 @@ def define_common_targets(): exported_headers = [ "tensor_util.h", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_preprocessor_flags = ["-DUSE_ATEN_LIB"] if aten_mode else [], exported_deps = [ ":tensor_dimension_limit", @@ -84,17 +75,11 @@ def define_common_targets(): "//executorch/runtime/core/exec_aten/util:tensor_dimension_limit", ], exported_headers = ["tensor_shape_to_c_string.h"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( name = "tensor_dimension_limit", exported_headers = ["tensor_dimension_limit.h"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/runtime/core/portable_type/c10/c10/targets.bzl b/runtime/core/portable_type/c10/c10/targets.bzl index 6b61f45d7d4..33a558085b7 100644 --- a/runtime/core/portable_type/c10/c10/targets.bzl +++ b/runtime/core/portable_type/c10/c10/targets.bzl @@ -61,11 +61,7 @@ def define_common_targets(): runtime.cxx_library( name = "aten_headers_for_executorch", srcs = [], - visibility = [ - "//executorch/kernels/optimized/...", - "//executorch/kernels/portable/cpu/util/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], # select() on ovr_config//runtime:fbcode does not work # properly in all cases. I have seen # //xplat/executorch/runtime/core/portable_type/c10/c10:aten_headers_for_executorch @@ -124,10 +120,7 @@ def define_common_targets(): "-DC10_USE_GLOG", "-DC10_USE_MINIMAL_GLOG", ]), - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core/portable_type/c10/torch/headeronly:torch_headeronly", ] + select({ @@ -142,8 +135,5 @@ def define_common_targets(): runtime.cxx_library( name = "c10", exported_deps = [":aten_headers_for_executorch"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/runtime/core/targets.bzl b/runtime/core/targets.bzl index e8240135a69..2c13cdbdae3 100644 --- a/runtime/core/targets.bzl +++ b/runtime/core/targets.bzl @@ -50,10 +50,7 @@ def define_common_targets(): "result.h", "span.h", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_preprocessor_flags = get_core_flags(), exported_deps = [ "//executorch/runtime/core/portable_type/c10/c10:c10", @@ -82,10 +79,7 @@ def define_common_targets(): ":core", "//executorch/runtime/core/portable_type/c10/c10:c10", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) for aten_mode in get_aten_mode_options(): @@ -96,10 +90,7 @@ def define_common_targets(): "evalue.h", ], srcs = ["evalue.cpp"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":core", ":tag", @@ -114,10 +105,7 @@ def define_common_targets(): "event_tracer_hooks.h", "event_tracer_hooks_delegate.h", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_preprocessor_flags = get_event_tracer_flags() + get_sdk_flags(), exported_deps = [ "//executorch/runtime/platform:platform", @@ -130,10 +118,7 @@ def define_common_targets(): exported_headers = [ "named_data_map.h", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":tensor_layout" + aten_suffix, "//executorch/runtime/core/exec_aten:lib" + aten_suffix, diff --git a/runtime/core/testing_util/targets.bzl b/runtime/core/testing_util/targets.bzl index 40ced267915..dbab5977d67 100644 --- a/runtime/core/testing_util/targets.bzl +++ b/runtime/core/testing_util/targets.bzl @@ -15,10 +15,7 @@ def define_common_targets(): exported_headers = [ "error_matchers.h", ], - visibility = [ - "//executorch/runtime/core/testing_util/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_external_deps = [ "gmock", ], diff --git a/runtime/executor/targets.bzl b/runtime/executor/targets.bzl index 103ea299c34..28defd6ab11 100644 --- a/runtime/executor/targets.bzl +++ b/runtime/executor/targets.bzl @@ -37,10 +37,7 @@ def define_common_targets(): exported_deps = [ "//executorch/runtime/core:memory_allocator", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) @@ -55,10 +52,7 @@ def define_common_targets(): exported_headers = [ "pte_data_map.h", ], - visibility = [ - "//executorch/runtime/executor/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", "//executorch/runtime/core:named_data_map" + aten_suffix, @@ -86,10 +80,7 @@ def define_common_targets(): ":program_no_prim_ops" + aten_suffix, "//executorch/kernels/prim_ops:prim_ops_registry" + aten_suffix, ], - visibility = [ - "//executorch/runtime/executor/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -132,8 +123,5 @@ def define_common_targets(): "//executorch/schema:program", "//executorch/runtime/core/exec_aten/util:tensor_dimension_limit" ], - visibility = [ - "//executorch/runtime/executor/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/runtime/executor/test/targets.bzl b/runtime/executor/test/targets.bzl index 1174b01f42b..0fac69b6a48 100644 --- a/runtime/executor/test/targets.bzl +++ b/runtime/executor/test/targets.bzl @@ -81,11 +81,7 @@ def define_common_targets(is_fbcode = False): exported_headers = [ "managed_memory_manager.h", ], - visibility = [ - "//executorch/runtime/executor/test/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/core:memory_allocator", "//executorch/runtime/executor:memory_manager", diff --git a/runtime/kernel/targets.bzl b/runtime/kernel/targets.bzl index 92e30016f42..123dc1ac8da 100644 --- a/runtime/kernel/targets.bzl +++ b/runtime/kernel/targets.bzl @@ -28,10 +28,7 @@ def define_common_targets(): name = "operator_registry_MAX_NUM_KERNELS_TEST_ONLY", srcs = ["operator_registry.cpp"], exported_headers = ["operator_registry.h"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", "//executorch/runtime/core:evalue", @@ -60,10 +57,7 @@ def define_common_targets(): name = "operator_registry" + aten_suffix, srcs = ["operator_registry.cpp"], exported_headers = ["operator_registry.h"], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", "//executorch/runtime/core:evalue" + aten_suffix, @@ -76,12 +70,7 @@ def define_common_targets(): exported_headers = [ "kernel_runtime_context.h", ], - visibility = [ - "//executorch/kernels/...", - "//executorch/runtime/executor/...", - "//executorch/runtime/kernel/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ "//executorch/runtime/core:core", "//executorch/runtime/platform:platform", @@ -98,12 +87,7 @@ def define_common_targets(): exported_headers = [ "kernel_includes.h", ], - visibility = [ - "//executorch/runtime/kernel/...", - "//executorch/kernels/...", - "//executorch/kernels/prim_ops/...", # Prim kernels - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ ":kernel_runtime_context" + aten_suffix, "//executorch/runtime/core/exec_aten:lib" + aten_suffix, diff --git a/runtime/platform/targets.bzl b/runtime/platform/targets.bzl index 457deed531e..65d92b134d6 100644 --- a/runtime/platform/targets.bzl +++ b/runtime/platform/targets.bzl @@ -81,10 +81,7 @@ def define_common_targets(): ":compiler", ":platform_private", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], # WARNING: using a deprecated API to avoid being built into a shared # library. In the case of dynamically loading so library we don't want # it to depend on other so libraries because that way we have to @@ -110,10 +107,7 @@ def define_common_targets(): "ovr_config//os:macos": ["-DET_USE_LIBDL"], }, ), - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) # Common compiler directives such as 'unlikely' or 'deprecated' @@ -122,8 +116,5 @@ def define_common_targets(): exported_headers = [ "compiler.h", ], - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/shim_et/xplat/executorch/build/runtime_wrapper.bzl b/shim_et/xplat/executorch/build/runtime_wrapper.bzl index 16a204aafc5..f03ddc6c76d 100644 --- a/shim_et/xplat/executorch/build/runtime_wrapper.bzl +++ b/shim_et/xplat/executorch/build/runtime_wrapper.bzl @@ -184,17 +184,7 @@ def _patch_kwargs_common(kwargs): """ env.remove_unsupported_kwargs(kwargs) - # Be careful about dependencies on executorch targets for now, so that we - # don't pick up unexpected clients while things are still in flux. - if not kwargs.pop("_is_external_target", False): - for target in kwargs.get("visibility", []): - if not (target == "PUBLIC" or target.startswith("//executorch") or target.startswith("//pytorch/tokenizers") or target.startswith("@")): - fail("Please manage all external visibility using the " + - "EXECUTORCH_CLIENTS list in " + - "//executorch/build/fb/clients.bzl. " + - "Found external visibility target \"{}\".".format(target)) - else: - kwargs.pop("_is_external_target", None) + kwargs.pop("_is_external_target", False) # Convert `[exported_]external_deps` entries into real deps if necessary. _resolve_external_deps(kwargs) diff --git a/shim_et/xplat/executorch/codegen/codegen.bzl b/shim_et/xplat/executorch/codegen/codegen.bzl index 5aa4fdde58d..a87ddcb109b 100644 --- a/shim_et/xplat/executorch/codegen/codegen.bzl +++ b/shim_et/xplat/executorch/codegen/codegen.bzl @@ -573,7 +573,7 @@ def build_portable_lib( portable_header_lib = None, feature = None, expose_operator_symbols = False, - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], platforms = get_default_executorch_platforms()): """ WARNING: Before using this, please consider using executorch_generated_lib instead. This diff --git a/shim_et/xplat/executorch/kernels/optimized/lib_defs.bzl b/shim_et/xplat/executorch/kernels/optimized/lib_defs.bzl index 4dd7e2c7672..f832c361acd 100644 --- a/shim_et/xplat/executorch/kernels/optimized/lib_defs.bzl +++ b/shim_et/xplat/executorch/kernels/optimized/lib_defs.bzl @@ -82,10 +82,7 @@ def define_libs(): "vec/**/*.h", ]), header_namespace = "executorch/kernels/optimized", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = select({ "ovr_config//os:linux": [ "fbsource//third-party/sleef:sleef", @@ -104,10 +101,7 @@ def define_libs(): "utils/**/*.h", ]), header_namespace = "executorch/kernels/optimized", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], exported_deps = [ # Needed to access the ET_INLINE macro "//executorch/runtime/platform:compiler", @@ -123,10 +117,7 @@ def define_libs(): "blas/**/*.h", ]), header_namespace = "executorch/kernels/optimized", - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], preprocessor_flags = select({ "ovr_config//os:android-arm64": [ "-DET_BUILD_WITH_BLAS", diff --git a/shim_et/xplat/executorch/kernels/optimized/op_registration_util.bzl b/shim_et/xplat/executorch/kernels/optimized/op_registration_util.bzl index 345794151a4..bc43688b04e 100644 --- a/shim_et/xplat/executorch/kernels/optimized/op_registration_util.bzl +++ b/shim_et/xplat/executorch/kernels/optimized/op_registration_util.bzl @@ -92,13 +92,7 @@ def define_op_library(name, compiler_flags, deps): srcs = [ "{}.cpp".format(name), ], - visibility = [ - "//executorch/kernels/portable/test/...", - "//executorch/kernels/quantized/test/...", - "//executorch/kernels/optimized/test/...", - "//executorch/kernels/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], compiler_flags = [ # kernels often have helpers with no prototypes just disabling the warning here as the headers # are codegend and linked in later diff --git a/shim_et/xplat/executorch/kernels/portable/op_registration_util.bzl b/shim_et/xplat/executorch/kernels/portable/op_registration_util.bzl index 4fc3f9c63e7..e8692072362 100644 --- a/shim_et/xplat/executorch/kernels/portable/op_registration_util.bzl +++ b/shim_et/xplat/executorch/kernels/portable/op_registration_util.bzl @@ -116,13 +116,7 @@ def define_op_library(name, deps, android_deps, aten_target, _allow_third_party_ srcs = [ "{}.cpp".format(name), ], - visibility = [ - "//executorch/kernels/portable/test/...", - "//executorch/kernels/quantized/...", - "//executorch/kernels/optimized/test/...", - "//executorch/kernels/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], # kernels often have helpers with no prototypes just disabling the warning here as the headers # are codegend and linked in later compiler_flags = select({ diff --git a/shim_et/xplat/executorch/kernels/prim_ops/selective_build.bzl b/shim_et/xplat/executorch/kernels/prim_ops/selective_build.bzl index 73421f031ec..4d73e86dfb5 100644 --- a/shim_et/xplat/executorch/kernels/prim_ops/selective_build.bzl +++ b/shim_et/xplat/executorch/kernels/prim_ops/selective_build.bzl @@ -38,10 +38,7 @@ def prim_ops_registry_selective(name, selected_prim_ops_header_target, aten_suff "selective_build_prim_ops.h": ":" + genrule_dep_name + "[selective_build_prim_ops.h]", "selected_prim_ops.h": ":" + genrule_dep_name + "[selected_prim_ops.h]" }, - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], # @lint-ignore BUCKLINT link_whole, need this to register prim ops. link_whole = True, # prim ops are registered through a global table so the ctor needs to be allowed diff --git a/test/models/targets.bzl b/test/models/targets.bzl index ab619351cb9..2ae26d8217d 100644 --- a/test/models/targets.bzl +++ b/test/models/targets.bzl @@ -206,12 +206,7 @@ def define_common_targets(): for fname in DELEGATED_MODULES_TO_EXPORT }, default_outs = ["."], - visibility = [ - "//executorch/runtime/executor/test/...", - "//executorch/backends/test/...", - "//executorch/test/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], env = {"PYTORCH_DISABLE_JUSTKNOBS": "1",}, ) diff --git a/test/targets.bzl b/test/targets.bzl index 3c2a69f592b..023a1d48960 100644 --- a/test/targets.bzl +++ b/test/targets.bzl @@ -45,7 +45,5 @@ def define_common_targets(): runtime.export_file( name = "size_test.cpp", - visibility = [ - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], ) diff --git a/test/utils/targets.bzl b/test/utils/targets.bzl index 249e7bdf2be..6b7923a6675 100644 --- a/test/utils/targets.bzl +++ b/test/utils/targets.bzl @@ -19,11 +19,7 @@ def define_common_targets(): "alignment.h", "DeathTest.h", ], - visibility = [ - "//executorch/...", - "//pytorch/tokenizers/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//executorch/runtime/platform:platform", "//executorch/runtime/core:core", diff --git a/third-party/flatcc_defs.bzl b/third-party/flatcc_defs.bzl index 4197bd0c33c..792d128e979 100644 --- a/third-party/flatcc_defs.bzl +++ b/third-party/flatcc_defs.bzl @@ -85,7 +85,7 @@ def define_flatcc_targets(): "include", ], headers = PUBLIC_HEADERS, - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) runtime.cxx_library( @@ -166,7 +166,7 @@ def define_flatcc_targets(): "flatcc/src/compiler/keywords.h", "flatcc/src/compiler/codegen_c_sort.h", ], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], deps = [":flatccrt"], ) @@ -249,7 +249,7 @@ def define_flatcc_targets(): "flatcc/src/compiler/keywords.h", "flatcc/src/compiler/codegen_c_sort.h", ]), - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) # FlatCC CLI @@ -266,5 +266,5 @@ def define_flatcc_targets(): "flatcc/config", ], deps = [":flatcc-host"], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], ) diff --git a/util/TARGETS b/util/TARGETS index 3b7d8afef1c..58b36596e0e 100644 --- a/util/TARGETS +++ b/util/TARGETS @@ -14,10 +14,7 @@ runtime.python_library( "activation_memory_profiler.py", ], _is_external_target = True, - visibility = [ - "//executorch/...", - "@EXECUTORCH_CLIENTS", - ], + visibility = ["PUBLIC"], deps = [ "//caffe2:torch", "//executorch/exir:lib", diff --git a/util/targets.bzl b/util/targets.bzl index 5c5d7401d51..c7f490a450b 100644 --- a/util/targets.bzl +++ b/util/targets.bzl @@ -17,6 +17,6 @@ def define_common_targets(): "fbsource//third-party/pypi/snakeviz:snakeviz", "fbsource//third-party/pypi/tornado:tornado", ], - visibility = ["@EXECUTORCH_CLIENTS"], + visibility = ["PUBLIC"], _is_external_target = True, )