Move etensor types to their new namespace #5569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5569
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit bda0a3c with merge base 905b88c ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63294217 |
|
This pull request was exported from Phabricator. Differential Revision: D63294217 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 24, 2024
Summary: Pull Request resolved: pytorch#5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Differential Revision: D63294217
dbort
force-pushed
the
export-D63294217
branch
from
3ce4d05 to
9901435
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63294217 |
dbort
force-pushed
the
export-D63294217
branch
from
9901435 to
c67c41f
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: pytorch#5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Differential Revision: D63294217
swolchok
approved these changes
Sep 27, 2024
dbort
force-pushed
the
export-D63294217
branch
from
c67c41f to
2387159
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: pytorch#5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217
|
This pull request was exported from Phabricator. Differential Revision: D63294217 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D63294217 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: pytorch#5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217
dbort
force-pushed
the
export-D63294217
branch
from
2387159 to
7a391d8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63294217 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: pytorch#5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217
dbort
force-pushed
the
export-D63294217
branch
from
7a391d8 to
39c0e1c
Compare
Summary: Pull Request resolved: pytorch#5709 I'm not sure how this worked before, but these sites called functions under torch::executor without actually qualifying them. Qualify them explicitly, because the "can call without qualification" magic stops working when we move the etensor types in D63294217. In a few places I used `namespace etrt = executorch::runtime;` instead of a using statement for a particular function, like `etrt::isIntegralType`. If I just say `using executorch::runtime::isIntegralType`, those files fail in aten mode because the unqualified call to `isIntegralType()` is deemed ambiguous in the presence of `c10::isIntegralType()` -- but afaict that `c10` version isn't `using`'d into the global namespace, so I don't know why it conflicts. It'd be good to figure that out at some point, but this works for now. I also updated custom_kernel_example to stop using the `torch::` namespace. Differential Revision: D63476419 Reviewed By: swolchok
|
This pull request was exported from Phabricator. Differential Revision: D63294217 |
dbort
force-pushed
the
export-D63294217
branch
from
39c0e1c to
8a3a014
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: pytorch#5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217
Summary: Pull Request resolved: pytorch#5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217
dbort
force-pushed
the
export-D63294217
branch
from
8a3a014 to
bda0a3c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63294217 |
|
This pull request has been merged in 6ff52cc. |
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: #5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217 fbshipit-source-id: 5241fd5a0b487631b6460222b6c3e27e82aea5f0 (cherry picked from commit 6ff52cc)
Cherry picking #5569The cherry pick PR is at #5773 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
dbort
added a commit
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: #5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217 fbshipit-source-id: 5241fd5a0b487631b6460222b6c3e27e82aea5f0 (cherry picked from commit 6ff52cc)
dbort
added a commit
that referenced
this pull request
Oct 3, 2024
Move etensor types to their new namespace (#5569) Summary: Pull Request resolved: #5569 Move these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`. Most users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal. Also: - Hide bfloat16's `bits_from_f32`, which was only used by tests - Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`. - Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace Reviewed By: swolchok Differential Revision: D63294217 fbshipit-source-id: 5241fd5a0b487631b6460222b6c3e27e82aea5f0 (cherry picked from commit 6ff52cc) Co-authored-by: Dave Bort <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move these types out of the old
torch::executornamespace. Put them in their own namespace so that no-one will see them by default, unlike their old location intorch::executor.Most users should not use these directly, instead using the
executorch::atenaliases. These ETensor types live underexecutorch::runtime...to make it a little more clear that they're semi-internal.Also:
bits_from_f32, which was only used by testsminimplementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code intorch::executor.Differential Revision: D63294217