[ET-VK] Fix VK_NULL_HANDLE comparison style
#5733
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`VK_NULL_HANDLE` is a constant and should hence be the right hand side of the expression. Fixing the expressions where it's on the left hand side. Differential Revision: [D63560116](https://our.internmc.facebook.com/intern/diff/D63560116/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5733
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4b8924c with merge base 13869ec ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63560116 |
junpi3
pushed a commit
that referenced
this pull request
Sep 27, 2024
`VK_NULL_HANDLE` is a constant and should hence be the right hand side of the expression. Fixing the expressions where it's on the left hand side. Differential Revision: [D63560116](https://our.internmc.facebook.com/intern/diff/D63560116/) ghstack-source-id: 245169615 Pull Request resolved: #5733
SS-JIA
approved these changes
Sep 27, 2024
|
This pull request has been merged in 8b5cf96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
VK_NULL_HANDLEcomparison style #5733VK_NULL_HANDLEis a constant and should hence be the right hand side of the expression. Fixing the expressions where it's on the left hand side.Differential Revision: D63560116