[ExecuTorch] Rework apply_ternary_elementwise_fn to allow fixing op_clamp build time (1/2) #5783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lamp build time (1/2) This diff is a simple refactor that shouldn't materially change the generated code -- we still create a "kernel" for each combination of input1/input2/input3/output dtypes. The following diff will use this to improve op_clamp (but not op_where, because one of the input types is fixed, so it's not as bad a build time outlier) build time. Differential Revision: [D63681033](https://our.internmc.facebook.com/intern/diff/D63681033/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5783
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d4ee935 with merge base 944bd67 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63681033 |
Contributor
Author
|
combining into #5784 |
Contributor
Author
|
folded into following PR |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
…lamp build time (1/2) This diff is a simple refactor that shouldn't materially change the generated code -- we still create a "kernel" for each combination of input1/input2/input3/output dtypes. The following diff will use this to improve op_clamp (but not op_where, because one of the input types is fixed, so it's not as bad a build time outlier) build time. Differential Revision: [D63681033](https://our.internmc.facebook.com/intern/diff/D63681033/) ghstack-source-id: 245613706 Pull Request resolved: pytorch/executorch#5783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff is a simple refactor that shouldn't materially
change the generated code -- we still create a "kernel" for each
combination of input1/input2/input3/output dtypes. The following diff
will use this to improve op_clamp (but not op_where, because one of
the input types is fixed, so it's not as bad a build time outlier)
build time.
Differential Revision: D63681033