[ExecuTorch] Unbreak optimized sub in the case where one input is a scalar and both are Half #5894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calar and both are Half I misplaced a return. Caught this during development in div, but not sub. Differential Revision: [D63919553](https://our.internmc.facebook.com/intern/diff/D63919553/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5894
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3020923 with merge base 20a157f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Oct 4, 2024
…calar and both are Half I misplaced a return. Caught this during development in div, but not sub. Differential Revision: [D63919553](https://our.internmc.facebook.com/intern/diff/D63919553/) ghstack-source-id: 246398371 Pull Request resolved: #5894
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63919553 |
Contributor
Author
|
this will need a pick to release/0.4 |
swolchok
requested review from
GregoryComer,
kirklandsign and
manuelcandales
and removed request for
GregoryComer
kirklandsign
approved these changes
Oct 4, 2024
Contributor
|
This pull request has been merged in 1052e3b. |
Contributor
Author
|
@pytorchbot cherrypick --onto release/0.4 -c regression |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
Author
|
@pytorchbot cherry-pick --onto release/0.4 -c regression |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 7, 2024
…pe is mixed or both are Half (#5894) Summary: Pull Request resolved: #5894 I misplaced a return. Caught this during development in div, but not sub. ghstack-source-id: 246398371 exported-using-ghexport Reviewed By: kirklandsign Differential Revision: D63919553 fbshipit-source-id: 84e27efc400711ae0253e48a4dbdb4b419140925 (cherry picked from commit 1052e3b)
Collaborator
Cherry picking #5894The cherry pick PR is at #5940 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 9, 2024
…calar and both are Half (#5940) Unbreak optimized sub in the case where one input is a scalar and dtype is mixed or both are Half (#5894) Summary: Pull Request resolved: #5894 I misplaced a return. Caught this during development in div, but not sub. ghstack-source-id: 246398371 exported-using-ghexport Reviewed By: kirklandsign Differential Revision: D63919553 fbshipit-source-id: 84e27efc400711ae0253e48a4dbdb4b419140925 (cherry picked from commit 1052e3b) Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I misplaced a return. Caught this during development in div, but not sub.
Differential Revision: D63919553