Rename executorch_no_prim_ops to executorch_core #5923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Minor CMake target cleanup for beta. Pull Request resolved: pytorch#5740 Reviewed By: shoumikhin Differential Revision: D63576097 Pulled By: GregoryComer fbshipit-source-id: b10f9f15cfcae3bce769d07cd014e8064d735dbd
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5923
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 5541a50 with merge base eecf74f ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
reviewed
Oct 7, 2024
Contributor
jackzhxng
left a comment
jackzhxng
left a comment
There was a problem hiding this comment.
Why is this needed on for the release? Can it wait for the next release patch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually cherry-picked to resolve a merge conflict (training extension CMake build not present on release branch?).
Original PR: #5740