Skip to content

Migrate backends/apple/coreml to the new namespace #5943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Migrate backends/apple/coreml to the new namespace #5943

wants to merge 1 commit into from

Conversation

@dbort
Copy link
Contributor

@dbort dbort commented Oct 7, 2024

Summary: Move the Core ML backend out of the torch:: namespace, and update to avoid using the torch:: or exec_aten:: namespaces.

Differential Revision: D63995558

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5943

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f62dff9 with merge base cb3a546 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63995558

@cccclai cccclai requested a review from cymbalrush October 7, 2024 19:05
@cccclai
Copy link
Contributor

cccclai commented Oct 7, 2024

@cymbalrush can you take a look?

facebook-github-bot pushed a commit that referenced this pull request Oct 8, 2024
@dbort @facebook-github-bot
Migrate backends/apple/coreml to the new namespace (#5943)
faf04ce 
Summary:

Move the Core ML backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Differential Revision: D63995558
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63995558

cccclai
cccclai approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if CI passes

@cccclai cccclai requested a review from YifanShenSZ October 8, 2024 23:24
cymbalrush
cymbalrush approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@cymbalrush cymbalrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

YifanShenSZ
YifanShenSZ approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@YifanShenSZ YifanShenSZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

facebook-github-bot pushed a commit that referenced this pull request Oct 9, 2024
@dbort @facebook-github-bot
Migrate backends/apple/coreml to the new namespace (#5943)
eef28da 
Summary:

Move the Core ML backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D63995558
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 9, 2024

This pull request was exported from Phabricator. Differential Revision: D63995558

facebook-github-bot pushed a commit that referenced this pull request Oct 9, 2024
@dbort @facebook-github-bot
Migrate backends/apple/coreml to the new namespace (#5943)
0e8a335 
Summary:

Move the Core ML backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D63995558
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 9, 2024

This pull request was exported from Phabricator. Differential Revision: D63995558

@dbort @facebook-github-bot
Migrate backends/apple/coreml to the new namespace (#5943)
f62dff9 
Summary:

Move the Core ML backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D63995558
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 9, 2024

This pull request was exported from Phabricator. Differential Revision: D63995558

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 9, 2024

This pull request has been merged in 80afaf2.

@dbort
Copy link
Contributor Author

dbort commented Oct 9, 2024

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 9, 2024
@dbort @pytorchbot
Migrate backends/apple/coreml to the new namespace (#5943)
d4604ff 
Summary:
Pull Request resolved: #5943

Move the Core ML backend out of the `torch::` namespace, and update to avoid using the `torch::` or `exec_aten::` namespaces.

Reviewed By: cccclai

Differential Revision: D63995558

fbshipit-source-id: 0d027a5ea42a9e989e33eddaa7cce1c92fdd0b21
(cherry picked from commit 80afaf2)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Oct 9, 2024

Cherry picking #5943

The cherry pick PR is at #6076 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 9, 2024
Closed
@dbort dbort deleted the export-D63995558 branch October 9, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

+2 more reviewers

@cymbalrush cymbalrush cymbalrush approved these changes

@YifanShenSZ YifanShenSZ YifanShenSZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dbort @facebook-github-bot @cccclai @pytorchbot @cymbalrush @YifanShenSZ