Skip to content

Conversation

@kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6364

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9ac356f with merge base 47bca20 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 18, 2024
@kirklandsign kirklandsign force-pushed the android-instrumentation branch 4 times, most recently from ba54b24 to 9ac2b5c Compare October 29, 2024 21:05
Collect artifacts from previous job and run validation
@kirklandsign kirklandsign force-pushed the android-instrumentation branch from 9ac2b5c to 76c86f1 Compare October 29, 2024 21:38
@kirklandsign kirklandsign requested a review from huydhn October 29, 2024 23:24
@huydhn huydhn added the ciflow/android Trigger Android CI label Oct 30, 2024
@huydhn
Copy link
Contributor

huydhn commented Oct 30, 2024

Is the test-llama-runner-linux job in pull the one that export the models and upload them to S3? If yes, I think you need to edit Android job in pull to depend on it:

android:
  need: test-llama-runner-linux
  uses: ./.github/workflows/_android.yml

Otherwise, Android job might finish before the models are exported

@kirklandsign
Copy link
Contributor Author

Is the test-llama-runner-linux job in pull the one that export the models and upload them to S3? If yes, I think you need to edit Android job in pull to depend on it:

android:
  need: test-llama-runner-linux
  uses: ./.github/workflows/_android.yml

Otherwise, Android job might finish before the models are exported

Yes. Thank you for the suggestions!

It's a bit sad that timing wise it's a bit longer due to the dependency. Also we can't really trigger _android.yml from workflow dispatch. It's ok for now.

@kirklandsign kirklandsign merged commit fd2844c into main Oct 30, 2024
39 checks passed
@kirklandsign kirklandsign deleted the android-instrumentation branch October 30, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/android Trigger Android CI CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants