-
Notifications
You must be signed in to change notification settings - Fork 731
[Executorch][optimized] Fix op_div impl to use portable for fallback path #6714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/kimishpatel/134/base
Are you sure you want to change the base?
Conversation
…path Earlier we just copy pasted from portable impl. This diff refactors portable to make it usable from optimized lib. As a result we get all the size reduction benefit from build and size optimizations landed in portable. Differential Revision: [D65606665](https://our.internmc.facebook.com/intern/diff/D65606665/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6714
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2787854 with merge base 39e5b91 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D65606665 |
…r fallback path" Earlier we just copy pasted from portable impl. This diff refactors portable to make it usable from optimized lib. As a result we get all the size reduction benefit from build and size optimizations landed in portable. Differential Revision: [D65606665](https://our.internmc.facebook.com/intern/diff/D65606665/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65606665 |
…r fallback path" Earlier we just copy pasted from portable impl. This diff refactors portable to make it usable from optimized lib. As a result we get all the size reduction benefit from build and size optimizations landed in portable. Differential Revision: [D65606665](https://our.internmc.facebook.com/intern/diff/D65606665/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65606665 |
…r fallback path" Earlier we just copy pasted from portable impl. This diff refactors portable to make it usable from optimized lib. As a result we get all the size reduction benefit from build and size optimizations landed in portable. Differential Revision: [D65606665](https://our.internmc.facebook.com/intern/diff/D65606665/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65606665 |
…r fallback path" Earlier we just copy pasted from portable impl. This diff refactors portable to make it usable from optimized lib. As a result we get all the size reduction benefit from build and size optimizations landed in portable. Differential Revision: [D65606665](https://our.internmc.facebook.com/intern/diff/D65606665/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65606665 |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
Earlier we just copy pasted from portable impl. This diff refactors portable to
make it usable from optimized lib. As a result we get all the size reduction
benefit from build and size optimizations landed in portable.
Differential Revision: D65606665