Skip to content

Conversation

@davidlin54
Copy link
Contributor

@davidlin54 davidlin54 commented Nov 11, 2024

Added instrumentation test for LlamaModule.

  1. Modified setup.sh to include building stories110M model and moves it into src/androidTest/resources
  2. Added test cases for LlamaModule by generating a sequence length of 32, and verifying the length. Also verifies that stop() works by checking output length is less than input sequence length

[ghstack-poisoned]
@davidlin54
Copy link
Contributor Author

davidlin54 commented Nov 11, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6759

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e36ca0a with merge base b23c9e6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2024
Copy link
Contributor

@kirklandsign kirklandsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@kirklandsign kirklandsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlin54
Copy link
Contributor Author

You can also add it to https://github.com/pytorch/executorch/blob/main/.github/workflows/_android.yml#L99 if you are interested

will add in a follow up!

@davidlin54 davidlin54 merged commit 2660287 into main Nov 11, 2024
37 checks passed
@davidlin54 davidlin54 deleted the gh/davidlin54/3/head branch November 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants